From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by sourceware.org (Postfix) with ESMTPS id 76105387159E for ; Fri, 16 Dec 2022 20:17:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 76105387159E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=oracle.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=oracle.com Received: from pps.filterd (m0246632.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 2BGGhg8M004979; Fri, 16 Dec 2022 20:17:00 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=message-id : date : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2022-7-12; bh=Fh2Fo33Qww3sOud1JTcIGvjfxhv7ULFqsdyv33AWT60=; b=oISOgCvMxNZ51sn7oLsq5aYnFTc6ijQHKn37bmjguF2FHjVhgM2WNa4AjxJjVoZ+mLGP GyUKDv/TJJAXVDKZ59yc/4x/ejUKOVYywCJfgMawJQaoe1eoxMTa8qSEy6Bwy1R96iw/ zOOpbnF8RuafXPtjlJfqUuuqKnwQ6G7RbfWh2uGD4kuFAZ1s/RHb5ki+5ikA5haLWf6L kNI6z96oMCLXCj1ABhIrIXSWf4sPQOdScrD8H5pT3PrQ1TXF80BV0sbiu80td8/Fv3na wbgF+Ru7L0c4ZpO1AbedviHeBy4vLhYlQbKrqF4b31MW8D+QUUEe0BqigJIHkqsZrmKJ Ag== Received: from phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta03.appoci.oracle.com [138.1.37.129]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3meyes0e0r-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 16 Dec 2022 20:16:59 +0000 Received: from pps.filterd (phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.5/8.17.1.5) with ESMTP id 2BGJ97hv034883; Fri, 16 Dec 2022 20:16:59 GMT Received: from nam12-bn8-obe.outbound.protection.outlook.com (mail-bn8nam12lp2173.outbound.protection.outlook.com [104.47.55.173]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3meyer1f5x-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 16 Dec 2022 20:16:59 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PJx95eqIHD9wh0DLJvCqlwP1Icx7pe0iZ5KpNYXB10JFZlHw7bPqdyFtM0VQ9uv/LJfFJOiSO5goklbBsSCjsOc7NbSB8IMc4xfpSCchZvp4YYvQ/ISzMCDHccc8mSZNzXkaaqWZghw9JMhoagqg/RcfaVcV7xjhGxRxIzg2uAiozd7fEkw7HeV64Y/Ooc0JlkD00eOkcNvv7YLSylFawjU44ciIuwrTVvP5zhfIIo7I8eMQwXZALOMVDHwHH1C+XP6O+ezsLmReLqslKxZhYX+yADUcp3d0VqDmABpZwPw53QYxqZeMEFSL2QIbG56wVEMNW3aMNyAe46/z653rjA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Fh2Fo33Qww3sOud1JTcIGvjfxhv7ULFqsdyv33AWT60=; b=dzuLZthf/uDEtXrskeJR+L4OrEPY7upR7lq/4aBFuEMyI7kmwjqr6C+Z2Ijdxt4IC7cymLzd91ya+KfzpZ8AGKhMWJg6WTNV01F2RmYA5tsumgRDgo8A3AX0LGCQXfo5COr9y1Cb5lsiDNUjQBcrmYQHM81g/trfXugBuat3TFNf9QjN96CARZ2VTYYV78pc/OwKxQjlMdX8985EL9X3nz++hSej3rwvpdud+bH8X7rzzYaJNNfH7vbggWfiP62Pxsi36tL/reVPLlpoQS3js86FSoZIzzD1fOtE7pxU0uXMgfTqypshawjNIUCvlzPacguoUMfFA24LokZSjtZmBA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Fh2Fo33Qww3sOud1JTcIGvjfxhv7ULFqsdyv33AWT60=; b=EahbqxPtTSPN7ApbVgZ17U5Ol8B8FEEpSPuPamgBAfd48+MKjAHGvbtBxVdY4E9ecL+k2y2pVj6LmB/ciVmOLQJhjj6iud6cFB1/XFQGvMPlOtXYR0gF5j+Jk0/ya5w8CZkubi7i9WyTME6FebNLlXaHKfdUhweplUhYji7Qy/M= Received: from SA2PR10MB4636.namprd10.prod.outlook.com (2603:10b6:806:11e::10) by CO1PR10MB4642.namprd10.prod.outlook.com (2603:10b6:303:6f::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5924.11; Fri, 16 Dec 2022 20:16:56 +0000 Received: from SA2PR10MB4636.namprd10.prod.outlook.com ([fe80::1665:9f7e:853b:d138]) by SA2PR10MB4636.namprd10.prod.outlook.com ([fe80::1665:9f7e:853b:d138%9]) with mapi id 15.20.5880.021; Fri, 16 Dec 2022 20:16:56 +0000 Message-ID: Date: Fri, 16 Dec 2022 12:16:52 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: Re: [PATCH 0/4] gprofng: small testsuite adjustments Content-Language: en-US To: Jan Beulich Cc: Binutils References: From: Vladimir Mezentsev In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: BYAPR04CA0018.namprd04.prod.outlook.com (2603:10b6:a03:40::31) To SA2PR10MB4636.namprd10.prod.outlook.com (2603:10b6:806:11e::10) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SA2PR10MB4636:EE_|CO1PR10MB4642:EE_ X-MS-Office365-Filtering-Correlation-Id: 00d8d77e-0e3f-4dc8-c062-08dadfa27a12 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: IgTDHnEuii9RD/waZulPPBXtU4phrwcpVx/u8QOTInKuiJjzUkrbJi+s5Yrqmx5T7FXPgDmE2v4tW/VN63+C3upW3x9d6Xle/aORIyj9RwXzsVx4MHNoKkR8/20wpy1ARLzebwgIYd1l33bEp9Bd86HwSTuH/SMBU/ZJTceGdFmbe7i6gvKjKAot928dSgVuLgxckQr1C/oERCb4M3x/swnCMc+DFya0VH2MWu1rWb2exbkM+DNkLDUoPNC6FinPMID/nk6bowet+dVL2yHUV60pbUE6Fr26PhWmqoOHSO5KzvTDbMbh6Enhy2tE9kZwlAFSdP5CSH8PUEV2BUoJqfDCBRc9d4AQZskU0mfRhCqj9mAQ6QTkKMG4h6UKsRfTqgVhT++/b+YpT1+sqasKdLODnJh7VtRzvePI5xNxUju8NqDbyAOCSIEWx8gROsElaEgFErOqUQeCed2CV30OOS+s8QlA05AOHAMiVQQ361WVss4A8nsK2P/zDr8f2IvHNIZgeRg8HmCKtT0nLOQeMr5ABxgIPJPCv7WIq1gJbwQScMek7fAlMpxoS30g44u8L+Tg4VDGmJaBqcJlX2zsM0OFos4Ur0KJfHppzlyIel3z2M3PbbHfMPGoV2tvyLmmR/cRy8xhmRraRrG9O27DaH8S7IriWp7rgOHLcWPDOWPLDdohuFJ45X7Gm9IJv02Pks9O5/I6BLSKeTS/SGaEZj9Qd3aVHKtjNF0Df7oTirU= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SA2PR10MB4636.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(376002)(366004)(136003)(39860400002)(346002)(396003)(451199015)(66556008)(66946007)(8676002)(66476007)(4326008)(5660300002)(2906002)(316002)(41300700001)(8936002)(53546011)(6916009)(186003)(6506007)(6486002)(6512007)(6666004)(478600001)(86362001)(83380400001)(2616005)(44832011)(31686004)(38100700002)(31696002)(36756003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QjlDejZ5NnRldWV1WTB0a2szYkV3ZHdkZzJNRnlQdUJwMmdDTWJINWh1RFdq?= =?utf-8?B?YnpSUzFQRlNTNkNsVDFvOWZ0MnE4dUZldks2SFg4RUE4VU14aXltem9oZ2dJ?= =?utf-8?B?ci9GejJBK0c1S28rUzJnYmJhVTgreUdoWFdoVHFPTmliS3pSdW1pQUdhU1RZ?= =?utf-8?B?dnNLamZNY1k4aW40bDN0aEpTYjEzR2lweFNGK2FjOVpjcDAxYzI2UER6d1cz?= =?utf-8?B?bFVyNWNiZUN1cmZiWnlOcEl4OGl0S3VGREdZU24zNXRhbmNpMjNHREhaUUYy?= =?utf-8?B?ZHZWWHJWMlRQOTl3cjdINEgrTlFEbTQrT3cvOTI5bDBzc1ZHUEZJKythaU9k?= =?utf-8?B?RWtRY2RRK0tOWlFVQjNBUEpuREUrKzhHOFMvQjJmOEhTaTF1SlpJOHNPbE15?= =?utf-8?B?Zitrcy92R0VoN3hKQmtJNGQvUlhkbWpZazIwOWVrRWE0V080aSsyTGZnU0Mv?= =?utf-8?B?K1B5Rlc2aGpHa3JxLzYycmVYZ1BPUTArNFJjYmtPM2VKQW9FakNIRmpzanpC?= =?utf-8?B?TnN0SzU4YURDWG8zNjFpaE9DbVlJdVJDSHI0c016VWJZSGRXYjZlZ2w1QXpm?= =?utf-8?B?dElEMHVpb1hqMUpQMzkxekovbXpIZDc5eEJlV1hvYXF6Vm5hM2hvd29YSEFz?= =?utf-8?B?eElNWkFwQndqTVI3QkFOalFZNERMd1NBaFl3WUtlb0JqZ1lsYlVKTTZ1Vkhv?= =?utf-8?B?WUl1S0IwbktoQWVrZC8raThSQXdsY2ZrZTJpUFRWWDg1ZHcvTzZKb2lrbTlZ?= =?utf-8?B?UjBOajJsQStzeVozUm1kN0hQdW5YU1h4Z21DTmVidm5EL1hsQnBKRFdYM0ti?= =?utf-8?B?Y0pJUkdxMGl6cmR1b0FxTTY4bFBuUG9Ba1c0S2NGMG1WaFBURHg4WGpGaGdR?= =?utf-8?B?Yk1JNUxMSTA0OE5kYU4ySGlNTzdSQnhBSndRTGJVWWNwRHJ6UnMrQjFIVDA3?= =?utf-8?B?bnZvanRDVEdtU3NQUDErQnNFQ3VUOXJsTWw0NVRkdlp6bDFZOXNDZHNsbVNk?= =?utf-8?B?KzNObSt0RVpMNGJCa0QwWFB1S3gvNmxIUmptWXVxY2RZUkl1NGpERjI3Rmpo?= =?utf-8?B?RzdPTGRwN0tHcTcybFl3TXo3U3QxMXo3WFVFTDNzR2RYekkrWkN1TFJvWXRy?= =?utf-8?B?ZjZOZHM4bjdLaVVNWnlmWFdzcVlLQUFyQmJHNEp2RjNSWktmQ0tnUHo3NTFC?= =?utf-8?B?Tm92Rmdza2tEYmwwWmxGU0psMHp4NXdVR2YwNG5TZ3VyVllZNXlWS0UzTE1O?= =?utf-8?B?Z2d5TTlvbWpSY29YbFVNRzRkZUpPdnd5bitHVUZkSElZd0F3VnFKTlg3NjIy?= =?utf-8?B?NlNqNjNqYXVVMDN1SjJILzZITEpjY200UFd1ck5oVlo4YzZGTUF4UDkrZkZk?= =?utf-8?B?UzYrNlJuYzFNODFHSWZRR1dPL1BidlY4MHNNVlR6bGRoeVJoMEMwcEk0d0Jq?= =?utf-8?B?RUFwenVCYnBRQ0ZQQitVNm1WcEswYVRBNjJ3ZlhERHpmM01ucDBmM0lMNnR5?= =?utf-8?B?Q0hHQ293cllqb3h4c01TL0JCZnR6aFUvN05hN3doM0U2dDZZdk9VR1lpVmFL?= =?utf-8?B?MXlSV1lON1d5bUp1bWY2MG5wMzAzeTJydlJRM3IxY1RlWUJVUzZsV3E0R0pI?= =?utf-8?B?REQySW4vZWRKaUFUTi8rZklpV3cyd0M3aHlaOU5XYTFnYWd5UE1YWXJaVVRy?= =?utf-8?B?N29Yc3dmczhHdTN2UkFBbk9EbldybjRtbzZLZm9rQXFiWUVTQW9ZUFErbU41?= =?utf-8?B?NG9TMFZtbEYrVnZiTEFPTmMvQjY0VDU1OTFJSzRKNjlRd1V2b2dYWVAwR09a?= =?utf-8?B?NU9rRjg4U244YmlxTFpibUY3V0JyK3A3VDdENDZueTRMY0ozZEhKcmpRWWhO?= =?utf-8?B?Z21KMWJjTkJNNEJEMkg0ako5U2NrWFhnRWFwQlBxR2k4ZTNxdk0vNWEzVExk?= =?utf-8?B?cGw2aHR2M09pQ3l0Nk1md2lBL0NhVUJKZVZvY0c1LzNWRWJuTWFpdjhMZEl5?= =?utf-8?B?ZmlpS3dWdENXZDZBU0l3dmJSblozR1U2TDVjSUpSUkdZM1RaNklpRTZZWEFF?= =?utf-8?B?amxRMyt4UVBBZkI1d0ZqTkJPSDJIM1M2RUhFbmZTcTJpbTZkSjl2dGVmUWJS?= =?utf-8?B?ZG5hS3p0TUw0bnV6QkpkNGFQMGlsYUhWMjZTbXdJUnd5aGJnaHg1elBieU03?= =?utf-8?Q?4SuFNdY2iwdcSBUyIGabfm4=3D?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 00d8d77e-0e3f-4dc8-c062-08dadfa27a12 X-MS-Exchange-CrossTenant-AuthSource: SA2PR10MB4636.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Dec 2022 20:16:56.7571 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: pVoqZ2sVejnjwqusraZbpDEtnzsl/MHg07RsuU/pdohzMpuzkTVKtPCsUwtOBtFlqNt8hGVOcNpFerzE3197AcNbrc+GIv64oU1/+Xlk+p4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR10MB4642 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.923,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2022-12-16_14,2022-12-15_02,2022-06-22_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 malwarescore=0 phishscore=0 mlxlogscore=999 suspectscore=0 spamscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2212160179 X-Proofpoint-ORIG-GUID: vEnfH18LuxV01nCZm54k9MmfvCYLRLWB X-Proofpoint-GUID: vEnfH18LuxV01nCZm54k9MmfvCYLRLWB X-Spam-Status: No, score=-6.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 12/16/22 00:26, Jan Beulich wrote: > While the latter two patches are purely cosmetic, I wonder how things have > worked properly without the former two. I'm therefore not going to exclude that > the changes done really need to be conditional upon some environmental aspects, > but it's not clear to me what these would be (or why). > > Beyond / independent of these small fixes I'm still concerned by the time > running these testcases takes: The few tests here take quite a bit longer than > building _and_ testing all of the rest of binutils (not gdb of course) for > those targets where gprofng is actually available. One aspect I'm wondering > about in particular: What is it that is actually tested when the binutils build > is a cross one? Nothing. > The produced binaries are host executables, so it's unclear to > me what meaning it has to run on them a profiler (supposedly) targeting another > architecture. Eliminating the testing in such cases would already speed up the > mass testing of many targets in a noticable way. Agree. We need to ignore `make check` for the cross build. I'd rather test the installed binaries. Can we add the check-install  target in Makefile for this ? I use a big testsuite for gprofng. The testsuite has ~400 tests and takes ~4 hours. The problem is that tests are only available in Oracle. > There are still "warning: always_inline function might not be inlinable" > instances left with the gcc version I'm using, but I can't tell whether that's > a reason for worrying. > > 1: adjust linking of synprog > 2: correct names for signal handling tests > 3: correct line continuation in endcases.c > 4: eliminate bogus casts Your patches look good to me. Thank you for the gprofng improvement. -Vladimir