From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2068.outbound.protection.outlook.com [40.107.21.68]) by sourceware.org (Postfix) with ESMTPS id AE83F3857837 for ; Wed, 26 Oct 2022 08:57:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org AE83F3857837 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LVqLS1mxVzTD9SSbUQElXLFeTsMW0CsXnA4q3eiBwDY4TH407N5+YSN9+oGpKwVRCfZX4B8UMKyzIcHvrr6kiXmj8jNH5pT5l1sOfugqQm/b9NusystW7jJlq9pBw8sAV0NbeKz09zgXqDITFj4r50qQu1ruyZoVBp5b+K06t7VTz6XJR55M1oV6H8ndbAG9SZg8TefDakokjoOoDXXCt/iuAkNoPRNvzxbkAPRE+tsGvQt1yNow/uAfdTPcySBaOseLCfEZm2SsHqTZQIRkeJK0W/mi8CIrcEvakDToHMGXbDagRCwKqYzMe1Q2d46sIMX/ZoQWGs16rWcjYlO2Rw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NcAH2qDPiBkD+tVzi80lZRYljDAEp9f+zTbQU0VlOAU=; b=bCKPNya2SLx8kIk+7wDZYArhjQlyPkXO/FjT8AdMy+aAvvk/DW/1LganXbPzKKsZctYM6H1GkcvohYpX/+wzF91r/YR42/z9M2Rl548bVCNbpx0LbSKGnV6Tasbr3iGor+vzta0y4MvE1sO9MiuO7mzGX7wbSXoZJ3EB0A1CqpFbjNsbGSIUDJ4euA52kBzgLyq79rWEGfEQHKkmLm+TTPZUFpx9d4y32VXCGDrvL7De3xdCudZguOWUJfWezUczUcVo5uCZQ46eUq18rAKlcW8h+HAU9VLyR80TuK1yz55O9cb5LbdVNujMFTf5RUA/uFDCrqkco498n7uGtHGZDA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NcAH2qDPiBkD+tVzi80lZRYljDAEp9f+zTbQU0VlOAU=; b=pSuQtmsPoiaUu1owi6NkUSE9uyLl0t/DXLFaBV+kufeP6/nB+4D/+PGGE9pO4MLAY73thbBTe9oh8Hu1+dN//avxA3LVOtw0S8gNrZ8E5mLh77YM3NXDsxt1EsNEtZZLZ1NNYEEDhsVMEYl7ZUBgUOx3G67VRYL9LWwqUwoyrIaKWnPyVtnAoZnjLhvHTWpfyG1hT9CepEJPV2nFvy5TEtNolyoD7giGOSirgWMmmMZuQmRhphDvCJq5AW+hIyvjXDb1PlBd25TLL2YvcHTrjgG2BW9CHcRVn2kFVAcec9lvDq4/Id4k2AkCIwddMM54Iiy5wuxdOhHc81QBx5rF5A== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by VI1PR04MB6877.eurprd04.prod.outlook.com (2603:10a6:803:131::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.28; Wed, 26 Oct 2022 08:57:00 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5746.021; Wed, 26 Oct 2022 08:57:00 +0000 Message-ID: Date: Wed, 26 Oct 2022 10:56:57 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: Re: [PATCH 06/10] Support Intel RAO-INT Content-Language: en-US To: "Jiang, Haochen" Cc: "hjl.tools@gmail.com" , "binutils@sourceware.org" , "Kong, Lingling" References: <20221014091248.4920-1-haochen.jiang@intel.com> <20221014091248.4920-7-haochen.jiang@intel.com> <1e6a7d9c-4b14-821e-cc46-453adbe6f183@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0158.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a2::8) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|VI1PR04MB6877:EE_ X-MS-Office365-Filtering-Correlation-Id: 8cbd99c6-4bb7-481d-7b77-08dab7300b7f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ewrYF9+yzO6fmdB+F3zJsx771cG3owHFJguroUMrU5kiPpMbJXLUWz1mFX6mU9Q+T+rqLyKswYofeAZKnW1iHiKxU+mZxhA9RYryVyTFO1YQ2nhQG/3NAxEvkjx5l9R6tzR50nSIquwAg82pmB4CKIh5ihBHh5Szb1kBzwo/GfFJvVTlmEDn8EtRsQxYiH992eMutXU6Cj/4IXbXCddzlS9O7gP5HE19aWa0DcCYpjMcuwHytu3Ammz1CCvQcWRPxoUI2uRTBDAEwooXNoQHAiqnnDbb7lOeF7NRO7Qk3YIJbrmljSvtSEs/HkVJyKvZUCrA91MpS0EOCsik6S6DK1PNalHVTSG1MIxoC6XZbYP0bmGlGTxcv4btJs3c5TWoNcRcbl7EPRJxBGhkhJmgMZRlcd0rVVxRvf4znH9zZrh+cFr7uKyG/p7XlPDEkm1SVWjgrT/c+bOGu4JgVnHE/NO2kk9aIyVu3pSkOTRzZDddBq05iDt8o8woxTXgMIJyrPAMMdkrko6Vbuij5hzdp8XfsE0rXAS6c43tVvUwsXGDByhOxiyqLx2bvtubxNPqhRIv4RMIAFZw4fWiPSZuCn2mAk3vgiiKiPtYymlH9Ey6gmCogh7JYzWSU1KLuplqYGJaFeaBZeEAErdBjuf8hcdFsO+h53VC8OQFbSk7Robf4lreTkVk/16DsSCPNP6187mspv1RypFI088s5tasq8I2cq88IzVhl//64o2Q7UVL4PrjTDWh7vGbeRnFzO8XkzyZMyjm4YWIYqvVlCzh80CfIcuJ4hnCRK1gsvpGRC4= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(376002)(136003)(396003)(39860400002)(366004)(346002)(451199015)(478600001)(6512007)(26005)(53546011)(6666004)(6506007)(54906003)(6916009)(316002)(4326008)(2906002)(6486002)(66946007)(66556008)(66476007)(8676002)(36756003)(38100700002)(2616005)(86362001)(186003)(31696002)(83380400001)(41300700001)(66899015)(8936002)(31686004)(5660300002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UXNsaEEyTStMTjZlbUovR21kK3AvQlpIdkhmYzhZUktBcXVZZzN3c2hoUy9n?= =?utf-8?B?NXA0Z3Rod25KdjR5a0lKYlJRYXZ3dDVjSFE1RFp4R3JJbVE4ZGxvbVcvenpp?= =?utf-8?B?amgreE43Z01ERWlBYTNTM3F3M1pkYUl0Z2hJUjcvWCtHbFZmUVdwYlVzRDc0?= =?utf-8?B?bDQ1OFdIZTVlMGxHYVAwMUpEcnJLR2pJUHp0Sk9ZaGZDTC9BcHVKV3NkcTZ5?= =?utf-8?B?RHZaUzVqR3d4aGVhMHNXS1dHYlNJWnBMZkZGTHN0cVJhNTVRa1NXQlRrY25E?= =?utf-8?B?TTkzMlNza0EzZnUwSURRaW5sTHZIRUlYWGphb2c5UHlPRWVOMG5jU3VTenZn?= =?utf-8?B?UDFtU2tEUk5QczZtNk05Z2ZYQXd4UHZlVTlxTDU3Y1daTXJtbVFocUtGWGF5?= =?utf-8?B?VTBpV01OTWZ4endjQnA2T1lmM0d3ZWVmWHNuOXNQdThvRndFd3J6ZWhSQnR1?= =?utf-8?B?Y283eGpFWTRFb1JEaGIwbTBGaUFQSWEyd3d6TXpkbGtCemdTZW5CVkcxalVn?= =?utf-8?B?ZEFRa1lHVHRZR0M2bzRsNjU1Ly8wNTlNZHM2SXNXK0E2a29RYW1oZTM3WE5Z?= =?utf-8?B?THZmNHQ1RFRXOHlHNytPenYyYjZCME9nS1U5R1RGYmlKQ3BJMFM5VDNIT0ps?= =?utf-8?B?Z0x4WndXU3dWdExtUVZxQ1NtYjY5NUkrQkFEMkpSblVEQXdtaVgrRTVLSysw?= =?utf-8?B?ZmFocmJBMENuYzZqT216T1AxeTJEeVdGRDNmSjVXSXdpYlp5blFNNll1Q09y?= =?utf-8?B?UXAwRGRkL3o4ZEFtQUhIeGp6bVlvMTI5QVpkSkpFYXVER1hqVllOcnd5WXlC?= =?utf-8?B?ZFh3MUNlNktrbzJLWWVMN0I2VXMvNXI0QXJWNXVLL2tzeHNFbGtwelJhVm00?= =?utf-8?B?VkJ4ZHRTcllHTVpFME9RMXRNTnlYZDVGZEd0WU1iaTlFbW1yNko5bGFYNll4?= =?utf-8?B?OHpOa2VLcGNDV21NM1d6dkd2TmVlWlV2R2Zjd3BiSng1UjUyak4relEzU0VQ?= =?utf-8?B?YTZSeDB4VFR3U0lEL0hoWkdNZnBVd2xaYjBsbXZET09pMmRVUzZnSTJqcE1w?= =?utf-8?B?a1lxTFQyV0pnbTEyQXdYM0d1M3FKSHVQc3l5YU1zRGxFdUhjRzNCYm1OVUk4?= =?utf-8?B?YnRuaVJNU3RLMkFQVHVYR1kwWkUrQjFWUUgrenBFUnhoUWxmUzhXQXlwOXVE?= =?utf-8?B?UHA4TlNaS09zVkk2bnM3OTdUVGZnNDBkV08yMS9Qa3VEa3dzWXVMMzJhOXdh?= =?utf-8?B?UzNoMWpsM29vekR0NXdIRENlWVB1WHhZanpvcENwWkpRK3JNRjljZTkwRW0v?= =?utf-8?B?QmtldjRhejk2cVJWVThIOG5TVUkyQmtoSVErT3c1YzFGenJaeHlMRmVTU2hv?= =?utf-8?B?YU93UG91Qmh2S0t5NlJaa2JhOCtZY1Vyb1pPM3lDclFEVTJjTlN6cmRnc2Yr?= =?utf-8?B?VGFlT0xxS2ZJN0lTUTE5WXI1N2szNXVhSVBuUTM4TjZvR3ppa2VPN3lHb1N3?= =?utf-8?B?aWpUNVhzL2sxTkZLT0dMdWN2QVpncUZ2c0o0SGJhZUEwVEd4elJ6Ym9Wek8x?= =?utf-8?B?VXhrUjY2Z2prTFhla1lkWmZwRHJLR3dxL243OFN5dDBQNkZsQWhUeGhUSmpj?= =?utf-8?B?Rk51aEs0dk9XQXJMSUxHVWgzMWlWR0Q5bHd6Sm9RdjdSQlZlbkd1d2E4WUFv?= =?utf-8?B?RERFRUlEaVd1UzZnUXVtVUhlanJVYTRGUVh4LzZEMWozamZIWUxjcnAwOFdE?= =?utf-8?B?SERqYzlXVXUzZy9MT1djTDIyZktIQ1dJbGszeEsrZ0ozZHpaVERUTjdLUU83?= =?utf-8?B?NmNaT1dMZGIzWjVGdnB4aHlNN3lETUJ5TDE0MzhXcUZVWjdNN09MdDZwZEth?= =?utf-8?B?MHVmTW05R054dlJmNldKZ0tnb01SWExSSDB5UjZIODhQVlZEZktBcEl5REJE?= =?utf-8?B?bTZuRDBXQU8ybW1xYTdnVXg4ckVTVTNtbG1uL2UvOHYxbkU4Znd1WG1rdXFl?= =?utf-8?B?NmVOUG8zVHdnZ1NBeHBmSXZtcExaaGVibGs0Z3M4cldqYWZyYTd6eENlOEl6?= =?utf-8?B?aTZqWUxNVEVHQ3lkQTN1NFlXQWVVL2d1YmM2YkpPOGVXWWxleWl2TE10Q0Nr?= =?utf-8?Q?LQFhhpdpkobY6pNCWgs+O4e2x?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8cbd99c6-4bb7-481d-7b77-08dab7300b7f X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Oct 2022 08:57:00.6657 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: XV/z6F8eJYR76PTW+HTDjtdv2HjxWoGHsRYxIdhskVfl5kZYxaFrDiKCtWF7bi6f1nQqgN1Kp8Sr1NPwjKeXuA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6877 X-Spam-Status: No, score=-3029.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 26.10.2022 07:16, Jiang, Haochen wrote: >> -----Original Message----- >> From: Jan Beulich >> Sent: Tuesday, October 25, 2022 3:01 PM >> >> On 24.10.2022 07:56, Jiang, Haochen wrote: >>>> -----Original Message----- >>>> From: Jan Beulich >>>> Sent: Friday, October 14, 2022 10:38 PM >>>> >>>> On 14.10.2022 11:12, Haochen Jiang wrote: >>>>> +aadd, 0xf38fc, None, CpuRAOINT, >>>>> >> +Modrm|IgnoreSize|No_bSuf|No_wSuf|No_sSuf|No_ldSuf,{ Reg32|Reg64, >>>>> +Dword|Qword|Unspecified|BaseIndex} >>>>> +aand, 0x660f38fc, None, CpuRAOINT, >>>>> >> +Modrm|IgnoreSize|No_bSuf|No_wSuf|No_sSuf|No_ldSuf,{ Reg32|Reg64, >>>>> +Dword|Qword|Unspecified|BaseIndex} >>>>> +aor, 0xf20f38fc, None, CpuRAOINT, >>>>> >> +Modrm|IgnoreSize|No_bSuf|No_wSuf|No_sSuf|No_ldSuf,{ Reg32|Reg64, >>>>> +Dword|Qword|Unspecified|BaseIndex} >>>>> +axor, 0xf30f38fc, None, CpuRAOINT, >>>>> >> +Modrm|IgnoreSize|No_bSuf|No_wSuf|No_sSuf|No_ldSuf,{ Reg32|Reg64, >>>>> +Dword|Qword|Unspecified|BaseIndex} >>>> >>>> Why IgnoreSize? Instead I think you need CheckRegSize (assuming it does >>>> enough for Intel syntax memory operands - please double check; if not >> this will >>>> need fixing). >>>> >>> >>> For table, we aligned with CMPccXADD and added No_lSuf and No_qSuf >> since >>> the suffixes are not required. >> >> Which, as said, I consider wrong both here and there. > > I still agree with H.J.. Also I suppose the previous usage of suffixes are quite > messy and we should not stick on the confusing code. > > Keeping consistent with SPEC from now on to avoid confusion on that might > be a better solution for future. Same question to you then: Which spec? As said in reply to H.J., the only spec I'm aware of suggests prefixes ought to be used _whenever_ there's a sized memory operand [1]. If we want to deal with the present "mess", I think we ought to simply allow suffixes consistently. Please point out any other messy aspects beyond that. Jan [1] They further say "long" is implied when there's no suffix, which imo gas validly doesn't follow in cases where a further register operand indicates otherwise.