public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
* [PATCH 3/4]: m32c: remove duplicate define and prototype
@ 2020-04-07 10:02 Gunther Nikl
  2020-04-08 10:16 ` Nick Clifton
  0 siblings, 1 reply; 3+ messages in thread
From: Gunther Nikl @ 2020-04-07 10:02 UTC (permalink / raw)
  To: binutils

The m32c target header has a duplicate entry for MD_PCREL_FROM_SECTION.
The duplication was present since the initial commit of the port.


2020-XX-XX  Gunther Nikl  <gnikl@justmail.de>

	* config/tc-m32c.h (MD_PCREL_FROM_SECTION): Delete duplicate define.
	(md_pcrel_from_section): Remove duplicate prototype.

diff --git a/gas/config/tc-m32c.h b/gas/config/tc-m32c.h
index aa38116246..5be71977d6 100644
--- a/gas/config/tc-m32c.h
+++ b/gas/config/tc-m32c.h
@@ -32,10 +32,6 @@
 #define md_start_line_hook m32c_start_line_hook
 extern void m32c_start_line_hook (void);
 
-/* call md_pcrel_from_section, not md_pcrel_from */
-long md_pcrel_from_section (struct fix *, segT);
-#define MD_PCREL_FROM_SECTION(FIXP, SEC) md_pcrel_from_section (FIXP, SEC)
-
 /* Permit temporary numeric labels.  */
 #define LOCAL_LABELS_FB 1
 

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH 3/4]: m32c: remove duplicate define and prototype
  2020-04-07 10:02 [PATCH 3/4]: m32c: remove duplicate define and prototype Gunther Nikl
@ 2020-04-08 10:16 ` Nick Clifton
  0 siblings, 0 replies; 3+ messages in thread
From: Nick Clifton @ 2020-04-08 10:16 UTC (permalink / raw)
  To: Gunther Nikl, binutils

Hi Gunther,

> 2020-XX-XX  Gunther Nikl  <gnikl@justmail.de>
> 
> 	* config/tc-m32c.h (MD_PCREL_FROM_SECTION): Delete duplicate define.
> 	(md_pcrel_from_section): Remove duplicate prototype.

Approved and applied.

Cheers
  Nick


^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH 3/4]: m32c: remove duplicate define and prototype
  2020-04-07 10:01 [PATCH 0/4]: gas: cleanup for MD_PCREL_FROM_SECTION Gunther Nikl
@ 2020-04-07 11:13 ` Gunther Nikl
  0 siblings, 0 replies; 3+ messages in thread
From: Gunther Nikl @ 2020-04-07 11:13 UTC (permalink / raw)
  To: binutils

[resent with correct reference]

The m32c target header has a duplicate entry for MD_PCREL_FROM_SECTION.
The duplication was present since the initial commit of the port.


2020-XX-XX  Gunther Nikl  <gnikl@justmail.de>

	* config/tc-m32c.h (MD_PCREL_FROM_SECTION): Delete duplicate define.
	(md_pcrel_from_section): Remove duplicate prototype.

diff --git a/gas/config/tc-m32c.h b/gas/config/tc-m32c.h
index aa38116246..5be71977d6 100644
--- a/gas/config/tc-m32c.h
+++ b/gas/config/tc-m32c.h
@@ -32,10 +32,6 @@
 #define md_start_line_hook m32c_start_line_hook
 extern void m32c_start_line_hook (void);
 
-/* call md_pcrel_from_section, not md_pcrel_from */
-long md_pcrel_from_section (struct fix *, segT);
-#define MD_PCREL_FROM_SECTION(FIXP, SEC) md_pcrel_from_section (FIXP, SEC)
-
 /* Permit temporary numeric labels.  */
 #define LOCAL_LABELS_FB 1
 

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-04-08 10:16 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-07 10:02 [PATCH 3/4]: m32c: remove duplicate define and prototype Gunther Nikl
2020-04-08 10:16 ` Nick Clifton
  -- strict thread matches above, loose matches on Subject: below --
2020-04-07 10:01 [PATCH 0/4]: gas: cleanup for MD_PCREL_FROM_SECTION Gunther Nikl
2020-04-07 11:13 ` [PATCH 3/4]: m32c: remove duplicate define and prototype Gunther Nikl

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).