From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mailbox.box.xen0n.name (mail.xen0n.name [115.28.160.31]) by sourceware.org (Postfix) with ESMTPS id 7999A3858C98 for ; Tue, 5 Mar 2024 18:43:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7999A3858C98 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=xen0n.name Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=xen0n.name ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 7999A3858C98 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=115.28.160.31 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1709664230; cv=none; b=X1Usmz+PQ7jghWWOLtHOLbJqIjsns2Sqe5bJl1sVKA9nZpLC6zPdbsitHCA/gatChAGb6zubStFUYobD/CzmG+oNMKUBTDVnWgOvGKN8PUkr0lMh+yiN3//3sLQ8MBW0Uz4kcSonySMZH9gZa0I6hExFfxDqQMLt//sacJq9Pjg= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1709664230; c=relaxed/simple; bh=woqrxdQytmv2Y8iayXkq3+1NK2tSuOhhvZKAO1F2sUM=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=MCuh0iI2Fydi1GJYlcUi95AE9peBLUdhgPcLhYThyVnVk8rgG6rJBrxOTjCEWHD+pgv5nsvYjSRO+xQPgKXUWE6i7jsTv6Qb87IpkaM+LMQPRdGOnqTwwTcP6aA3472FGLr5lBQKaB/PZBLTqkH2ClnwL3ta+5gz53BMa+5mnnk= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=xen0n.name; s=mail; t=1709664225; bh=woqrxdQytmv2Y8iayXkq3+1NK2tSuOhhvZKAO1F2sUM=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=n0G63CmcwxZpMnjWiCST6L9rItUDMHH/6kN2MFIAtlc4Ieyr/jOhCPlz1dh3rxDVm Kl0oBmUqi7qrUdaF0gxhewSK17G1Jr9FWbZGEOXMJxmtjoI/1OINckK3r06Q2FIj3d OERvMjIZgTW4iGsKTnqaR/7HVaNLUVgVZDqHHSeU= Received: from [IPV6:240e:388:8d00:6500:3d21:65e4:41f4:2696] (unknown [IPv6:240e:388:8d00:6500:3d21:65e4:41f4:2696]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by mailbox.box.xen0n.name (Postfix) with ESMTPSA id B5AD160111; Wed, 6 Mar 2024 02:43:44 +0800 (CST) Message-ID: Date: Wed, 6 Mar 2024 02:43:44 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1] LoongArch: Scan all illegal operand instructions without interruption Content-Language: en-US To: Lulu Cai , binutils@sourceware.org Cc: xuchenghua@loongson.cn, chenglulu@loongson.cn, liuzhensong@loongson.cn, mengqinggang@loongson.cn, xry111@xry111.site, i.swmail@xen0n.name, maskray@google.com, luweining@loongson.cn, wanglei@loongson.cn, hejinyang@loongson.cn References: <20240305113554.3393481-1-cailulu@loongson.cn> From: WANG Xuerui In-Reply-To: <20240305113554.3393481-1-cailulu@loongson.cn> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 3/5/24 19:35, Lulu Cai wrote: > Currently, gas will exit immediately and report an error when > it sees illegal operands, and will not process the remaining > instructions. Replace as_fatal with as_bad to check for all > illegal operands. > > Add test cases for illegal operands of some instructions. > --- > gas/config/tc-loongarch.c | 11 +- > .../gas/loongarch/check_bstrins-pick.d | 18 +++ > .../gas/loongarch/check_bstrins-pick.s | 9 ++ > gas/testsuite/gas/loongarch/illegal-oprand.l | 113 +++++++++++++++++ > gas/testsuite/gas/loongarch/illegal-oprand.s | 117 ++++++++++++++++++ The filename contains a typo: "operand" instead of "oprand". > gas/testsuite/gas/loongarch/loongarch.exp | 4 + > gas/testsuite/gas/loongarch/lvz-lbt.d | 2 +- > gas/testsuite/gas/loongarch/lvz-lbt.s | 2 +- > 8 files changed, 269 insertions(+), 7 deletions(-) > create mode 100644 gas/testsuite/gas/loongarch/check_bstrins-pick.d > create mode 100644 gas/testsuite/gas/loongarch/check_bstrins-pick.s > create mode 100644 gas/testsuite/gas/loongarch/illegal-oprand.l > create mode 100644 gas/testsuite/gas/loongarch/illegal-oprand.s Other than that, the code changes LGTM, thanks!