From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-x42d.google.com (mail-wr1-x42d.google.com [IPv6:2a00:1450:4864:20::42d]) by sourceware.org (Postfix) with ESMTPS id 22BF93858CDA for ; Mon, 10 Jul 2023 23:30:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 22BF93858CDA Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=harmstone.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wr1-x42d.google.com with SMTP id ffacd0b85a97d-3094910b150so5570958f8f.0 for ; Mon, 10 Jul 2023 16:30:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1689031824; x=1691623824; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=qAtHFaeFo0tw00Q1us+a4MxJgNmNtAagkST0xwqeCcQ=; b=rJTS5pmZHSXOgcqTWl+7vRcuF6mgIjok+r851VkK4bjA+FYZXKZ7/vGIoZUYkpzfsA NIPJXVwTpUa9GcPaQL/WeNCANbpN9ZGPglte0ZLuE5aSrOIWenHa463WbgGG2/pivXDV yLGvXqZHL4s7ABLPOT0zmuVAB5i19X9QIFe4RkVCvIXDUhcmeUZBZRqQH72/kQheGUDp 2BYZQueb+i00hJDBT69vcfEBWgjzZQdQCeNsx+zGpp7SEZbe+flp/Ls8zOxwGTM7B8oJ tnLN8wl/vmNY5q7D14VeV8WJXdUP+FhJls4o1xxoR9H5JmbR9OQ11Mayfu9imThXtd6+ SCaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689031824; x=1691623824; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=qAtHFaeFo0tw00Q1us+a4MxJgNmNtAagkST0xwqeCcQ=; b=IYPqSZkxJ++8KS42ysqDe2XUqoFrZfnWP8PhyA+kghm6iTUS+G3UXzyjbeOLhNmNQo oKrEYRprmlGShGKO34f35o7MSVm82wznCguWYKfB1MJZI6DXfmBPz2uWwKd/O2rI18QU q+FZnO6ZWP/oI+MLYKYU1N5c0Wu+uWmOwYjuE8+rlcyAccLWz/KgykyoAk+xJzJCH3lH oR5swA+G4PKxMB06rHSHoSBYPuTEnxtVGTtSog49CoKPGefcohYZx4TUJntxMNLysOuv Tl2eNcdViEWAyCGAly0IBAA5df7WtrlKCv8m1x2c6a5BQbVND94ZJ//n+S7uosFVqHy5 Wpaw== X-Gm-Message-State: ABy/qLbO1TLLpB/VwGOiqdXbziqXZ+xQndfBJMHV1iQbTMB4mhKR3+F+ xxilICMGubNVnFAbZcsoa7g= X-Google-Smtp-Source: APBJJlGtg4QNfYaSoKfQHlsteVtgznPYUfbchcXW9qG8d8wy0KIHrJaurhDe5dhnIWHQIR2G/emNnQ== X-Received: by 2002:a5d:4ac1:0:b0:314:1313:c3d6 with SMTP id y1-20020a5d4ac1000000b003141313c3d6mr5869765wrs.33.1689031823628; Mon, 10 Jul 2023 16:30:23 -0700 (PDT) Received: from ?IPV6:2a02:8010:64ea:0:8eb8:7eff:fe53:9d5f? ([2a02:8010:64ea:0:8eb8:7eff:fe53:9d5f]) by smtp.googlemail.com with ESMTPSA id y17-20020adfee11000000b0031274a184d5sm603193wrn.109.2023.07.10.16.30.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 10 Jul 2023 16:30:23 -0700 (PDT) Sender: Mark Harmstone Message-ID: Date: Tue, 11 Jul 2023 00:30:13 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH] ld/PDB: fix off-by-1 in add_globals_ref() To: Jan Beulich , Binutils Cc: Nick Clifton References: <88c2fb96-185d-ae27-c025-ed025ed54641@suse.com> Content-Language: en-US From: Mark Harmstone In-Reply-To: <88c2fb96-185d-ae27-c025-ed025ed54641@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Thanks Jan - this looks good to me. Mark On 7/7/23 14:47, Jan Beulich wrote: > Copying one too many bytes can corrupt memory, detected and reported by > glibc on a 32-bit distro. > --- > Nick, again I expect this wants to go on the branch as well. I'm sorry > that I didn't get to look into this earlier; I had noticed it a while > ago already. In any event I'd like to give Mark a little bit of time > to reply (if necessary), before putting it in. > > --- a/ld/pdb.c > +++ b/ld/pdb.c > @@ -880,7 +880,7 @@ add_globals_ref (struct globals *glob, b > g->offset = bfd_tell (sym_rec_stream); > g->hash = hash; > g->refcount = 1; > - memcpy (g->data, data, len + 1); > + memcpy (g->data, data, len); > > glob->num_entries++; >