From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=HE0G=MU=arm.com=Richard.Earnshaw@sourceware.org>
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
	by sourceware.org (Postfix) with ESMTP id 7F3E53858C56
	for <binutils@sourceware.org>; Fri, 17 May 2024 14:31:14 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7F3E53858C56
Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com
ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 7F3E53858C56
Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=217.140.110.172
ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1715956276; cv=none;
	b=kFFTnZI2kM9n6q1f4CQbUiEF5REZA+nDLXtXqfakSVgO30Do7Au4WXHeqoik1koDVeg94ymdE8pDUD0WieqZhHS0BVTNv+DUcbLgJrs/cHdHara36iYylegJUraOHtP898VgN47ieCPojgMyVDnqIQWydp/DX1TYfqLJf1PMEKo=
ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key;
	t=1715956276; c=relaxed/simple;
	bh=3mxbbcLBXYYMwMaiRwUBP2nKUJvMEwkK7Mq1iJeJ0ls=;
	h=Message-ID:Date:MIME-Version:Subject:To:From; b=daRkfx7eD6q5Jj/t56lLCGoIRxQAi+8drrHW+rQXrO1HrhMnBrDCmNlOARFXqjleqypO0ojPO54vDW0iP1/nu205Zi7JtJzYwZvg+sz4p6YvDVXDfNdp6+N75nfXcv2zOsNsJ2axIiSXWM5ZeGvdLNKyxf5YDGfzCOV6gsL/1XI=
ARC-Authentication-Results: i=1; server2.sourceware.org
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
	by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 112CF1424;
	Fri, 17 May 2024 07:31:38 -0700 (PDT)
Received: from [10.2.78.57] (e120077-lin.cambridge.arm.com [10.2.78.57])
	by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 917C23F762;
	Fri, 17 May 2024 07:31:13 -0700 (PDT)
Message-ID: <e99ae61b-84f4-4379-8014-55e5785e51c7@arm.com>
Date: Fri, 17 May 2024 15:31:12 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] arm: Fix MVE vmla encoding
To: Claudio Bantaloukas <claudio.bantaloukas@arm.com>, binutils@sourceware.org
Cc: nd@arm.com
References: <20240415100020.497574-1-claudio.bantaloukas@arm.com>
From: "Richard Earnshaw (lists)" <Richard.Earnshaw@arm.com>
Content-Language: en-GB
In-Reply-To: <20240415100020.497574-1-claudio.bantaloukas@arm.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-Spam-Status: No, score=-3491.3 required=5.0 tests=BAYES_00,KAM_DMARC_NONE,KAM_DMARC_STATUS,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <binutils.sourceware.org>

On 15/04/2024 11:00, Claudio Bantaloukas wrote:
> 
> Bit 12 of the first halfword in the VMLA instruction is listed as (0)
> in the ARMARM (document DDI0553B.w, version ID07072023).
> This means that the instruction does not discriminate between signed
> and unsigned types and processing elements do not use the bit.
> The encoding used by gas was based on an older version
> of the document that made the sign important.
> This change makes it possible to use vmla.i8 (16,32) in addition to
> vmla.u8 and vmla.s8 mnemonics, with the i8, i16 and i32 aliases becoming
> the default when disassembling.
> The generated encoding sets bit 12 to 0, compatibly with other
> assembler implementations.
> ---
> Hi,
> 
> Is this Ok for master? I do not have commit rights, if OK, can someone commit on my behalf please?
> Tested on arm-none-eabi.
> 
> Thanks,
> Claudio Bantaloukas
> 
>  gas/config/tc-arm.c              |    4 +-
>  gas/testsuite/gas/arm/mve-vmla.d | 3383 ++++++++++++++++++------------
>  gas/testsuite/gas/arm/mve-vmla.s |    8 +-
>  opcodes/arm-dis.c                |    2 +-
>  4 files changed, 2041 insertions(+), 1356 deletions(-)
> 

I think this patch is incomplete.  The current armv8-m Arm ARM also shows that VMLAS was also changed in a similar manner.  Were any other instructions affected?

R.