From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2069.outbound.protection.outlook.com [40.107.22.69]) by sourceware.org (Postfix) with ESMTPS id 68AB03858D37 for ; Fri, 28 Apr 2023 06:10:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 68AB03858D37 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ym+zEaVh0AK4KCI4lvBpenHx9/jjoo2rgGbMcB3mrmbtX1kC30d3G7IKFbm83RZiGnOHIg0beXf/caZ4Qo5ADTvUhL4CecD09pWOafJNuZZm01umoc8h4uIIvbRhq9aKFs5N6Bsdj/8W4nUSE14yTIAPs28UjhuqgH3nlsyp724LJpDseIz+GPyRu0X3rPZNa4C87676K/Ap4qT31FgTlISqU7DEMs2MWj7VYH0f+G7mtU4SnIET7s6Cue244XLzhycJwCPoZoYy4vsPeZhlW+X4MlmAAcaeuF++6uSmJpnY77NgrgpCUh/7cvq6fBMYjvVhlXICtgKYlHQ+uCFwUw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=k/XsJmBUEYG9YQ3RtmKmJBwPu+s8BlaRqhVr5gQm2DM=; b=dt52Ds65ebIlCOZNNPc+gYUdnMaudOcfyHswXDbstSMC+IVzvw57K3ribDHxZ+XU7HGLthIo9Lx2ejBzYLk4+HfE6hsg/mYTjVbgNhnb3FNWtlyFRA+Ms+VvJkLs1+uAcXuoGMkNIM3LFdYWusCXk1hg+F5For9dix9evsMWgTg6qc63Q7mzYsZ5Kq9q99f+rrlQK2wdRViWuwmZ6dizkJYJxrigIDO8VerFrQu9VyCDN/yalbTWBmRsWe9c9XRmzXgRFw1/WW8utSZGjPDlkgyXOLJ2lgCtGuf2cTlDdMjOiUoI8CAVgb0frjtHX5XrpBOCRDB1QGz0QCvRUAJA6w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=k/XsJmBUEYG9YQ3RtmKmJBwPu+s8BlaRqhVr5gQm2DM=; b=In0iODNDi3jEI+xcWihd1oWp/KStWPM85tyhv9VQdNSDabYIQlsFM5MsgvRZWMYYoAgu8KcTwNeFDenkiQUpgOxIWgsb+bB9Ymlp6QBPkssq+mmISsRdhn9q6rw9NTZo+0A+R+SO3bldOIBIrMkXONXvgjrojCGJhrz/ZL0n8oxM3kRpJrM40LU9VUS5LK2ySk5Jw+Jtr4ct1RDTLSbMnzdWvy+Fy5yh+0v8A7qx02FS7Lqaoa+buGpDZ/ZN01QfkRbrdEqDrdzX8bkgjNO8268PSxELLTMCHVGeWIdIvHIK8bgZuP3iWFLOCW1YRUCc6G9KPaxqINoTYscnXpyM4g== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DBAPR04MB7350.eurprd04.prod.outlook.com (2603:10a6:10:1a9::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.24; Fri, 28 Apr 2023 06:10:25 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::52b2:f58:e19:56ae]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::52b2:f58:e19:56ae%2]) with mapi id 15.20.6340.023; Fri, 28 Apr 2023 06:10:25 +0000 Message-ID: Date: Fri, 28 Apr 2023 08:10:24 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [COMMITTED 2/3] gas: BPF pseudo-c syntax tests Content-Language: en-US To: "Jose E. Marchesi" Cc: binutils@sourceware.org References: <20230426173123.24564-1-jose.marchesi@oracle.com> <20230426173123.24564-2-jose.marchesi@oracle.com> <3ce08588-8065-473a-2ff8-d2c412406cbb@suse.com> <87354labni.fsf@oracle.com> <87o7n95hcr.fsf@oracle.com> From: Jan Beulich In-Reply-To: <87o7n95hcr.fsf@oracle.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0246.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:af::11) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DBAPR04MB7350:EE_ X-MS-Office365-Filtering-Correlation-Id: e646316f-5247-4c0e-7313-08db47af4210 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: cjj+s5pN6CPFd8ZeN1GRJWjqzNTo2bABDZdzS1u6wWrLaK/jzC7XZOhWfqkWAT/uF6OnqKZ1DtVcUdya+2Qj2r1qyZBVkfYwI0as+SyoC1wPQfEmbuqPPLAn1CZZCR8vBMP7Nn6RggrjsvYEqnyLYG+2rB7Ax9SRpwabCU9MpMPX90LPVUib2nfxxHaXgWAHENDKiu1rbCFBKfiqygfFUQoauI2vKqbAFELjsG0a2p2nIdOl6q6T3TWTK9KPph0sceAlbUUSlawLlSrJwQ+doCHWaN0TdtBXflbta+dgWMpQEdHMDDeVVTHMgOm1WBefTuOZT68/AFPKQcnIqf3wAi2NwpU1PTuiN8xf4rijm46Vbp+mArK6D6Q7W77SswomMBhHNEm1DyZHFP1cl2TWKyZ/e4soWqhz5jbYv9IO19fFY+IJjkehGJ8NAZUEeafvCMAEhFt+CotHDTZ2FviUT9RE8fOzi8nw2tMaEvIcqgLRDnemSUPFor9gKw3McrkqIvj+2FCourArJjGF6J0yld4gY/L6OPMYG4kSQl1k8g66PrZgq3Jg2uwkEFgcpiV1IeLOosfQYddn0ho1RNBjwf2z4gCiA4BSwC1D4cRswjWkwJEQHwIwVNFV8wyo+NxnFr622Z9Ud4MD/O35ikrPxw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(396003)(366004)(136003)(346002)(39850400004)(376002)(451199021)(8936002)(8676002)(5660300002)(66476007)(66556008)(66946007)(316002)(4326008)(38100700002)(41300700001)(31686004)(2616005)(2906002)(6916009)(478600001)(86362001)(53546011)(6512007)(31696002)(26005)(186003)(6506007)(36756003)(6486002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SEtUR3JPdGNISkVSSUV2dGMxQ3pJWVdqU3k1UUk0WDc5TitzaXpTc050Nkto?= =?utf-8?B?SXBjK3NnYjZXZm1tRndpTXY4WlZueC9qZFlOQkRTT1BmMDR6eEtuUVNGcHFI?= =?utf-8?B?TStHNmxsdDVhYThqUGxUZE81aFVaMDljRmdxRzJ0dzh0VU9MZTNFeGE4ZWRU?= =?utf-8?B?cEZqdEc4Nk9OTzNmazBobXB3V0dzTmlrSXpmd3Z3emp6RlhYUEVUd3lZYXpz?= =?utf-8?B?SGNCTTkrOWRHZENoYnV1Z05qR256RWRtYW5xT1lUZGM5VStoQkZzQ2NmN0p0?= =?utf-8?B?UzNpbmRoZUs3SEhINE1kTEJQdXp4K2Z2L1hmdW1PL1hWQytGcm0rR1VGdEtU?= =?utf-8?B?VXVnU0I0YmVhY293L2g2ZURDTzVMc093QWZBZnZLbWxTbUVLQ2pIY2xJOWt1?= =?utf-8?B?Sy9IdnE0ellPN0J0ajJqakxVUjY0NFVaYzFQNXlRQzY5YWo1VTdTaTRhdzJK?= =?utf-8?B?TFU3NGVYaWlhQmp0Sm90RHJPdUVjTXV4MEVNNFBnUlBjZDNvQlBHY2ZoeVFH?= =?utf-8?B?b2FvU2o1alZIVFdvY3Vubmh1c0hRMmVqRHczNG9nWjhLRUJxSGNrOVhvRk5y?= =?utf-8?B?YXVrejFlRGViU0wyc3diNmpSTFAyOWdCdUpVVlBENnBoSE1OaDg0TkpkRHh4?= =?utf-8?B?cnNlSGQ0UHNOVjlPSEl5RGJZVzBHRmhOODljU09HUmF5MGtrUW9xelczTW44?= =?utf-8?B?THdpM3NVblRadkxmL1R4VjlBMnNFYUYzeVJha0VWYVZiZlcrWlVPMVV2YWhQ?= =?utf-8?B?VnpGdENFaEZITGpLZXB3bjVWRHpuZ05jMkhIYTNnQWVPdEduQW1RM3BMcXdP?= =?utf-8?B?WVNCM0dlYlB3T1F2eDJVZjJLeDRlWlQrM1l5dTUzL3lIUUNFcGhQSWhpckh5?= =?utf-8?B?OVZUeXBvcExHbTVSK1lrVVFRVk5mMzhDUWdGTTJWOExCM3hqVmV1Qm5sa1JG?= =?utf-8?B?bk9xN1QzeFVSbEZRdXZmUjMrOGZqQ3pJbDhhTWtoQ1dLSzE4NGpOdiswRHRm?= =?utf-8?B?MC9Qd2NZNGRHZWxOTmMxdjY0QVExYnpoS0Jka051aFZWNlY2QXlOVExJSU0x?= =?utf-8?B?WUY3ek9pRWlLL3ZoMXZleFZMWWVoejdhSVc5QXhWSllVRXlVTWFacDU0UEE2?= =?utf-8?B?YVNIdjk1eTloYWNuc1BLd0J4MEJqSUNUR2VFNUNXMG01M0N1QUV1V050Y2dL?= =?utf-8?B?TzVqKzR2U21JZDRoZS9hNjNvWVloSmRNekVkcy9xQ3Y5cHIvcEVVajVaNVhq?= =?utf-8?B?Wm1TMG1MY2YrLzE5MU9jSWRpOXZIOWhnU0gwN0wyMU94RjlNSCtCUGxGTW9s?= =?utf-8?B?c0RtbkJYVGREcU1uN2s5Z1kycmxLNjdPVmF3N2dkNTE4QjhMUFN3Mm9wdGRa?= =?utf-8?B?a3BDM29jZEd3M2R1bHZsU2VJL1c3Kyt2UXI4K3MxbEU4d1VyV0xMVGNzQnBN?= =?utf-8?B?RDhpaGR2ak9qT3lxMUdUS0lTRGxXK21TZGp4ZFdoU2Y5VUZwOGFTdGtEWU1B?= =?utf-8?B?cENpVmJLRTFXZDU2UEJ6MFNFUGxSaHB0L3d2TWl4Z0pzQXdFT0Z0KzlJTHp2?= =?utf-8?B?SHpzZCthdmVHd3NCSHlpeS9obGtPcWNrV3NSNzZ0emVSamhJMHU0UmJyVE8v?= =?utf-8?B?SkVqTjc5Z0tYL3BBUmI0VHI3VW1oNU1ycVZvSnArREZpRm80ODRBSkREc2Zi?= =?utf-8?B?TWZycGg3VVNWT1dmdWFiOHN1SE0waDBTRVEzUDJLQlR5enEzUXI2RjgyNWR0?= =?utf-8?B?YUo0UnZSaUp0djdCbWU4dmxRMUs2b29vUFI1aXJ0STBreGxKN3pMMVNzWFU4?= =?utf-8?B?VTNEUk9FWjFLb1B6Mjd6TDN4TS9VNHgzQSs2VC9lQmNrTlRIaG0zMmN3dU1Z?= =?utf-8?B?QldmRC9ZM3pSRHY1UlhRZGQ2bE1PNUsyNUFTbTRmQit2MjhtczVEY3pRUlFr?= =?utf-8?B?RnNtTmMxaXNxbXdGbTV0eG9HN2s0N1h0eWRhakpaY3BjNFFWVElFUXRqT3Yr?= =?utf-8?B?WDNYYTJkZlpIK20rRmJ5NlVnejloM2NveCs1SzZheWF6SWVia2ViTDdIVzAy?= =?utf-8?B?eTN5SXdNOHZZMms2SGJJaEtUYnRzTHBuZzk2aGhmbmIzNEw3ais3T1VwRmdB?= =?utf-8?Q?KSAnxefDcVc/TSNt0YxhGqwu5?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: e646316f-5247-4c0e-7313-08db47af4210 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Apr 2023 06:10:25.8066 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: qOP23iNQ8Fn0TeOYmGRQsBHE8W4G7N3Q2Eb0eK5BQ2Vm63bTQzKr1BuY7I+x/159uKORjuRhgUJHGe+nLRepTg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR04MB7350 X-Spam-Status: No, score=-3028.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 27.04.2023 20:07, Jose E. Marchesi wrote: > >> On 27.04.2023 11:59, Jose E. Marchesi wrote: >>> >>>> On 26.04.2023 19:31, Jose E. Marchesi via Binutils wrote: >>>>> --- a/gas/testsuite/gas/bpf/alu-be.d >>>>> +++ b/gas/testsuite/gas/bpf/alu-be.d >>>>> @@ -1,5 +1,6 @@ >>>>> #as: --EB >>>>> #source: alu.s >>>>> +#source: alu-pseudoc.s >>>>> #objdump: -dr >>>>> #name: eBPF ALU64 instructions, big endian >>>> >>>> I may of course be reading binutils-common.exp's run_dump_test wrong, >>>> but is this having the intended effect of assembling each of the files >>>> once and checking objdump output for each of them? It looks to me as >>>> if only the assembling step would be performed for both, which I don't >>>> think is what is wanted. >>> >>> It was an attempt to avoid having to replicate the same contents in >>> alu-be.d and alu-be-pseudoc.d. Will look into this too. >> >> I assumed that would have been the goal, but that's achieved by using >> #dump: instead (in a new, small *.d). > > Thanks for the hint. I just pushed the fix below that makes use of > #dump. Hmm, thanks for doing this, but ... > From 2b8c7766ea357ff9b22531d6fdf0c3bd69cc044f Mon Sep 17 00:00:00 2001 > From: "Jose E. Marchesi" > Date: Thu, 27 Apr 2023 20:05:19 +0200 > Subject: [PATCH] gas: bpf: fix tests for pseudo-c syntax > > This patch fixes the GAS BPF testsuite so the tests for pseudo-c > syntax are actually executed. > > 2023-04-27 Jose E. Marchesi > > * testsuite/gas/bpf/mem.dump: New file. > * testsuite/gas/bpf/mem-pseudoc.d: Likewise. > * testsuite/gas/bpf/mem.d: #dump mem.dump. > * testsuite/gas/bpf/lddw.dump: New file. > * testsuite/gas/bpf/lddw-pseudoc.d: Likewise. > * testsuite/gas/bpf/lddw.d: #dump lddw.dump. > * testsuite/gas/bpf/jump.dump: New file. > * testsuite/gas/bpf/jump-pseudoc.d: Likewise > * testsuite/gas/bpf/jump.d: #dump jump.dump. > * testsuite/gas/bpf/jump32.dump: New file. > * testsuite/gas/bpf/jump32-pseudoc.d: Likewise. > * testsuite/gas/bpf/jump32.d: #dump jump32.dump. > * testsuite/gas/bpf/lddw-be.dump: New file. > * testsuite/gas/bpf/lddw-be-pseudoc.d: Likewise. > * testsuite/gas/bpf/lddw-be.d: #dump lddw-be.dump. > * testsuite/gas/bpf/indcall-1.dump: New file. > * testsuite/gas/bpf/indcall-1-pseudoc.d: Likewise. > * testsuite/gas/bpf/indcall-1.d: #dump indcall-1.dump. > * testsuite/gas/bpf/indcall-1-pseudoc.s (main): Fix lddw > instruction. > * testsuite/gas/bpf/atomic.dump: New file. > * testsuite/gas/bpf/atomic-pseudoc.d: Likewise. > * testsuite/gas/bpf/atomic.d: #dump atomic.dump. > * testsuite/gas/bpf/alu32.dump: New file. > * testsuite/gas/bpf/alu32-pseudoc.d: Likewise. > * testsuite/gas/bpf/alu32.d: #dump alu32.dump. > * testsuite/gas/bpf/alu.dump: New file. > * testsuite/gas/bpf/alu-pseudoc.d: Likewise. > * testsuite/gas/bpf/alu.d: #dump alu.dump. > > * testsuite/gas/bpf/alu-be.dump: New file. > * testsuite/gas/bpf/alu-be-pseudoc.d: Likewise. > * testsuite/gas/bpf/alu-be.d: #dump alu-be.dump. > * testsuite/gas/bpf/alu32-be-pseudoc.d: New file. > * testsuite/gas/bpf/alu32-be-dump: Likewise. > * testsuite/gas/bpf/alu32-be.d: #dump alu32-be-dump. > * testsuite/gas/bpf/bpf.exp: Run *-pseudoc tests. ... why all the new *.dump files? That's far more code churn than was necessary, as the original *.d files served their purpose quite fine, while the new tests would only have needed to reference those *.d ones. Anyway - I guess it is as it is now, but please consider (prefer) the alternative in the future. Jan