public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: Simon Marchi <simon.marchi@polymtl.ca>
To: Eli Zaretskii <eliz@gnu.org>
Cc: binutils@sourceware.org, gdb-patches@sourceware.org
Subject: Re: Using the vcs_to_changelog.py script
Date: Thu, 13 Feb 2020 21:07:00 -0000	[thread overview]
Message-ID: <e9f3f58a-67b6-c435-b8bd-d4f2b88b7e78@polymtl.ca> (raw)
In-Reply-To: <837e0qqpps.fsf@gnu.org>

On 2020-02-13 1:58 p.m., Eli Zaretskii wrote:
>   2) we need some guidelines for "good commit messages", otherwise
>      patch review will need to pay a lot of attention to discussing
>      that and making sure the log messages are fine

We can write some guidelines for sure, it wouldn't hurt.  But I think that as a
project, we have already some quite good standards in terms of commit messages.
These discussions already happen during reviews.  And even with those guidelines
written, we'll still need to pay attention to it, because I can assure you that
we will still receive patches with bad or non-existent commit messages.

>> However, for the benefit of people just using
>> tarballs, and not the VCS, we generate a ChangeLog file from the diff.
>> Naturally, the generated ChangeLog will be less informative than one written
>> by humans (it won't say what changed in a function, it will just say that
>> the function has been modified), but since that procedure was adopted by glibc,
>> and is mentioned in the proposed standards.texi change, then it must have been
>> considered an acceptable compromise.
> 
> I have yet to see this accepted as GNU policy.

Sure, we can wait for this to become official.

>
And at least
> personally, having a ChangeLog in a tarball that just says which
> function was changed on what date is almost useless to me (and I do
> sometimes need to work without access to the VCS repositories).

Indeed.

Simon

  parent reply	other threads:[~2020-02-13 21:07 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-12 23:33 Simon Marchi
2020-02-13  1:03 ` Alan Modra
2020-02-13  2:29   ` Jeff Law
2020-02-13  3:13     ` Simon Marchi
2020-02-13 14:13     ` Eli Zaretskii
2020-02-13  3:37 ` Eli Zaretskii
2020-02-13 14:19   ` Simon Marchi
2020-02-13 15:42     ` Eli Zaretskii
2020-02-13 16:26       ` Simon Marchi
2020-02-13 18:58         ` Eli Zaretskii
2020-02-13 19:09           ` Philippe Waroquiers
2020-02-13 19:29             ` Eli Zaretskii
2020-02-13 20:56               ` Simon Marchi
2020-02-13 21:07           ` Simon Marchi [this message]
2020-02-14  9:45             ` Eli Zaretskii
2020-02-14 19:31               ` Simon Marchi
2020-02-14 20:16                 ` Eli Zaretskii
2020-02-14 21:08                   ` Simon Marchi
2020-02-15  7:26                     ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e9f3f58a-67b6-c435-b8bd-d4f2b88b7e78@polymtl.ca \
    --to=simon.marchi@polymtl.ca \
    --cc=binutils@sourceware.org \
    --cc=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).