From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2084.outbound.protection.outlook.com [40.107.21.84]) by sourceware.org (Postfix) with ESMTPS id 5ECAE385AE54 for ; Thu, 14 Jul 2022 06:08:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 5ECAE385AE54 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mUULHVzmlxeHrRmfaoxE5zr66eTWNJ91byPKv4wToKp0hCmeHKC6qIiucPBz2bKUAY/6WkhyiuB30zzhHpkApeX4EHyQRTMPg2DScQowPukYzoFzbvulG81J8x/txWWVCeEhMHz+mpVJ7MaIvK2xycBBKZfawmUIMClQckemgUMCgFfOxds5UW5jCQwxDVJ5q6amT+IqBmkYOkuQL4UMUtB2PpnVI5N9WDX/40kpILJkpcUuVglgs+kFjS5OzYRkLeixYwpm7S1O1Wm1aspMovAQ9ZbuGQwRS+mTiNnlYuu1eks8U5BAeNd/HGB7xeU59oY08+mkZN5+GpwWpYDsfw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jAFXy8wDr42wZQE/5PMp4lY7wDji9XxaY6xJvufiZfY=; b=FaTycvyuGdbsBm0ShzmZ7D07LBzoIoi7Pp48ThixqSqW0oegDSAGuJPEvDa52TPqng7JN5uONDkg4kHTpLVEiBRBne2x6CoYS/tk9iYMiNX7L4EfQf1LNxfyxTIov4XxjxlelN6wsQq9pkFyWMu2qPEORY0z7SIArvMBGy/jSgvYCMW+8s4cds8i8EW5Zz0fbhYK7Whon6o+ab23z8MzmhwaWlblnYKuSwzUFQcq59FyTWc7kVkeNk0jZ9sVZdcwq73cJZ1QX70b4vdT1uR5wtBfeu1qab4tQrQvcJG2ih1YcHrj4YDo9+jnhcxYuIQHBrlB77miPEsO6U+uiyzQaQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by VI1PR04MB4287.eurprd04.prod.outlook.com (2603:10a6:803:41::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.26; Thu, 14 Jul 2022 06:08:09 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4%4]) with mapi id 15.20.5438.014; Thu, 14 Jul 2022 06:08:09 +0000 Message-ID: Date: Thu, 14 Jul 2022 08:08:07 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH] libopcodes/ppc: add support for disassembler styling Content-Language: en-US To: Alan Modra , Andrew Burgess Cc: binutils@sourceware.org References: <20220712133609.3348690-1-aburgess@redhat.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0053.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4a::6) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 38ef126a-ee3d-4e18-359b-08da655f39f0 X-MS-TrafficTypeDiagnostic: VI1PR04MB4287:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: gsviul7mwYr/d5mEGQop1UQItajuKxo3xtUG4vkxGeumyyfTKLxd8b3JI0WoThLHKcxPEAc9+Udbe7s7PBpoluldoRRDuW6utO5DoJg+KDICX5RhsO7mTq8fVwcKBERWvPo9dB7zCF1Q9qC/UnZde52OgvXt4/83qGdpvNpc9pAZP3CuYOuYGt4bDJg3ywzeFJpQWiBukgVY96JABRzSU9R2CiT4p3iOjuimAGd0CBzqd4cSwbnZ+gCtbbJR6VWZbNb00sNymrcAiyJsQeoQ6tQ3R2fmM8v3+uXOLPWDbbNB9us6a1mkwuRnPwvdQQsJAHj6dN3z5wiAbwp27p0Hg4dDvssvP6rFPwUolmPrrUcdxQEfaLOz8W7nPgJN/t0kFUoShyRihkeDrWGt3kCHi+ds7iCi1x6Cjz7A6Zsmm+wvWXA65naC6VM9Szd5EpZBFm204ZsrdqcnNqW9XJlBnLX9/IBl/oh3ZV9HH+xVQ5nSAKrWCAzNG6ypSxSLox/P9cL6UfaQg3gGZ+56/PxyQz59DwNl0zEjyjwU0sDKMXNKqf5ZKaauA6NcgNQsbLnJIhOmYxnyLSilsaCvA5zM7yrIHOn0ab9OwuV/3iJBJxajphPq9vSd2KrlTOikp11hh0bc0zfys7tOp1O2fEIii2RCDVrWM/1kC+7miGpwuFIPrWHy+Bw/w54HB9b56AwhYwDIk59dVvB8TpERGsVwH574khuxQYRE4RqXraZw5JErBo8Shluut4GtrvIJtzF8eAtpyOtc8cPz0T7m42O/FR4l4Mi+OgX054Vr5WwDr+EnsA0DZqDAw+of8PCo262NKTyUbGxuuT8R9HbNnxA3kzUBnjo3qCxFDCVV9etV6so= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VE1PR04MB6560.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(346002)(396003)(366004)(136003)(376002)(39860400002)(2616005)(110136005)(86362001)(316002)(186003)(31696002)(5660300002)(38100700002)(478600001)(8676002)(4326008)(6486002)(83380400001)(66476007)(66556008)(66946007)(8936002)(53546011)(6506007)(2906002)(26005)(6512007)(36756003)(41300700001)(31686004)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SzZUU2tub3lINy9LcGxSS2dBNDhpM3hDd2swR1loQVNxdS9sVjR1YXpyQXll?= =?utf-8?B?eDNFeHZKQmhaUnFUREFOVkMrd0JJY2txNGk4NTdjOVBWS2VTNVZraWR1OGlu?= =?utf-8?B?c1pYa1FpNjRHUGt0UFFHT0hOaG83RitQcEsyM2pwUmloVnJCWVFlT1hpaHFK?= =?utf-8?B?Q2crSWd0WFhZVEJEU3ViUmduTkx0NHUzU2hVandsNHk0cGFka2grWFBTTlVM?= =?utf-8?B?dng1SU1hT0xzdkRVUENEc0tIbXlTQ0tmYkdQM2ZKQ0x4aDhtdW95VFRmSlhl?= =?utf-8?B?eWJXd2JmRkRPM1R5NmlmYlBDRVUyS1FJR2lmUXcvTExSOTdvb3l6MG0yM2pm?= =?utf-8?B?bHY5bUJNL2pXMm0wRUtya1BHeXRDOUYya2VlQnNSeUlIYVpNZUVDUlZ5dEdw?= =?utf-8?B?OUZMQ0tTcW1Bd1l0T0NpZXdXV2Jha0Z6VnBlMFg3MFVvWldUVzBWTVNZLzhC?= =?utf-8?B?NlVCYkFwbE1WMVFoekxzWlRVNmdLWjV3dE1rUzIxQnVXWXk5TmFWVTg3RGQr?= =?utf-8?B?SVVZR2lIM0J6c1l1ckJwYmhGbFFZaGVJWnc0S1M3NHJYL1loallsdXVpM2dZ?= =?utf-8?B?NnVrNHI2SGhLQWovL2k4RHFsN1orcGcvQVBPcURSbE9scjM5QjRMa2Jjc3o5?= =?utf-8?B?WERYOWNsNURHMEF3TWhYQ3VINFdEMWNzY1I2dm1OdTFHUEUrQlN3cVYxMnRC?= =?utf-8?B?ZHhQK1RQaDNyRG5CNW5Qa3pnU1JHU3Q1YndFNnlEUEx2SVRaSng5YXhwZnpZ?= =?utf-8?B?SVVVNUpIZTd6bkQ5aDhPdlRCWkZBL0lWZGc0S0lnNm1hVGMrbmRnYnYvRlR4?= =?utf-8?B?Q3Q1d29vcm1zRXBKd3NadVZaSlBuYVdXcFJRMWRxSG1DL3A0V1VGcCtNeDhX?= =?utf-8?B?Ry94VFdETGczWXAyOXUwS1pidldFdDJzbWM0a2JaWlZEUTFGamlNczBLSWFD?= =?utf-8?B?SlBWdUx1R3J1czdvY0dTMUxwMlRqWldsUDhXNVVoK0NLb09od3ZDM2JxRWts?= =?utf-8?B?SEVJeEswM0lkaXdtb1R0TXRINXJuOXVqLzhVb2IraEFGK0RWK3FVVExBdktK?= =?utf-8?B?azFPcGNEcjhFaGxxOVFUYi95Ny9EcG9XUlRaVE5GVmR1amx4Z2VmVVJEK0dT?= =?utf-8?B?WEJ3VUowSkpWZFBNOE9tVWpoVmYwT0QvbWtDZmtGZHFWa3VUMWFEdmJlVlk3?= =?utf-8?B?OVpmQUFvek5xNnZSdzM5Q1g1d2xMa2RnQkU1T0l0MEQwMTB1cTVYYTVMQlRD?= =?utf-8?B?R0t4dEttaW5XYjkyQUMrZ2Eya3lEcjZJOWdub3B3MXdmSjREZkxiOXM3azA1?= =?utf-8?B?MjZ5U0J1TTdZQi82SitGTi8yUjZuYXpxbUtNN210dWNoVTZwRS84Rk1RQk43?= =?utf-8?B?aURReUdjelJaZExqVUdhR0xZWlBjMSs2NkJ1TFR3emFmM1FqRDNKaERiZ2dD?= =?utf-8?B?WFZUUnpwRVFRK0hTaHVDa2UrYW5xejMxSkdlbndQOFJRUmtYeThaOSt3NjFi?= =?utf-8?B?R21DaExLVmdQSmxaYytsTFlEL3ZialVyeXdMNGkyeW1GNFY5WUNlWUI3NzBN?= =?utf-8?B?TzY0RDNSU3B6VTl0bktsb1dWNmVVcnJjZUdRYmRqNzZSSlp3V1Q5dmk1WUds?= =?utf-8?B?V0JiYVp2aGEwbzJYNmNIUjZSM0tSVjRxcnBsMWNVZ0tRZ2E3Y2RjVHFpNG5t?= =?utf-8?B?QXRXTGpTYSszUHBTUFZjNk5Wb0ZWdTNXM1FXSEZwMEtmTGRneWRtYUU1VjRq?= =?utf-8?B?RFQwaHFJSjFmcnJNNXE5WkdZY3ZzUlJRTUR3YmdQVDE0UFdZSXdVUGNrWEtq?= =?utf-8?B?UGlOaHBveDk1THRtVFVsVHM1WXlwQ1NWeS9aZTlwdE03WWh2ajd3QkRsNkhY?= =?utf-8?B?eTRkQWJackhvSTRFbHdEeTF5NW5PUnRnaVZta09ONzNhSnpIaHlwZmgxTVU1?= =?utf-8?B?L0hPSzhWYldtSXE4WTZxYmxtd1VDR2F2NnY1UXRmVWlQT0F0OUpuSEFFSk4v?= =?utf-8?B?QnQyWkVXWnN1ay8zbkFpR0luakxzUU56YnhZNE9BOVQ3NzZwVmxaV1NBZFpQ?= =?utf-8?B?RTQ4VFlzMDU2TFVjM3gzSmJWY3Q3aTJOWkgvbGpwd2JKUlVnUVhySlFFZEkw?= =?utf-8?Q?+la5PLAeFzWlrHpv3gp1eUrI1?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 38ef126a-ee3d-4e18-359b-08da655f39f0 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jul 2022 06:08:09.6094 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: +ac2HWDE45eEkwmMDsKaCT9B3SyjNDoagDkKf0s/PpaBg1OSXADQuE9BIiR2/KTQ8bBHAtYGC0RP/QIg1nfAwA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4287 X-Spam-Status: No, score=-3030.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Jul 2022 06:08:14 -0000 On 14.07.2022 04:09, Alan Modra via Binutils wrote: > On Tue, Jul 12, 2022 at 02:36:09PM +0100, Andrew Burgess via Binutils wrote: >> I think the only slightly weird case was how things like '4*cr1+eq' >> are styled. As best I can tell, this construct, used for example in >> this instruction: >> >> crand 4*cr1+lt,4*cr1+gt,4*cr1+eq >> >> is used to access a field of a control register (NOTE: I know very >> little about the PPC ISA, so please correct me if I'm wrong). As >> such, I have styled the entire construct as a register. In some cases >> constructs similar to the above can be simplified to just 'eq', as >> this is still referencing a register field, this is still styled as a >> register. > > This field is also present in conditional branches, and looking at > those is perhaps is the best way to understand what ought to be done > here. > > eg. this instruction > lab: beq 7,lab > disassembles with "objdump -d" to > beq cr7,0 > and with "objdump -d -Mraw" to see the underlying hardware insn > bc 12,4*cr7+eq,0 > > So the field probably ought to disassemble the "4*" and "+" as text, > the "eq" the same as the opcode mnemonic, Or maybe that new type which was introduced for Arm64? Jan > and the "cr7" as a > register. At least, that seems a reasonable way to highlight the > "interesting bits" to me.