public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: Tsukasa OI <research_trasio@irq.a4lg.com>
To: Nick Clifton <nickc@redhat.com>, Jan Beulich <jbeulich@suse.com>
Cc: binutils@sourceware.org
Subject: Re: [PATCH v3 1/1] bfd, binutils, gas: Remove/mark unused variables
Date: Wed, 21 Sep 2022 14:54:26 +0900	[thread overview]
Message-ID: <ea2adf5e-b556-bb63-084f-12092f7eaad6@irq.a4lg.com> (raw)
In-Reply-To: <1ae9efe3-f890-ee6e-11ad-f5045616f253@redhat.com>

On 2022/09/20 21:50, Nick Clifton wrote:
> Hi Tsukasa,
> 
>> bfd/ChangeLog:
>>
>>     * elf32-lm32.c (lm32_elf_size_dynamic_sections): Mark unused
>>     rgot_count variable.
>>     * elf32-nds32.c (elf32_nds32_unify_relax_group): Remove unused
>>     count variable.
>>     * mmo.c (mmo_scan): Mark unused lineno variable.
>>
>> binutils/ChangeLog:
>>
>>     * windmc.c (write_rc): Remove unused i variable.
>>
>> gas/ChangeLog:
>>
>>     * config/tc-riscv.c (riscv_ip): Remove unused argnum variable.
>>
>> ld/ChangeLog:
>>
>>     * pe-dll.c (generate_reloc): Remove unused bi and page_count
>>     variables.
> 
> Patch approved - please apply.
> 
> Cheers
>   Nick
> 

Nick and Jan,

I sincerely apologize that I thought previous "okay" mail from Jan, a
maintainer:
<https://sourceware.org/pipermail/binutils/2022-September/122890.html>
as an "approval" and applied this patch already.

I will not merge the patch again unless the word "approve" is used
explicitly.  I am really sorry.

Regards,
Tsukasa

  reply	other threads:[~2022-09-21  5:54 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-15  3:09 [PATCH 0/1] bfd, binutils, gas: Mark " Tsukasa OI
2022-09-15  3:09 ` [PATCH 1/1] " Tsukasa OI
2022-09-15  4:17 ` [PATCH 0/1] " Tsukasa OI
2022-09-15  4:17   ` [PATCH 1/1] " Tsukasa OI
2022-09-15  7:29     ` Jan Beulich
2022-09-15  8:25       ` Tsukasa OI
2022-09-15 23:10         ` Hans-Peter Nilsson
2022-09-15 12:46   ` [PATCH v3 0/1] bfd, binutils, gas: Remove/mark " Tsukasa OI
2022-09-15 12:46     ` [PATCH v3 1/1] " Tsukasa OI
2022-09-15 12:58       ` Jan Beulich
2022-09-20 12:50       ` Nick Clifton
2022-09-21  5:54         ` Tsukasa OI [this message]
2022-09-21  6:15           ` Jan Beulich
2022-09-21  9:55           ` Nick Clifton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ea2adf5e-b556-bb63-084f-12092f7eaad6@irq.a4lg.com \
    --to=research_trasio@irq.a4lg.com \
    --cc=binutils@sourceware.org \
    --cc=jbeulich@suse.com \
    --cc=nickc@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).