public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: Jan Beulich <jbeulich@suse.com>
To: "Cui, Lili" <lili.cui@intel.com>
Cc: hongjiu.lu@intel.com, binutils@sourceware.org
Subject: Re: [PATCH v2 2/8] Created an empty EVEX_MAP4_ sub-table for EVEX instructions.
Date: Wed, 18 Oct 2023 08:12:34 +0200	[thread overview]
Message-ID: <eaad54c2-0f93-2dc4-3644-4803a0dc12fa@suse.com> (raw)
In-Reply-To: <20231017154352.4070250-1-lili.cui@intel.com>

On 17.10.2023 17:43, Cui, Lili wrote:
> opcode/ChangeLog:
> 
> 	* i386-dis-evex.hi: Added an empty EVEX_MAP4_ sub-table for
> 	legacy insn promote to EVEX insn.
> 	* opcodes/i386-dis-evex.h: Add EVEX_MAP4.

This is okay, but please don't commit ahead of time. We don't want to
carry such an empty table. Thanks for doing the split.

Jan

  reply	other threads:[~2023-10-18  6:12 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-17 15:43 Cui, Lili
2023-10-18  6:12 ` Jan Beulich [this message]
2023-10-18  7:18   ` Cui, Lili

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=eaad54c2-0f93-2dc4-3644-4803a0dc12fa@suse.com \
    --to=jbeulich@suse.com \
    --cc=binutils@sourceware.org \
    --cc=hongjiu.lu@intel.com \
    --cc=lili.cui@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).