From: Jan Beulich <jbeulich@suse.com>
To: "Potharla, Rupesh" <Rupesh.Potharla@amd.com>
Cc: "George, Jini Susan" <JiniSusan.George@amd.com>,
"Parasuraman, Hariharan" <Hariharan.Parasuraman@amd.com>,
"Kumar N, Bhuvanendra" <Bhuvanendra.KumarN@amd.com>,
"Potharla, Rupesh via Binutils" <binutils@sourceware.org>
Subject: Re: [PATCH] Ignore DWARF debug information for -gsplit-dwarf with dwarf-5.
Date: Thu, 29 Sep 2022 18:03:14 +0200 [thread overview]
Message-ID: <eacd9e57-cdc2-4790-fc7f-9f8f331ba328@suse.com> (raw)
In-Reply-To: <DM6PR12MB4219EA6DDE824C2EF4454D1BE7579@DM6PR12MB4219.namprd12.prod.outlook.com>
On 29.09.2022 17:54, Potharla, Rupesh wrote:
> .debug_info contents:
> 0x00000000: Compile Unit: length = 0x00000031, format = DWARF32, version = 0x0005, unit_type = DW_UT_skeleton, abbr_offset = 0x0000, addr_size = 0x08, DWO_id = 0xcd97775ca070a83c (next unit at 0x00000035)
>
> The issue is seen with both clang and gcc. Above is the Debug_info header of a program compiled with gcc using -gsplit-dwarf and dwarf-5.
> There are two other fields(abbr_offset and addr_Size) after unit_type in the header. Skipping the dwo_id field in the previous check of unit_type will not fix the issue.
According to the doc I'm looking at the headers for DW_UT_type and
DW_UT_skeleton agree up to the debug_abbrev_offset field. This
matches the code, which reads addr_size and abbrev_offset ahead of
the DW_UT_type conditional I was talking about. What's between that
if() and the one you're adding in your present patch is _precessing_
of addr_size, but not fetching of it from the header. This is
supported by the intermediate code also not further touching
info_ptr.
Jan
next prev parent reply other threads:[~2022-09-29 16:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-29 12:43 Potharla, Rupesh
2022-09-29 15:00 ` Jan Beulich
2022-09-29 15:54 ` Potharla, Rupesh
2022-09-29 16:03 ` Jan Beulich [this message]
2022-09-29 16:39 ` Potharla, Rupesh
2022-09-30 5:53 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eacd9e57-cdc2-4790-fc7f-9f8f331ba328@suse.com \
--to=jbeulich@suse.com \
--cc=Bhuvanendra.KumarN@amd.com \
--cc=Hariharan.Parasuraman@amd.com \
--cc=JiniSusan.George@amd.com \
--cc=Rupesh.Potharla@amd.com \
--cc=binutils@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).