From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx07-00178001.pphosted.com (mx08-00178001.pphosted.com [91.207.212.93]) by sourceware.org (Postfix) with ESMTPS id AEA9A3858288 for ; Tue, 17 Oct 2023 15:35:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org AEA9A3858288 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=foss.st.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=foss.st.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org AEA9A3858288 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=91.207.212.93 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1697556960; cv=none; b=wL/9e7fuWWLEyd2uNmvn+tfxCtzKiaK1OVk75S4hV53/0Usf1WQRBmLyiEL5ymEmLo1FYtBJ40kqF5BRHP/4DLOVscrynl/0tj3oYZSHltmwKZpR6sLu8F7w4npL7BBB0jqW4Pv0bzs3Fe4WIIZkJBiLYruKQMtv0hxsCKRw90s= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1697556960; c=relaxed/simple; bh=ImFFUcgKvZe3JRlo1YEzWuspLKK1Ou++WZBJQIYBirY=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=FXhhxxJbNXFbtA1Ej7LfqZO2Ob0d2WwPSF3N9EZaVeG4Izv0enyd3kptS9Fd/QXPKay/W8eVrISmD+rjGaC7tqcWdIlD7ph7nS52N8Ij0GRPUl+IOrCZFdCO+Z8zRKrav+r0DDZZHDRkKqa4YLqFmrYRA74xNdNjbXyK1cbROEY= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from pps.filterd (m0046660.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 39HCdxDl018052; Tue, 17 Oct 2023 17:35:53 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h= message-id:date:mime-version:subject:to:cc:references:from :in-reply-to:content-type:content-transfer-encoding; s= selector1; bh=xp10BAKEToa5cdMejcVv5gSSNU+qEyjVGO8232C3y5k=; b=j+ v9WoHurkx3ArgyGJdWV6G/0UztgH/nLIyIvoUk1M53RZQIyDK+1MIcBnx19Nctu/ CFxEbal7ijoIydvlXFWnW+o31cJaWcFWcsqSV8n7l74xl2B+ob/EyHteto9IYP4X 6YGShOpAYmr7dclyXVvFJj2yDij4r4Hf3s5p/yTvRGUGcGMjlIbrKShVl3JH/kgo e5oF3WQX+Bpk1o7vb1+8ffkXnQMpSJVHHxySYgINTCyOXfiEox5TAZ+iX+N+k0T/ K+nwFXI0lcdC/fdlZF2DczHu042wRb3dziPtBq33kyugT6wtOtWr7qoV0K6jQVCZ 3k+t/XurSKTNmpsvbVig== Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx07-00178001.pphosted.com (PPS) with ESMTPS id 3tqkbedsjx-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 17 Oct 2023 17:35:53 +0200 (MEST) Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 07D29100059; Tue, 17 Oct 2023 17:35:52 +0200 (CEST) Received: from Webmail-eu.st.com (shfdag1node3.st.com [10.75.129.71]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id 02901264E58; Tue, 17 Oct 2023 17:35:52 +0200 (CEST) Received: from [10.74.18.1] (10.74.18.1) by SHFDAG1NODE3.st.com (10.75.129.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Tue, 17 Oct 2023 17:35:51 +0200 Message-ID: Date: Tue, 17 Oct 2023 17:35:50 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v8] libctf: Sanitize error types for PR 30836 Content-Language: en-US To: Nick Alcock CC: , , Yvan ROUX References: <87ttqrae3o.fsf@esperi.org.uk> <20231016125059.1798219-1-torbjorn.svensson@foss.st.com> <87ttqp8emc.fsf@esperi.org.uk> From: Torbjorn SVENSSON In-Reply-To: <87ttqp8emc.fsf@esperi.org.uk> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.74.18.1] X-ClientProxiedBy: EQNCAS1NODE3.st.com (10.75.129.80) To SHFDAG1NODE3.st.com (10.75.129.71) X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.980,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-10-17_03,2023-10-17_01,2023-05-22_02 X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,KAM_NUMSUBJECT,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2023-10-17 17:15, Nick Alcock wrote: > On 16 Oct 2023, Torbjörn SVENSSON told this: > >> Made sure there is no implicit conversion between signed and unsigned >> return value for functions setting the ctf_errno value. >> An example of the problem is that in ctf_member_next, the "offset" value >> is either 0L or (ctf_id_t)-1L, but it should have been 0L or -1L. >> The issue was discovered while building a 64 bit ld binary to be >> executed on the Windows platform. >> Example object file that demonstrates the issue is attached in the PR. >> >> libctf/ >> Affected functions adjusted. >> >> Signed-off-by: Torbjörn SVENSSON >> Co-Authored-By: Yvan ROUX > > Looks good to me! I'll push my test for this after your fix goes in. > Thanks Nick for your review and test effort. Pushed.