From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 768013858407 for ; Tue, 22 Mar 2022 15:33:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 768013858407 Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-323-GR_YV-2nMpK1iWR81VHZiw-1; Tue, 22 Mar 2022 11:33:43 -0400 X-MC-Unique: GR_YV-2nMpK1iWR81VHZiw-1 Received: by mail-wm1-f71.google.com with SMTP id h127-20020a1c2185000000b0038c6f7e22a4so1539732wmh.9 for ; Tue, 22 Mar 2022 08:33:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=n69Vlq6+3UiyLgdJP2gywaUiFatwmDKAhnn6E8nJFG8=; b=U1omSYHg363vzLwLKaSCHGs1MA2fKw5kC2SJ2oS6cTo6/fZjxJrQVr10hduTktuUug qI9ZCVznxXa900cEvagrreSvG7A9qlzSE3sJkLxgTsEScE7MCfv9TxJz5Yo4Lgo55JMd JMJKsd1yf+OZv+UMRa/597sH8qR8JIsiQ9qUFcq2GfVwE1krUtzVp7tw0tYyFULJGAoU sl4R/aWdrk9OOVhWGA81GPer5P+q4phfBC5gnloKjoIlYXxCBaH8NZVZV/7BGVta4Wk4 fMoPkIL4yyLb9c7Z/lygIwSVqQDS6O1vLt9RNWQxmfYNZZvriE6f8BAYFtOPYVyqMMH/ IKJQ== X-Gm-Message-State: AOAM531wOAAtUbDH18Swkv6YuPCk/OApc9E8brJi6oHkytpNbZto5PpG dZ0W4v4tUABnFES9IawUbifn88ybbrL+xa2fXq/FDCaWIDwZmmNjXVYVGKxvMl9oEh/Jh2XISj4 nz1DOv4nK6+CdV4fA5g== X-Received: by 2002:a05:600c:500a:b0:38c:991b:a4b with SMTP id n10-20020a05600c500a00b0038c991b0a4bmr4394736wmr.50.1647963222470; Tue, 22 Mar 2022 08:33:42 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyWDoZjAnfpaTLw0dDBB8PqHXKWtKawfyiczGo7m97T/ziwM5H+nU+e4EN1PFrCCuUyHZm+Eg== X-Received: by 2002:a05:600c:500a:b0:38c:991b:a4b with SMTP id n10-20020a05600c500a00b0038c991b0a4bmr4394710wmr.50.1647963222163; Tue, 22 Mar 2022 08:33:42 -0700 (PDT) Received: from [192.168.1.6] (adsl-2-solo-173-39.claranet.co.uk. [80.168.173.39]) by smtp.gmail.com with ESMTPSA id v14-20020a7bcb4e000000b0034492fa24c6sm2103373wmj.34.2022.03.22.08.33.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 22 Mar 2022 08:33:41 -0700 (PDT) Message-ID: Date: Tue, 22 Mar 2022 15:33:40 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH] Fix return code in _bfd_dwarf2_find_nearest_line(). To: "Steinar H. Gunderson" , binutils@sourceware.org Cc: sesse@chromium.org References: <20220321124333.1282079-1-sesse@google.com> From: Nick Clifton In-Reply-To: <20220321124333.1282079-1-sesse@google.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-GB Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Mar 2022 15:33:50 -0000 Hi Steinar, > +++ b/bfd/dwarf2.c > @@ -5602,7 +5602,11 @@ _bfd_dwarf2_find_nearest_line (bfd *abfd, > > done: > if (functionname_ptr && function && function->is_linkage) > - *functionname_ptr = function->name; > + { > + *functionname_ptr = function->name; > + if (!found) > + found = 2; > + } > else if (functionname_ptr > && (!*functionname_ptr > || (function && !function->is_linkage))) Patch approved and applied. Thanks for fixing this! Cheers Nick