From: Simon Marchi <simark@simark.ca>
To: John Baldwin <jhb@FreeBSD.org>,
gdb-patches@sourceware.org, binutils@sourceware.org
Subject: Re: [PATCH] Support AT_BSDFLAGS on FreeBSD.
Date: Wed, 25 Mar 2020 17:04:36 -0400 [thread overview]
Message-ID: <ec56111a-a55b-10c6-2b35-d622b0f0aacf@simark.ca> (raw)
In-Reply-To: <e136dc41-41a7-2bb0-9647-fbd76690fa9b@FreeBSD.org>
On 2020-03-25 4:37 p.m., John Baldwin wrote:
> I can add something. To date there aren't any user-visible changes. There is
> one flag defined that indicates that the running FreeBSD kernel supports a new
> 'sigfastblock' system call that allows a thread to register a signal mask in user
> memory that is treated as the signal mask so that sigprocmask() can just modify
> that mask in userland without invoking actual system calls. It's not documented
> though aside from the upstream commit message.
The commit changes fbsd_print_auxv_entry, so I presume that GDB will start printing
this auxv entry, if it is present, won't it? Isn't that a user-visible change?
Even if there is no user-visible change, it's good to mention it, as well as why you'd
like to make the change. The reviewer and future reader of this commit are not in your
head and don't have the same context to know why this was added.
Simon
next prev parent reply other threads:[~2020-03-25 21:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-25 17:25 John Baldwin
2020-03-25 19:00 ` Simon Marchi
2020-03-25 20:37 ` John Baldwin
2020-03-25 21:04 ` Simon Marchi [this message]
2020-03-25 22:05 ` John Baldwin
2020-03-25 22:11 ` John Baldwin
2020-03-26 12:49 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ec56111a-a55b-10c6-2b35-d622b0f0aacf@simark.ca \
--to=simark@simark.ca \
--cc=binutils@sourceware.org \
--cc=gdb-patches@sourceware.org \
--cc=jhb@FreeBSD.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).