From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp2200-217.mail.aliyun.com (smtp2200-217.mail.aliyun.com [121.197.200.217]) by sourceware.org (Postfix) with ESMTPS id A84DD3857C57 for ; Mon, 14 Sep 2020 12:32:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org A84DD3857C57 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=c-sky.com Authentication-Results: sourceware.org; spf=none smtp.mailfrom=lifang_xia@c-sky.com X-Alimail-AntiSpam: AC=CONTINUE; BC=0.1047943|-1; CH=green; DM=|CONTINUE|false|; DS=CONTINUE|ham_system_inform|0.018807-0.000124646-0.981068; FP=0|0|0|0|0|-1|-1|-1; HT=e02c03308; MF=lifang_xia@c-sky.com; NM=1; PH=DS; RN=2; RT=2; SR=0; TI=SMTPD_---.IWzh3wn_1600086741; Received: from 30.225.208.106(mailfrom:lifang_xia@c-sky.com fp:SMTPD_---.IWzh3wn_1600086741) by smtp.aliyun-inc.com(10.147.44.118); Mon, 14 Sep 2020 20:32:22 +0800 Subject: Re: [PATCH] CSKY: Set feature flags for default cpu. To: Cooper Qu , binutils@sourceware.org References: <20200913124806.10991-1-cooper.qu@linux.alibaba.com> From: Lifang Xia Message-ID: Date: Mon, 14 Sep 2020 20:31:32 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <20200913124806.10991-1-cooper.qu@linux.alibaba.com> Content-Type: text/plain; charset=gbk; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-12.2 required=5.0 tests=BAYES_00, GIT_PATCH_0, KAM_DMARC_STATUS, KAM_LAZY_DOMAIN_SECURITY, NICE_REPLY_A, SPF_HELO_NONE, SPF_NONE, TXREP, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Sep 2020 12:32:33 -0000 Merged. I add a comment in https://sourceware.org/bugzilla/show_bug.cgi?id=26608 Thanks Lifang Xia On 2020/9/13 20:48, Cooper Qu wrote: > Fix floating point instructions not recognized when building GCC. > > gas/ > PR 26608 > * config/tc-csky.c (md_begin): Set feature flags for default > cpu. > > --- > gas/config/tc-csky.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/gas/config/tc-csky.c b/gas/config/tc-csky.c > index 3518b2a2fdb..808dca1e52c 100644 > --- a/gas/config/tc-csky.c > +++ b/gas/config/tc-csky.c > @@ -1625,15 +1625,13 @@ md_begin (void) > struct csky_macro_info const *macro; > struct csky_arch_info const *p_arch; > struct csky_cpu_info const *p_cpu; > - int flags; > other_flag = (do_opt_mmp | do_opt_mcp | do_opt_mcache > | do_opt_msecurity | do_opt_mhard_float); > dsp_flag |= do_opt_mdsp | do_opt_medsp; > isa_flag |= do_opt_mtrust | do_opt_mvdsp; > - flags = other_flag; > > if (dsp_flag) > - flags |= CSKY_ARCH_DSP; > + other_flag |= CSKY_ARCH_DSP; > > if (mach_flag != 0) > { > @@ -1654,6 +1652,7 @@ md_begin (void) > #else > parse_cpu ("ck810"); > #endif > + mach_flag |= other_flag; > #endif > } >