From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01on2074.outbound.protection.outlook.com [40.107.13.74]) by sourceware.org (Postfix) with ESMTPS id F24723858D20 for ; Tue, 21 Feb 2023 08:40:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org F24723858D20 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Pn6oj++Xp4Y9KUJ1fgwM0PUaqGTCluAOun8ywWFhISEA/oZjIS00Ktq4obVKA9Q4f+rxFBjtiMIjcAOAoZdI/TbiGI8roTyDbpBs325aoniibR6WqPeKz3+pbmOBmVmjLv3ma00qaSvBzoPLju4YEPk7Sw5cWDlZVDa6rXHcHKNU64SKdwl9Bd+gskozS6cEk5yfq693oaQma1Tq3HhiGzOJZhtrIkb2DKSgKJXti37JwWpLrrCwgptUksHGB2JKbRSoMpjl5V+cVM49mtMumqCLoiloKMVnHzuh35vHM7hSdgaTlwCxJ1ePxLWtrLOta18iRGZSqqDOvd9W9RHVqA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Q+PCczaC3OCiV1wO4ntcp9FNZXOMAAkRGsGlFVKKUDU=; b=lF6PF53UpVOwfkGhNunI0d17dIuve3w7PWvrjb5SMK7Xtz4f94DOkm/xf5W8p0o3Pz9o6X+xzjtSWDCeliJE+Yqq2lUncAF1TPPz9it22cFqOFADUww+fEzgl4GHObCF6hShH+Bmq8NiTm/4CwQ/MK/pwoZOfmN1d9Sc3WpRAX1ipczyZEp31tklgUJna7mgdVwUkLOLf6PjWbZHMFavFqO4Eqnvdor874Q4gp2lVMRQUa7myOkRB+Fl+UJbwKsKaOnSUyyFGG6V+MQBStz1VCwH0mOLqrarp8Ehnb/Frn4qiSdXQkzDZDevwLTWPs9SE1JDABkxwapvNonNNqnbxA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Q+PCczaC3OCiV1wO4ntcp9FNZXOMAAkRGsGlFVKKUDU=; b=nNRSZge4QAjdzMlHlQqBDKggQc4N9TatDT89cgnfzbLFshsW/dO2RYn2WI/yTsNVXqgB/LXpVTSQ0qN3rOiW/SyYDq4b97q/cnGZccEjpdtmv9Dr5VgCIduUXybxgI7F8074JbbKjstWaaybdSpOq6KSTFO2s2ZyTdLMhT7ZUTNWE5okxKBBZ+8r8SwduIp774S5gYRrUXzsNW98h7Mgxt1vQGNvUlsaKmFFAEaDsf9y9cKmyipDakt6xPfkexx2zhBBxK+SKuHy4KIG5QfjNmYpyCi67riaf1+0aX/J1NxZ2noL0Ul3/qAn2MDsOZ+zELIxWa++8/tttsA+Ii6b2w== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS4PR04MB9362.eurprd04.prod.outlook.com (2603:10a6:20b:4e7::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.19; Tue, 21 Feb 2023 08:40:53 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178%7]) with mapi id 15.20.6111.021; Tue, 21 Feb 2023 08:40:53 +0000 Message-ID: Date: Tue, 21 Feb 2023 09:40:55 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH 1/4] gas/testsuite: adjust a test for case insensitive file systems Content-Language: en-US To: =?UTF-8?Q?Cl=c3=a9ment_Chigot?= References: <20230220082224.415968-1-chigot@adacore.com> Cc: binutils@sourceware.org From: Jan Beulich In-Reply-To: <20230220082224.415968-1-chigot@adacore.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0009.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1d::8) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS4PR04MB9362:EE_ X-MS-Office365-Filtering-Correlation-Id: b8efb8d7-b1a5-48b1-17f8-08db13e7579f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: XgSWU5QKPWi2+JYDmGaP8w5UGIyj2Syx/uqq/+mPYtvMrvR8sZQvPNGAS7lUwRc3z+7JVVrdlXgNsMj+dSz1c/ph/jbTNmWesiPbI0D3Z0eMjJ0GmFwsercpq+C74AXHoEOGECACxi9JZXk7qDZBCp9pdbdBgWZyr8pahr4pcnNSSdBCqk13qXkGKidn+4huC5qdPINKwMi2+ikanl5A9AYQ91QkJYL5DEKY6rDzD/14a5OaAVGWkOPbnFFUgF3aNjvbgmSOciQ5kXbwdfGMNT5vG0wkAw/Tor6EW7HWDGYgLZFKRGQYStZFIxRPTo9hVFNyV9ZQcwRX1bXmbttShdZq4JXZuK9NAKNpQtl0FvCgwTTfaX1hnvyHqADixw7E1LywZdGeOWdmGiwp3fKOsTpHPis1eeIBVImcnmDsYFYzHBlxMO6k0HYXRu2d6en3gKk9YxZFKVD7/Btnk43kOyAV3jzfFuZwNrVIeUGy+WPLJ7hOQoXULvP5EFugyH9GUZovIfn+poCVNeTnuuFOIj2kkD1TPP1KmLub/cQlc9RUV5Wi+fUx8Dy0whDx4VOAMR9nx3y9X7TtZySG99jiG6c0lPNK8yZcuOXriFKqc3/VGxSsXwm5FOn5yWP+DCFILrzyAXNl+1kTPzi83/iqJcV+D//5zvoeDGxXgBaofqMxXPT+GIZgq5/yH80De4QgwC6AZVWt4mFggIP7EluyNVJJS1iputD/PKa2FFgbj4A= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(366004)(396003)(39860400002)(136003)(346002)(376002)(451199018)(478600001)(31696002)(38100700002)(86362001)(4744005)(2906002)(316002)(41300700001)(5660300002)(2616005)(53546011)(66946007)(8676002)(6916009)(4326008)(66476007)(66556008)(186003)(6512007)(66899018)(26005)(8936002)(31686004)(6486002)(6506007)(36756003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SktZWjhXTjV4bG5hTFhrSDErK01rb0Q2cUF1MTJyamE0QUs0bUdXK04yS0NR?= =?utf-8?B?TDZsODlSdXlEb3NobTFkMlhHNDh5bGE2RTBUSk5GZWVJR2kxamkwTmY1d1gx?= =?utf-8?B?VVRHcWhyeXQ3VjQzMWwvVE5CS3AvclhUbzFLVFRBOXVuVTkxbko2YnVWeE84?= =?utf-8?B?MDhqYmFkVllENTJwWTFVdDcyUHlUMmFPc2JNWDN1SVpZYmFHM3lEVG9GM2Vh?= =?utf-8?B?Mk52T0kybmppUVZKcnA1NVgxVmFnb0FxYVh3UkloUlROVGZyRTFWTmJMK0pn?= =?utf-8?B?SW84WW5GVHZjbWtaRzF4dVQ1ZWNzK0l2a1VDZjlzS3J0SEhHK1Q0T3o1MVFL?= =?utf-8?B?WU83aDBzdWllUC85S2w3WkdQWGhWMTk5UldRdTduNmxnUnpPa0NiaU1HMCtu?= =?utf-8?B?dEdBcTdRZ0p3ay9rdG5kWFVRUmZZMStrdy80cUpleFlSOE5zWnNEN3RjSWRl?= =?utf-8?B?bFRCU1pEQVRJWXB3MFpjYy9RclNQOGRKN2l6ZkU1cWtiRTJwc3pONGVqWGFa?= =?utf-8?B?aHJIYzBocmRaYmlGQW1sTVFuYXpRMnhUKytBbWlXdUF3YW8rK09nb3I1bHg3?= =?utf-8?B?K1kzN1NnaE1zNys5YURRVTg5S3ZIZmpxcWtpZ1VXRmxadVRLbHB0MlcvYmN4?= =?utf-8?B?a0tOenVWSHhHcE5RTURnaHJxTHo5QncvZ0hick11c2hmYWZHUVFRa0krUkVY?= =?utf-8?B?c0JKMnhUc21nOWltL2pRZXBkS2QrVDhLWEdiMVFaTHl1RHM4T2EyQU9ER3di?= =?utf-8?B?aHk4ZDJuNFg4cDN3SjNIUmY2WTdQRVNZTU92czhjSkdoWFl4cWZ5RlJJYlRy?= =?utf-8?B?ckc1RXRTZGY4ZHFzSXg2SXBpWXhjZEJTQUZ1SnRUMFB1dEVPQ1JHdTNzUWtB?= =?utf-8?B?OHFvWlMrY3UzWkRkTnkxKzNTQzJWUlJCd0RuR1RBSjZhdjUyd0QxZ3UrTDN3?= =?utf-8?B?RHllOTQydkptY3hyQk9YcXREVGg2ZnBRa2pZV0x6R3F1RVYwdURydUxRRzVC?= =?utf-8?B?d3FwWjdaZi9mZWlkK2NONjJYVDQrR0xQS1gzMWlnQzlRRlFITG9XMng1MGh1?= =?utf-8?B?UmRVbFRrOUVaUGMrVUpZMjBUOVVJMVFmNFpLNVNRMVlMUTRVWmYwVzJhcmpH?= =?utf-8?B?czd2MG1SN29rajdNdGhZWW5jLzVGVGljUDhLNTVjdExBb3hQNURxU01rLzZG?= =?utf-8?B?ejl0RGhrelVoR09neFNhZTlNL2xUZWNDd3JyUWJzZlN6OTl4Qm9nYitxd3E1?= =?utf-8?B?cCtYVTB0S3lWODdDbkhUNnhEZVQ1QnBMYWkvRzY1OUN1S2lGaHB1M3dEWHli?= =?utf-8?B?ditxSzdEZlFKbnZMZEtlRy9BdURMME93SU9XMXFPRHpSQkxveS91VXg0QzJw?= =?utf-8?B?RFlaYVRPVmR0Tytxa2JhdS94L3lVcGpGd2xvbHJObGZ0d2NlTXloejhhUXZJ?= =?utf-8?B?UElSUmVHYmEwN2dhM1E0bDd6VitqTHYxR1YvUDMxYmpOakNDcTVTVUh6WEt5?= =?utf-8?B?bTNpU0w1M01xSkJ5ZjRXakNPMTE4bldlZ1JXWG1CaHpuM3M2TkRLVlJPYjJN?= =?utf-8?B?SGptcWpuWVJSRk56UldxekRjOG9VWWQ0REh3dE9HVjI1VkY0cWlqVXRKN0NO?= =?utf-8?B?R1d5M0FjeUJNR2ZPUVpGRWthRmIzMWNZVzhUSFpnMTZjeFErSGh6aEtTc05z?= =?utf-8?B?RmxKYTBGblI0OXBzTWRmcFJPcVhNNXo2aHV2Sk41TEJ5TzFVdjdnMmpVdlpv?= =?utf-8?B?dDdUWWZPcGlpM1YrMlA1dlhPZkRJQ2F5SUh3cDJRbU16MUViMEpVd3dZNVBB?= =?utf-8?B?ZHd5NUhDNzEwOGJ2ak50NzMxN3ViNE5JV2RacnpVSGVlaWFQK1ZwOWE4TkdY?= =?utf-8?B?MFJHTkd6ZG85Q0lqNHN0M2Y2dVJFWEd0Q1JqTHpYT2wyRE9VMEM2YjBoT1ZU?= =?utf-8?B?NFg5Mi94aGM3djBRTlRYQ2g5SlExeTVNOSt4YVo2eU1hUXhkZmxlYkM0SXJL?= =?utf-8?B?ZWIybjBpdmJ6RnJDUWQwaklSM1RiZjZlaXFVM3RYclNUd1oyd2QwR2IxQWYy?= =?utf-8?B?UnpJLzB5clp6ZmdPbVNiQ3RxL0Yzd2FWTVRhTThhR2NHLytna0dFSzFvZEFV?= =?utf-8?Q?Bfiz+hHEFgwIGqYgW6dfTvLq6?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: b8efb8d7-b1a5-48b1-17f8-08db13e7579f X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Feb 2023 08:40:53.2724 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: BDKsms54W33GX2+ssnDb7BQEesuC65/N9gW8jBOniYYoLCrVJrUbeusX2+H8flYiG8v/hoHkfQSHnmaAmZQOhg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS4PR04MB9362 X-Spam-Status: No, score=-3028.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 20.02.2023 09:22, Clément Chigot via Binutils wrote: > When dealing with case insensitive file systems, ".file line.s" and > ".file Line.s" are identical and thus gas won't change the current > input file. > However, in line.l test, it's expecting to trigger an input file switch. > As the second filename doesn't matter in it, change it to fit for those > file systems. > > gas/ChangeLog: > > * testsuite/gas/elf/line.l: Change Line.s to new_line.s. Since I have a pretty sincere dislike for underscores in filenames, may I ask that you use e.g. line2.s or even (preserving original case) Line2.s? Other than that I'm okay with the change, albeit I'd like to point out that libiberty's filename_cmp() isn't really international- ready (works reliably only for ASCII), and hence there are apparently bigger issues here. Plus file system properties cannot really be a build- time constraint, as there could be a mix that is in use. Jan