From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by sourceware.org (Postfix) with ESMTPS id 43D0B3858C5E for ; Mon, 8 Jan 2024 00:47:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 43D0B3858C5E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=oracle.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=oracle.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 43D0B3858C5E Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=205.220.165.32 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1704674823; cv=pass; b=otRuWqF+AKBwPK88iHy0fvYh93QueOqctLK6+VNQfOVILjNCG59aqwG/qjXFcZytbVzX1nVu3q+u3dt1wV/g4ZjPKJeCKLVEq3+CFbnLd5sfo0Zs6niAOpefNJZKJDhbMLAqOVqz9TtIEkDk2e0uu2EIffhn7JtmkawYBZKFH2E= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1704674823; c=relaxed/simple; bh=TkVGaKpODLkUBGA6iVK/6Tzc6+imE8Yuk0nNC65UYMk=; h=DKIM-Signature:DKIM-Signature:Message-ID:Date:Subject:To:From: MIME-Version; b=PzkL4c7d9UKJxZZIh6a2IVQosB/+4h4K5YCy+qFXeX6SrtNNfwuTvChoO3PvuZLm+FFeVt1yOdh8KB71RzH1YeY4d9mplMm8cS152yZNeYDW3lc+5QJjejDu1+PtoZaOvI10B5mY6rRJaec9kGBYLVFKSi5779MH2GcDMjQDTDs= ARC-Authentication-Results: i=2; server2.sourceware.org Received: from pps.filterd (m0246629.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 4080ik3S000731; Mon, 8 Jan 2024 00:46:57 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=message-id : date : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2023-11-20; bh=1qlfGdhaEG6TQ9WDlcBRwqscWqKqGiexjBqwA7BsTbw=; b=ilrJdqfIq7sc5SsDkh/eVbFn+ZDiM93G30kaIvlUgcoRUFoKvsCJAFb7NnnVa3kfMn4f RA3XSK9aoYKGAGYCdoCgLbKD7G7KT2zqHEstTV3R945QE1TUlVUO3cqj+riuOB6f4K4F YQAnEmOmaVWJF/nKkpEIaD9bLQsE3JSFzG2sSdp5uXMnAr4l0eXnFYxHcIDV1Iz8vj99 kFPXJ8WxBQwOXUkNcGlaomr6KbOIPmp9DWDQYnAYwbJewayGmGfAPDHVwB0V1NZyESgu KZ/y35OMKhYx97ia0o6F1WSb5NHQVzjdhhe7y29X8UVJED3lneEPILIZ+/uaCesTOR4L EQ== Received: from phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta02.appoci.oracle.com [147.154.114.232]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3vg6s88017-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 08 Jan 2024 00:46:57 +0000 Received: from pps.filterd (phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 407Lahs0008836; Mon, 8 Jan 2024 00:46:56 GMT Received: from nam12-dm6-obe.outbound.protection.outlook.com (mail-dm6nam12lp2169.outbound.protection.outlook.com [104.47.59.169]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3vfuufnn65-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 08 Jan 2024 00:46:56 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PctsEqBq3du4vTws6zcSH9aQ5GpT3jUEQhIfooO62xGuvJ8Jq4Y4dChhpPjdaTnjbm9i2uHx+SawDz9OMokWJ22vhJf32yBVVM3fyqpO9XoPi2u48u6LRgg5339e8Box+oPORnu7y2asaSQr6Gfq19JCe2fxWmBZ5dzTGOyf3jZAYzwZBAqCRCSezft9KJ/Km3OgQx4z7IXNpKCQw7CwOKzHR+uYhKv/X8K8PuvGdjQUst1PmLIRbgk+7Eq86iqRq8es8+2xOued4OkDqsld5eImbmH8ATZgj1EuLZh4UdgD2oIbI2ioeruLkqUsxFyo/sf1guKLFgZ64F128qXMhg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1qlfGdhaEG6TQ9WDlcBRwqscWqKqGiexjBqwA7BsTbw=; b=K4XoNhnyXOVDdk+d6ZF8iDExgAeb1kxMVePoHWB46ouA1BNerh2SKcehYaMjYyi1ggVrI40mL7BujBDdZ4Lc6IRxVTqrWAAqOTMTozuQP43MCX3f4vx9J7cwxfmLSCmGdtsgULRObcEH1LSM9vlQOfm225IYrxt8eatWKNyVqK9fHf3yo8vsEUfTLwMXYQPcc2tGsaX0yntW7Ch7oIXaz3uqqv8ud924LLErzF7Sf1kcfr3dmwMun0NWqCCjQWQ0iokYPM7pBm7lOUfxNiXIzMKCzhC7SNHc6SGvicZfzdUL3GRkQM+x6eaT9T12RteW0N3HXJALRYALu6poucRZKg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1qlfGdhaEG6TQ9WDlcBRwqscWqKqGiexjBqwA7BsTbw=; b=MhWyAv3gqiE/B571QErVtSpS0OyoubBP0AF8+gthSqOukO8gCCsvGKKM82YlwhQuziTIT0IIg2Hy8SSR6HvfdKdcqsCPnoz71NdDqHmg3ofGRWO53syAmDEDiP5RW8y4K6p0SEwqKmgKvldFV8n4xiwGminJNpRXqnI7PihDElg= Received: from MWHPR1001MB2158.namprd10.prod.outlook.com (2603:10b6:301:2d::17) by SJ0PR10MB4592.namprd10.prod.outlook.com (2603:10b6:a03:2d8::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7159.21; Mon, 8 Jan 2024 00:46:54 +0000 Received: from MWHPR1001MB2158.namprd10.prod.outlook.com ([fe80::fde7:fb92:8ea1:a5ac]) by MWHPR1001MB2158.namprd10.prod.outlook.com ([fe80::fde7:fb92:8ea1:a5ac%4]) with mapi id 15.20.7159.013; Mon, 8 Jan 2024 00:46:54 +0000 Message-ID: Date: Sun, 7 Jan 2024 16:46:53 -0800 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH,V4 10/14] gas: synthesize CFI for hand-written asm Content-Language: en-US To: Jan Beulich , Nick Clifton Cc: binutils@sourceware.org References: <20240103071526.3846985-1-indu.bhagat@oracle.com> <20240103071526.3846985-11-indu.bhagat@oracle.com> <0ecd9240-0700-4072-91d4-ccf9bdb56071@suse.com> From: Indu Bhagat In-Reply-To: <0ecd9240-0700-4072-91d4-ccf9bdb56071@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: MW4PR04CA0222.namprd04.prod.outlook.com (2603:10b6:303:87::17) To MWHPR1001MB2158.namprd10.prod.outlook.com (2603:10b6:301:2d::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWHPR1001MB2158:EE_|SJ0PR10MB4592:EE_ X-MS-Office365-Filtering-Correlation-Id: a757c301-f3b6-4459-ca94-08dc0fe34f69 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 47GdcMFeu4mp4XaJEt5GjWz5bnxC5cZAuPhBNyrmgredpLGWbMSupwbOgVxK/PZh18ThTFUKTCr8blvXak4ThnMD8/4wO61KB6iWpy+9lVE9mqwIbtrLWEdKOZhtxB2mzylYHrnCH+eeNgtXqSV1Z260TofZO5iYBto5TFaigpveYojeEuBp5Bi2t84aLtjLJMlufbyeNGieBr2MvVYRANXYrXciRa6GZeQg/osmWDTza28uf/rNXhucNxslGBDXNfRam+I8T4xVIxs2yzVVuHOLWuzWntD4T4sZgUsTf+WSxU12Ux0H2t1XDjJRMzao5iH4jOs7R14XXTSFpu2L8LTXtbmGLgmt9h4AFxIh4Pvj2aKSJHqQQBWVOECGkGe5TKBeEQojA9QFJ5W3wi4lXYYKE+vRXCGOtm2WSu1gGsirzZ7kVH5imN76e+8mWDVBQeXAeWVruzTAiwIH0aZ6k4QVr6v8FCuoawzzeWLylcWBZZr/WjCFGdEVNm9tSh6bJb59gLk0Yk4jvIpC/SR/TQ21h9b8DZCa78AQ1lVLO8WkbYGv8MyNcnAyyaH9Jxxw9Uwkwyp+EckZMDYrRRsgaOOw0YeRSWt/AhV+aIwNWHnYRZUIx7af3DsJMP1qXgEp6JrNgXwsoa+llfPFM0N5tg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR1001MB2158.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(136003)(39860400002)(346002)(396003)(376002)(366004)(230922051799003)(64100799003)(186009)(1800799012)(451199024)(110136005)(316002)(31686004)(6486002)(4326008)(38100700002)(66556008)(66946007)(66476007)(53546011)(8676002)(6506007)(6512007)(8936002)(2616005)(44832011)(478600001)(5660300002)(2906002)(66899024)(36756003)(41300700001)(31696002)(86362001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QTNCakt5a1dkVUlYR3NuVFJTd201OE9YSEhmYlo0VGpSb3FMSjhZWDFuT05r?= =?utf-8?B?eU5MVlpnZ2s4TU9sS1JpK2czTFUvcWxXbTlxWUtIZlF0TjE4clZyTHg0Zktw?= =?utf-8?B?QSt3Z09SMHAzak16TGo5ZFZzTitMRTAzclMxemtKK0RPZzRvZzJOWEFFK09l?= =?utf-8?B?QzNKQVhEVFJrZllkZG56dGQ5WDRsWS80VDN5SGRRSHltMEhYVm9raEVPQUl3?= =?utf-8?B?N3ZxaUw2b1lGZ1Y1RGhxeGdtWWg1VEFQeUtlVTJQSG8xNzV1OWk0K3p3UWVi?= =?utf-8?B?V0xkWndtSERWdTVpWW9lb1RON1EzaGNLOE5RWEV2OUJYcWFnajBhNmdLR0pF?= =?utf-8?B?eFgzT3M3dVFNaTI5SXpzK3hwbThnNmVBWnhYWUVKWUlxcjVUcFZBUTlqT29o?= =?utf-8?B?RHpBUEpYY3BWT3UzUnpQWit3NlJsdG9rWkVnV28ybnlnbGZudUh3bTRJZ21R?= =?utf-8?B?aHJHYTE4VjJsMEpaM0szRVQ3ZXA4anVHY2doN0I5cEs1MTU4bE1aSlZYbmZO?= =?utf-8?B?eW4wVEtjVjJGeGJVOS9maS9XWDd2SjVUc09ER1FienB5ZFFVWkZsbXZ4bjRR?= =?utf-8?B?SlJEOGlmdGd5aXBsNnhZUHFTRE1yTy9jcWxiUHRxWWRmaU1PanVXWWR4OFc4?= =?utf-8?B?OWdPSnlFU093M1lRVDlQSnRsZWdseHF5Qk0vbGR5Y0U5dG9iRWpDZ3d3R3I2?= =?utf-8?B?TTRadGVpWFowMzJjTlVwQjNJeDJlZE9LaGsxQlV6YWpsOVpqTFNWWnk0U1Ru?= =?utf-8?B?ajZwNmc1ek9EbXZRdTJONzZ5ZlRtdUZwMkcxT1I3aHAxR3Zrakk1cjJhRVdo?= =?utf-8?B?c1JKcHREOU5LZEdnbTRzVGd1NTlYWG12OUU0RGt4bWJQSUNzNUNVTEFxakpS?= =?utf-8?B?OElBRTA2Z29TQ2FsNVp5T1JGVExPYmIvRXVmVllveG9ZVkVhcldiRXZnZXRo?= =?utf-8?B?c2VOYnVWUnJ2YUZaZ3pyNkVvZFFsRkFNSHFXSWdMSkIzeisreW5NNnpDSEpE?= =?utf-8?B?UGgvbFM5cytXNWdVY0dzbEpRWXNyWmlCZ0FJejlOQXhsUGNpbXU4RUIzYzdz?= =?utf-8?B?Nmd4Y3d5VlFURWZ6ZlJFVFg3NGNVSEVxTWdLV3lQUUlacVpQd05YMU5yWUxG?= =?utf-8?B?ZWRoNTA4bktwaEJjcXpDa2pEUkU4M043N1ZIdmxrSnUrV2hOUzNOQVlKTWJK?= =?utf-8?B?WGNYcHZQSU00VEFheU1DLzREd2ZQUkdGREx6ajhFd1hvRnZvY1Z1K3NHb2FV?= =?utf-8?B?UkYrM3lHS2k1L3JTbmJITWxFNEMwb1Z5VW1NSnZBWG4wM2V4Qk1wUUhaT1FJ?= =?utf-8?B?SWxVaGtZSXdoTy9UWENXZEUzUlpqYkhJcVpZNWd5V0V3MWN0NUVTMktPT2pH?= =?utf-8?B?bVpOcmh5SGVwWGN2dVVVZFRjUnFScGx5cU5POGR5RXlwcHVuSVlBZHI1a1hr?= =?utf-8?B?WG9yN0FPcWJiTGYrL2dyUlZxZUpDZEZGVXVMSmM1YjdQV2xBWThsTUhLQWhj?= =?utf-8?B?RllnaVZ0dk5VT0RicVJrN3Rnck9tSWhpdWV5cFZTWTlodGVTUEw3MEY1MXVJ?= =?utf-8?B?ZWU0aWRGTElNcWJ1YzJJN3JIY0VNZW5KbWtPRnJDWTMvUWlZVDhTbzgzVG9x?= =?utf-8?B?ODU3SWNYYWtNQTJ0dFM2RjZGRU1oMWpvd04wMTV2SnF4OXR5SjNzS0luOHF3?= =?utf-8?B?V0J1ZWQzMnRDSEF4MG5rRVljL2JoM0E1RDRDbFo1cTFJbUJXWitmQjduaEwy?= =?utf-8?B?QnpyMnBxMTNOckdpckZnWVhUQU9wdUpYZG1DNERuR1FxTWdrYWg3RUdiTlBU?= =?utf-8?B?amhIcm1PNVQyQUcrVnBEaHBGUFFXZFJ5c0tGOGRsZ2lTaDJmRHBIcnVGMm5K?= =?utf-8?B?TWpvZGFZTnkrN2tvTi90VitSZ2RVcGp3WGRkOUlRWmVEazNublFrcGlEVVBo?= =?utf-8?B?eTVTbEJOYkNXL1l0TExwYVkvbGpmZU5IQTdMcUlrWDJ6NEZMQTJkb2JaOGtF?= =?utf-8?B?T1I2andJTUNHL2kyRXR5ME13RlFRaXlUVk9FamxUQXpLYzFYUXNJaGhQS09q?= =?utf-8?B?NTJiNzBzQThmL2R6RXllbllsckl1OGRBeEtidnlGM0tNNXNqaXZFeVMvMlRm?= =?utf-8?B?RWVaWUF4S01YTytBT2RZeE1BN3dzYVBocHpUODlhaDlEV0RGQ21oMEJoQnFH?= =?utf-8?Q?i6eN4UPWgYgazezFlQJ7Mrk=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: VTjIYPJpydbBI1n8JqURfe47c5RMlmAFnlOnv6fCfhxqFHoE9zCEINkK9nrFrLGVBpvta3fpU0w7U6EcdpCGShr75bC2Zjo+mT4g1aGkVNMqM+WPPEoaEmJLGUBiI3PdkvyNDn8U8DlKZhKgtlPpkWKMaO2/QIb/j/zZg3cDjm2C/JN3Rs9cgYLe6rTR/jFR/ofIRoCw22mNcRRFCTBRmnZegTYDobUwZeq2dRK8pqTX6pnfFPuMADXTmR4vkksedM315k7hWfkERY+uGdjc16VRBmR0gPf8peTv8v25Xsdp1ZvKe8BhVZNCHorjamMMpZSCbkukyaagk2vXlQgNico1MvRzOdrqTyi8HE9674kXanCcghGde4Va6Ch8dpbbZo+xiAz9+5uLTtGNxELhs+CQ2+LrlLE4xGcNuPn+6dn96UTmZ25bXBMjhgOdNCWgjobJVpyOJA484EILiJjMcQMiI/It8X6/vz9sYzN8tBZKg69Z/thEFJP/YK2C4gGdVYjlAHG/JPikxbyip5VALlzet85I7Mdh319MMP3zCkJuqgJjwWTzkqoS+4dKgX3bIN8PZ/SV6ayMGlLTuBLlG6cajcMpCNu9o5R7psSStR4= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: a757c301-f3b6-4459-ca94-08dc0fe34f69 X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2158.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Jan 2024 00:46:54.5509 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: E1E8sPOWt3TnzSy5EGRVZ/uAYQrdIUww9GBb6771W1Drv0MyfmoiCZdHANSgU1hVkyUJ1vhO9GkS0IKBa3GrWQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR10MB4592 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-01-07_15,2024-01-05_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=849 phishscore=0 mlxscore=0 spamscore=0 adultscore=0 malwarescore=0 suspectscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000 definitions=main-2401080002 X-Proofpoint-GUID: 39rY_jTkvwAlI4brpkasn_okIIatP0s1 X-Proofpoint-ORIG-GUID: 39rY_jTkvwAlI4brpkasn_okIIatP0s1 X-Spam-Status: No, score=-7.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Jan, Nick, I am working on addressing the review comments in V4 and will continue that review in a separate thread. Meanwhile... On 1/5/24 05:58, Jan Beulich wrote: >> + dwarf_reg = ginsn_dw2_regnum (temp); >> + } >> + >> + gas_assert (dwarf_reg != Dw2Inval); /* Needs to be addressed. */ > Without actually addressing this (and possible similar cases elsewhere), I > don't think this can go in as other than experimental code (which the > NEWS entry then should state, and where there then should be a plan for an > easy approach of probing gas for no-longer-experimental SCFI support). ... in this specific case, the /* Needs to be addressed. */ comment is somewhat stale and may have lead the impression that this is an unhandled case (EIP is the pending unhandled case, I will deal with it in V5). Moving forward, I would like to get consensus on whats the way forward for SCFI series, especially whether there is agreement on releasing what will be the V5 with binutils 2.42. My take on "SCFI should go as experimental code" : my priority is to get this option to users and to continue development of SCFI incrementally with the help/reviews from community. If the reviewers/maintainers think, offering this first as --scfi=experimental, which later is established as --scfi=all, in a future release is the best way to move forward, I can make the necessary changes now. But I will appreciate if there is consensus on this plan before I undertake those changes and send a V5 aiming for the upcoming 2.42. Thanks Indu