From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on2046.outbound.protection.outlook.com [40.107.6.46]) by sourceware.org (Postfix) with ESMTPS id 7EB673858D20 for ; Tue, 31 Oct 2023 08:03:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7EB673858D20 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 7EB673858D20 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=40.107.6.46 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1698739420; cv=pass; b=fAGg4GYgTU2u/NnpHa3GDAdGTa1L0mEj7aRx/NhmQDNv2OUbYgYN3L7a1MG4Ib6hanorl+gyr4HHyOLp9vXGqNC1wuieb+Ma5hA9ppRxXNRySdZiSZlHOkRgK4FH7NTEJJ0iZ/Yw1a4Nbhr7nvVUWz3gGVKrY/uS6Z5ZtzdVAL0= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1698739420; c=relaxed/simple; bh=Hcn3fQ0TszuPpMV0W8PIA5u6R26TLY8dONGt+lsIrxU=; h=DKIM-Signature:Message-ID:Date:Subject:To:From:MIME-Version; b=afU5Xwml+LHG/NbadCC9+jS9NZ0BNL9yojGiLYj3lIbytRb13FIy4iCEphixOiNxmTUTQ5GeYIvBgy2K8fj/T6lk7QCp+q9PB9NkpmNYHlMC9qqr09NZZ2w+Q/CCKmc2VDAIXpYNPeMedHI9K0ptLRip1Npw6Uhz51t1sJbMyWs= ARC-Authentication-Results: i=2; server2.sourceware.org ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OV4cj2cjDw8yDl8+kRhD/yaU5jsVv2kqBQQXBjJo6Sf/HmskkKD/jp6c0lHtDJfja9dKmH4cJ2luQbVAJ8ZSbxQNc5B6KaxKkvarXg3nhoprecYwFxS8o8+cQAJP/aRPBYjL9GOJDCTcIzw71XeYcg0knGKDS8BTj1BNtM4d1Dmtumaj/i/iqKGjUzoLijL4Ymgt7jcONbUD0ksm/gU6yLhftTgJYYHz2/Rm1yrCKw6p4xTlcXuoIv8d98voV6EkA6nvVT1FZgINEZ9Cs4oU1IiqOKeWeVyLNeHcwtgmD3HKamHoJfsJlidRbmje640UYxQIY606RvX6fonOCKZsmA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rH6MH7AaoDOrznPNEZw8C31lkqs7g/IBLkKO0tRhuDA=; b=JqBc81hOFswn0jlwR3sjvvPciJc8RWlnU/bKquZBa2F3g0beDufLSaaUpEtJupXNrtWkwz56jwXbbObHOgceNozCUQsbSyJAkQOTp8qoSRpQ2bfy97q6DjUmVJeg1S5DZS38P/mkpwx92wHreYCQ55JigHxjxWhO/7Bzk6N8ULTuoeEM7MtYzw26we1sU7jfsPZl+Cjmt+kJkoMdjMoBWDYA94uTSYIyVOKiVdHz2eIyRFruNuJi34zxOJr+reqieC513ltaM4/eOb4TXYbP+SeixVMQUuYXJrnUlGJppoH7texs3+WcM9XWpMLolsuk7DbmJflCnvJuCaid9sLgyA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rH6MH7AaoDOrznPNEZw8C31lkqs7g/IBLkKO0tRhuDA=; b=G7BM4kvNrwUJ3At7uy+xpDlm7xgTlwS0QV25x2v/P/4mmBSNO+S7J+n+a+L4lHGOb3SQ2WBqxktFDBxWd9WsmMycEsXCkUFlExQzbIsxGAEqhIoT2VMNT/AbngiaNu9+vGVb92a5UYZWyhgBGmdUURARhMy3UL4f55Jv8/g8SfS9A23xACRHNIqXK/NFhQpT3gMopuV7SzpRXCnB4A3CbEBHm/mdWsn4dYByVS5Hia9oFwvq5/2a6tsyaad22ebtoFl0tPclqRgM8p7JkT87IMLcoPrkcUpL7KvMOE+LaF6LxlVFkfuQMrQkYD3wZ9wywlX8Jyhq3978+agxMNSvUA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by AS8PR04MB9046.eurprd04.prod.outlook.com (2603:10a6:20b:441::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6954.16; Tue, 31 Oct 2023 08:03:32 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::d924:b650:a2ad:7b25]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::d924:b650:a2ad:7b25%3]) with mapi id 15.20.6954.016; Tue, 31 Oct 2023 08:03:32 +0000 Message-ID: Date: Tue, 31 Oct 2023 09:03:30 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH][v6] Support Intel USER_MSR Content-Language: en-US To: "Hu, Lin1" Cc: hongjiu.lu@intel.com, binutils@sourceware.org References: <260c522e-dbb0-7e40-1419-5bb269fef823@suse.com> <20231031021410.1543517-1-lin1.hu@intel.com> From: Jan Beulich In-Reply-To: <20231031021410.1543517-1-lin1.hu@intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR4P281CA0127.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:b9::11) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|AS8PR04MB9046:EE_ X-MS-Office365-Filtering-Correlation-Id: b41dc16b-b1f5-447f-d2f6-08dbd9e7e036 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: E9OTMZkbAZKo5RJJ+2vd64dhjR6D3LjPBV3FDTUEg7iP2Tf0T47d0spL2WMjI7FnM1IQQPZA6ecyGsSluciqsIeUftI96jIJ2swJKI6EeATWp18IFIzUfLHilYV8yA5+pDmoVVt9urF4OhoyNpk3mt1a9XWAErGwheJKcZggjYBMu/VX8eZgp9EAf2gSKxJMggRv6qUxV5U6KKdsDiyym6ScMoXIass5/hwQV03HiQ9SxYX7w31krx/AoRddiHtSPdKj63EyAkjeNEgCkHjWdL7nge4lWPwdX+nyUg4gQXBrEPRy+K69bptQC0n1aXKj4bZuCCY5l71eDil38XrJ5wJxTujKtgPiR1Oqky8crbyfE8NjUkmvfar/MA91sqhy7OnmRiXP9+GFUgNcXPSjgsoc5WfyhzKlJ+mrnqkcj7HvrUD5sr0tVOp5SFEXNW3Z+R89lAouO4NtlKoqXIWeDk1/LoKhco8Ft6Cb/TIfFUR5roPqJCArZv0GXFi/eEGLMkesEB5E3k+jxYg/AoJsGn02P5LlHaKafcQGLUTLJDRb2L8nzYf/ihRuqJGjZCJ+sBEOffmqlYzhavOCb3EF4I0c7JHdDj+9WA2grODRjQj48Vfoxj/IkNbGB3UxmpyVgB1HLnje9Fo36791ZWvIHQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(39860400002)(346002)(136003)(396003)(366004)(376002)(230922051799003)(1800799009)(64100799003)(186009)(451199024)(83380400001)(86362001)(26005)(2616005)(6506007)(53546011)(6512007)(31686004)(38100700002)(31696002)(36756003)(6486002)(478600001)(2906002)(66946007)(66476007)(6916009)(316002)(66556008)(8936002)(4326008)(8676002)(41300700001)(5660300002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?R204TGw0cGNZamplUnRMckZ5ZEZnMW5aSm85UnhSZS8vZk9mY2ZPZXlObVBy?= =?utf-8?B?V2NhRXo4WHJWZkdkTW1rMUQ3U1ZXS3BCVzVma2h0Ry9uTFd2QXhTSGE4SlZ6?= =?utf-8?B?OWIrTGVZWE9YaUtqenBFWWtGaG5sNDV3dGpGZHpWZ0RBbEUxRzZoejBabnU0?= =?utf-8?B?VWJkTHZpRllmayt2R0lwcEVFOTZ3bkxmTWhFTW8wNEU4cWt6OWp5WHY5c1NX?= =?utf-8?B?b3dKcC9YeXNSN2hiVHVsUlNBL3RrWk43aWcxc3NWNmZTMnc0LzJvYlNzU3pO?= =?utf-8?B?Y2FXZkdUckJmb2lFYjJCWjhyS00wTEpyU1hNR0pzQmY5cG5nNlN5T081MkRO?= =?utf-8?B?WjVaWCtUcFNqWW9GMGp2amhKVUQySHJLNHlOKy9qeGdxZVhqczZPNlA5blRh?= =?utf-8?B?dUlHSnhDT0RkRFRDR05NeXRlWHJDbnJlMTdXbzgzaWRhVWRudXgzdmFDSFM3?= =?utf-8?B?MmYyT1dORWRLeXY5R0ovQ203QTVzV0JRK05Zb0xhbEladlU5Ujdway9OSUtR?= =?utf-8?B?TERkb0NXakhtUlFvRlZ5ZjVTTDk3M1J1T2FFWHFzeXRKUy82dTFoMm0zMFlL?= =?utf-8?B?UW5oMnM2UHR5dFpyL1pUTlN4YitiTEtOb2ZwQ3ZKS2h0bG96UWhiTDR3UTBX?= =?utf-8?B?cDhxQ3RPQ3BHeEtWMGhXRkwrNFpxMS9FTE0xUDRpeUNuWWNXeGgrZWJLdU9Q?= =?utf-8?B?RjFoL01YdDdZMFNnR1pLQVZBU1Z5MkFOTTdMeStlZzZwVENQU1F2S3dLS2NI?= =?utf-8?B?RW1ZOG5jb3h2VzJVWit4WUpVUVBvVmZBR2hBN2hWbkNNU00wb0pHdXBvdlUy?= =?utf-8?B?aXZXSWl0elFjUWNaN1pOUWQwa1RpTkhld3BsMmFjcG5jdFd6OGtRTlRkT0Qv?= =?utf-8?B?ak8wV0xWTFY4YUE4VlN6WjVOM1pKTW9WWXpSbjNRMDNNUjF4Q3Q1WHA0Sm84?= =?utf-8?B?bEJDK21XZHM1NitETlU4a0dRNUxabmxKWE0rcGI3Y3hObWhMc1IzMG5zNEFn?= =?utf-8?B?LzVXa2d0Ylg1OGJpa2h6NHd6c0FsTjBFUndlYVVqQUNSNTJQaEUzbEZ3QWUz?= =?utf-8?B?RkRRdjdtUzRpUEpmc2lnS1QxekY2T0Z6THhaSk1LakVTemxyTHZXc1I0S2l2?= =?utf-8?B?STdHaFVFdTJSRWRBdHVMcVJDM0NLYWNQaU8yY09hRmpnc2Rhb0dDZitBZm9Z?= =?utf-8?B?SzdwZG5yeWRIOGRLNlQ4U21acVRTcm9mYlNJQXNqUGM3V24zaGlhanA4NXoz?= =?utf-8?B?ZWxDc1AxNjhyNDN1cXhZQVB6QVVjWjl1K0JBcHZXTFkzZVFPdDJNbFVlcXE1?= =?utf-8?B?c1llSDM1YnZGb1RCMFNSeVRIZU93N283UkdDN1dJaHhnZ0hoRjFiQ1htazFE?= =?utf-8?B?amdwYkdGako3TWJLTUVhZDR2Y21FN1lhVmxYbllQMXZ3NTZDbDVKSkNJT2Ez?= =?utf-8?B?dUZxNVhxTDBjUHRsODlQTzYrTHc2Z1NEWlQ4ckttVGhnMXBIWDZvWDRBRm5S?= =?utf-8?B?c1M1TG96V1d6dTlvTVNRREJiajl0aU1aV3VDUTJNOENITTRjdXNMUmo1WXg5?= =?utf-8?B?WDAzZHhjYzk2bGoyWDNoZUVuSXJmYUJsWGp4ZHM1emxOZlNRb0VQNTYveXkz?= =?utf-8?B?aTJFL2Evb09USTUwcVVCUWlEeTBkMS9mSjEzZm9COTNmOTJ2Q0VPWXNmS1Zx?= =?utf-8?B?OVJkSTNtdFg1WC9QQ2lOaVROSysycUtYa2daM0xSZ3A3VitIcENnQVZreVVv?= =?utf-8?B?Q2M2NjVhcXZSZHZnVk1tSWR3Z2R2NUorbUc3WmcvNmtLejV3TjV4WlhQTDZo?= =?utf-8?B?cVlEblV3SDI0WW9iVlFOQlFsWlI0NE1Fb09NQ0Q2ZFg3WjhDT1hFcGFwV3h6?= =?utf-8?B?WUdCS3NxUTgwQlgzMVpTQThNMEYxd3JWcGJqczNtSHhoaGpqYk5vbllJYzhx?= =?utf-8?B?VElKZ3BLMS9LK1lvMlUra202dHRQVXZoWGNMaUZKRmM4RzZQOTVWVVFpYjFs?= =?utf-8?B?Q1lHVzZwR1MxS0ljVUtyTzYwNW5WaU9VdEZyYUJIODdRcmxXSEU2bkxtRFMw?= =?utf-8?B?Y09ZZDQrdGkzQmlRY0d4MnFXU0FLVWxha0FWNXV5UVJ3RmZkZ0ZiZ0pSTnYz?= =?utf-8?Q?3h5wMwLH7TBthAzkqfIWFyhC8?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: b41dc16b-b1f5-447f-d2f6-08dbd9e7e036 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Oct 2023 08:03:32.6400 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: IuSbdGv2MZ/Nj5q+rK8e1zAinYRMhsbhtCyhbBNMV5I3w0Xg3Itk4MrhFdmJdr6+pILjStP/FG6rv2FQQZxQ2Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB9046 X-Spam-Status: No, score=-3028.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 31.10.2023 03:14, Hu, Lin1 wrote: > This is the current version. > > BRs, > Lin > > gas/ChangeLog: > > * NEWS: Support Intel USER_MSR. > * config/tc-i386.c (smallest_imm_type): Reject imm32 in 64bit > mode. > (build_vex_prefix): Add VEXMAP7. > (md_assemble): Handling the imm32 of USER_MSR. > (match_template): Handling the unusual immediate. > * doc/c-i386.texi: Document .user_msr. > * testsuite/gas/i386/i386.exp: Run USER_MSR tests. > * testsuite/gas/i386/x86-64.exp: Ditto. > * testsuite/gas/i386/user_msr-inval.l: New test. > * testsuite/gas/i386/user_msr-inval.s: Ditto. > * testsuite/gas/i386/x86-64-user_msr-intel.d: Ditto. > * testsuite/gas/i386/x86-64-user_msr-inval.l: New test. > * testsuite/gas/i386/x86-64-user_msr-inval.s: New test. > * testsuite/gas/i386/x86-64-user_msr.d: Ditto. > * testsuite/gas/i386/x86-64-user_msr.s: Ditto. > > opcodes/ChangeLog: > * i386-dis.c (struct instr_info): Add a new attribute > has_skipped_modrm. > (Gq): New. > (Rq): Ditto. > (q_mm_mode): Ditto. > (Nq): Change mode from q_mode to q_mm_mode. > (VEX_LEN_TABLE): > (get_valid_dis386): Add VEX_MAP7 in VEX prefix. > and handle the map7_f8 for save space. > (OP_Skip_MODRM): Set has_skipped_modrm. > (OP_E): Skip codep++ when has skipped modrm byte. > (OP_R): Support q_mode and q_mm_mode. > (REG_VEX_MAP7_F8_L_0_W_0): New. > (PREFIX_VEX_MAP7_F8_L_0_W_0_R_0_X86_64): Ditto. > (X86_64_VEX_MAP7_F8_L_0_W_0_R_0): Ditto. > (VEX_LEN_MAP7_F8): Ditto. > (VEX_W_MAP7_F8_L_0): Ditto. > (MOD_0F38F8): Ditto. > (PREFIX_0F38F8_M_0): Ditto. > (PREFIX_0F38F8_M_1_X86_64): Ditto. > (X86_64_0F38F8_M_1): Ditto. > (PREFIX_0F38F8): Remove. > (prefix_table): Add PREFIX_0F38F8_M_1_X86_64. > Remove PREFIX_0F38F8. > (reg_table): Add REG_VEX_MAP7_F8_L_0_W_0, > PREFIX_VEX_MAP7_F8_L_0_W_0_R_0_X86_64. > (x86_64_table): Add X86_64_0F38F8_PREFIX_3_M_1, > X86_64_VEX_MAP7_F8_L_0_W_0_R_0 and X86_64_0F38F8_M_1. > (vex_table): Add VEX_MAP7. > (vex_len_table): Add VEX_LEN_MAP7_F8, > VEX_W_MAP7_F8_L_0. > (mod_table): New entry for USER_MSR and > add MOD_0F38F8. > * i386-gen.c (cpu_flag_init): Add CPU_USER_MSR_FLAGS and > CPU_ANY_USER_MSR_FLAGS. Add add VEXMAP7. > * i386-init.h: Regenerated. > * i386-mnem.h: Ditto. > * i386-opc.h (SPACE_VEXMAP7): New. > (CPU_USER_MSR_FLAGS): Ditoo. > (CPU_ANY_USER_MSR_FLAGS): Ditto. > (i386_cpu_flags): Add cpuuser_msr. > * i386-opc.tbl: Add USER_MSR instructions. > * i386-tbl.h: Regenerated. Okay. Going forward though please make sure that patches have a useful description (beyond the ChangeLog entries). Jan