From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.111.102]) by sourceware.org (Postfix) with ESMTPS id B05283858D35 for ; Tue, 4 Jan 2022 08:49:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B05283858D35 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05lp2109.outbound.protection.outlook.com [104.47.18.109]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-30-932f7b71PXeLdLQjGp-bQA-1; Tue, 04 Jan 2022 09:49:02 +0100 X-MC-Unique: 932f7b71PXeLdLQjGp-bQA-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ri8/1rL2dP61SCBMEv9P0bgnMor79y52IuYOCSzph5Dt3LgcG0hPVRtviCjbVobFiUpBOmQVzIyT+mKAl5wagpsnOr4EvN4lj/cm9b15G4ne+jbQRAra/i03HMTpzIhY5bQeoIK5i9gvxzYDKFoY60zfaOYWAxBZ+7JEBAHBnFdyx5vw6q33eclT3YKzSzjTYYbcjC1FNkrjix1muSI2u/qjDdx7V/4qVNGjY7XncvO6PhcMLP7IPHRGYtUaqk6rpXzJgs2nble8CNDRWQcJ6iJvPPgQGBrzqCVn42OsIg9fSBy8YhK+dOZOdJrfDb6SQ+2HnXQtbyaxdGdWeGii7Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=A6RzCgj6dnczyd5YpOMabAqwVeceZGP4iaABjltIKEw=; b=ZNvxCnPB1ZJX6BjfSiXGjNm8Ft0et+U97+gQzlFzpIbwQ8wok+rAg99jhi9EiezLfikYQINEqoGCMvqby7mH90o9QP1th5pug4hAzYk30cmfoiJoxUpHRxCQ01KxgOS1lbJAus/YXmXpTdfcj5X8e3gPwkMd7Oh/h/dvYiAVvkkgp8VnhYedHu9HXIm2imqtTa5fEr0joqmezr2XRhsP3J6Cb7/AFHVcNqxFrYv5Q3P8w/m+MBASHXpU9dHiBf11OqPB8xWuZx3nPNnTt0BRfq29vDlsipIz39M4C66kOOSP+14+Bvy17Md+f2Cq2gjGXU8XWWgsv31EgyjbBzWgbw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VI1PR0402MB3391.eurprd04.prod.outlook.com (2603:10a6:803:3::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4844.14; Tue, 4 Jan 2022 08:49:00 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4844.016; Tue, 4 Jan 2022 08:49:00 +0000 Message-ID: Date: Tue, 4 Jan 2022 09:49:08 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.4.1 Subject: Re: [PATCH v4 2/3] RISC-V: Scalar crypto instructions and operand set Content-Language: en-US To: =?UTF-8?B?6ZmI5ZiJ54Kc?= CC: kito.cheng@sifive.com, nelson.chu@sifive.com, jimw@sifive.com, philipp.tomsich@vrull.eu, mjos@pqshield.com, ben.marshall@pqshield.com, cmuellner@ventanamicro.com, palmer@dabbelt.com, andrew@sifive.com, lazyparser@gmail.com, siyu@isrc.iscas.ac.cn, schwab@linux-m68k.org, binutils@sourceware.org References: <20211115030343.276103-1-jiawei@iscas.ac.cn> <20211115030343.276103-3-jiawei@iscas.ac.cn> <8b80997e-9bc8-2425-dd2d-dc7bd9e28b0a@suse.com> <3fabe6df.10ef.17e243dcae6.Coremail.jiawei@iscas.ac.cn> From: Jan Beulich In-Reply-To: <3fabe6df.10ef.17e243dcae6.Coremail.jiawei@iscas.ac.cn> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AM6P192CA0081.EURP192.PROD.OUTLOOK.COM (2603:10a6:209:8d::22) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 54697031-234c-47b5-4d25-08d9cf5f0da3 X-MS-TrafficTypeDiagnostic: VI1PR0402MB3391:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:1284; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: hx9RRgDKkV+sdO8rwYR1/LW7N4hH4TVIRAMtqNTvuy4SyWsegTpy128davdSWg49gmJfswlymDYXVdoA9rJ9LEqtxwCqHgevivyFAQLMULc90wcXjDaQyEsBfqCQyTVH/BkaWo+uZuk5BtsBgW256V9S/goTs4iaOps9E9CfovcjoF3uDuXRuClE8dM0gdwo2X2ztBzSNn/6uT6wo0NFaLQ+8uKF70ev6RGbUbL24CN8Uee1PSSy4XZocq/XBMelZelsPSgdf0XsfZL7x6xRD10LFZIkKazbkIKgJsit8rHARvWibL4WuafbZLOpbb7CvLG0f2v6/UWNSNQBI8ykDnrxr5hn8a0zCCe5U9bs2fcWBvzxE8grOE4dK18LMm5TJ/1HvAcZi0wqYg1oE3ZT75f/VjIS/dFd9Gt9XZL/ERPruUKnp1O8E4gOtm5kakbCrJCNMHb2y0YPY1vGp3WGngK4VSmosbZeTQ5PGxStCcOuwcX9/V66TrZks7F6Ij4SkgNEPc1j0HhdNUCz0JXeU+vrnQyr+VNSrxCYyLDc2aVMWCqJ/a94lwMFfgVL1xRM9o3iCWAn8Onmc4ntppHuPY9bB/UIl1DASf5oCvCBi741rmkXo2nQdCRvovMG9PjpsaR3ExggBSSFsPcRpoHl5XnnHFqvGIsMTeG3KieTBwGVpPc8LpJkoOQXAuTrC+9g+NAJKbZxw0F8eZi/tavJHfsheSLxs4lPwy+YzidOOI4= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR04MB5600.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(7416002)(38100700002)(2616005)(66946007)(8676002)(31686004)(186003)(66476007)(508600001)(5660300002)(53546011)(36756003)(4326008)(6512007)(2906002)(66556008)(26005)(6486002)(6506007)(8936002)(31696002)(86362001)(316002)(6916009)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?5BA8P57+MSRlswGPUcFBq065GQv0O7q9Ba30LN53fFzap0+RpgvpYSaH1HuY?= =?us-ascii?Q?5kowyMCrpi2Wb34t/0FKZfoY8O252tiqV+NprkZ7/onCfPcGQYBE+GHFpvZ+?= =?us-ascii?Q?DFzh5YkE6d/z2L0iHYjEWZF+dWv8Lt1RkIZ5whyco7tAytmUg3iyQREvx1WU?= =?us-ascii?Q?2O6PbVLbu89xZpHM04vZWdycJs3l1Pl0W8v4FgO5Oi5OwYo8S0Po8gZkpCT+?= =?us-ascii?Q?9yL9mzKYCfqV2RAMsE7Ai1jNF9wy5uvnU3p1IPdL0yXds2P9604rDtAROnxJ?= =?us-ascii?Q?6m0tMrwx2afKPhV1NEELNoZe+//9QihgdfNz9HnCHWhMz93bpvXvN3s3XJwd?= =?us-ascii?Q?7CC5PRUHvl+ufGpustSR1Xa5RFpz93ZU+h78a9wcInMM9lMksFlsZTl+bDG7?= =?us-ascii?Q?rZIS+WlnrC+SjAl7At8HykOnnNXI0HETOhFFb1F7Q3oQ7acKHhc9g+yx0nOA?= =?us-ascii?Q?KR8Qalc1zmli4Sf/EgChILbkiSK/J1xkDtnhMSEKjBRXfVpyS+enFJJmyOlq?= =?us-ascii?Q?9K2qn6yGoIsjXSKrNdlk7I6pumgfUrz/TNKV9omj2VsO7FDkv4UOugMp+UCe?= =?us-ascii?Q?NHx+MwrONoxn0Bq32gKo52bHIttzw5JDShFvxJYNrkO13R/2kG6qkeCX/7MB?= =?us-ascii?Q?oDbjWoFsAYi4Td0H/How7J0Ui9bVkEbaSZnntEjpXdiDZ3DEacixl3whyCYs?= =?us-ascii?Q?DZd7yAkpf5HCBlkk+nSPvM3rS6nw9IGaxVgz5u8gC4jJmAzsWRVLNPEtcvNi?= =?us-ascii?Q?gcFLcIdd5dPF82afHrsAOaO9XvSXpw8WHZP/AWk5tX9DeHkYiQxKYckeI1rZ?= =?us-ascii?Q?cUhM6ejf3PJ21kyJoLkgxKQ7bVWZurM+5Q0GPbseCTpzkPPs+q19szIzgb+V?= =?us-ascii?Q?AlUeniBHYeMNUR5xDOE3NFR8NIzUcCQCC5SR2oCGXpnU36sumS8bZ9XSv5v0?= =?us-ascii?Q?YizV4gRiwWnPYVaWY2OfPKSI2z3uQWF2hw1/GqM0au15Oh5EkMAB3MtnJ1Ub?= =?us-ascii?Q?A/CCdFjq23sAG8/++PXlh00zBqYgvE3UCLd5DNXznPUqVk3MKLAYvIXA57ZD?= =?us-ascii?Q?VDS8ec0gzTfV3uPPEfRIb6CTcRcgU/M2cXR4M62RiZjmWi9ZILsNlLqf9iU0?= =?us-ascii?Q?BymmX1FlrESwEMv8w9DitEUf7hND0k2l52Xdf935Psembb7hbOG56nP/lGI2?= =?us-ascii?Q?mMZNysUbqn6hS0on3UlxuhicDZ1KoaQZgAcw49+92cPkxtLcOSjOaQSgGb82?= =?us-ascii?Q?1AY+nRhhlklPj+oPoznV8BtKmzvWesGvNKCetQXgIvbhutTUsu7ZO5EijcLf?= =?us-ascii?Q?LGH9naN1x+/ikz23yNxr4Ann3/La0kf2oGXlj2CMLZlg9R7S7ByJhk4hx+fe?= =?us-ascii?Q?Qs1LzaZxbACTC10v6Zj0muB4Ol6282nlVJ7hp2Wa9rfeShiCL3DWpVEfozYq?= =?us-ascii?Q?XT7Pp/QwgMsoEhsvJjwmbi9oSGgIQorbn5nOT3e/pyr0P8bNd2LaK3kjjB/w?= =?us-ascii?Q?nIqgkpMTHRehzoKFsmTpX7Hal3C76J/zkaOPWYJfCHxzGQJZzyNe4xyooRjy?= =?us-ascii?Q?pczswL13KdERbsOc/Tpr4pkHVfJVp5qzz2dIMCD4EX3fwu2W0PgMqGXpRAQK?= =?us-ascii?Q?w/BqlJEuuOf88xMlrPhDvWg=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 54697031-234c-47b5-4d25-08d9cf5f0da3 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jan 2022 08:49:00.8743 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ctbVYM/79M2siC4kp8tilD1oADKUJ8nbf/lL6IenhaTbIguLxnNzAIMwD5sWUH9opbJLGM7JHyQ83qN2dQLXNQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3391 X-Spam-Status: No, score=-3033.2 required=5.0 tests=BAYES_00, BODY_8BITS, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Jan 2022 08:49:06 -0000 On 04.01.2022 09:38, =E9=99=88=E5=98=89=E7=82=9C wrote: > > -----=E5=8E=9F=E5=A7=8B=E9=82=AE=E4=BB=B6----- > > =E5=8F=91=E4=BB=B6=E4=BA=BA: "Jan Beulich" > > =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2022-01-04 16:04:31 (=E6=98=9F= =E6=9C=9F=E4=BA=8C) > > =E6=94=B6=E4=BB=B6=E4=BA=BA: jiawei > > =E6=8A=84=E9=80=81: kito.cheng@sifive.com, nelson.chu@sifive.com, ji= mw@sifive.com, philipp.tomsich@vrull.eu, mjos@pqshield.com, ben.marshall@pq= shield.com, cmuellner@ventanamicro.com, palmer@dabbelt.com, andrew@sifive.c= om, lazyparser@gmail.com, siyu@isrc.iscas.ac.cn, schwab@linux-m68k.org, bin= utils@sourceware.org > > =E4=B8=BB=E9=A2=98: Re: [PATCH v4 2/3] RISC-V: Scalar crypto instruc= tions and operand set > >=20 > > On 15.11.2021 04:03, jiawei wrote: > > > @@ -847,6 +856,49 @@ const struct riscv_opcode riscv_opcodes[] = =3D > > > {"bext", 0, INSN_CLASS_ZBS, "d,s,t", MATCH_BEXT, MASK_= BEXT, match_opcode, 0 }, > > > {"bext", 0, INSN_CLASS_ZBS, "d,s,>", MATCH_BEXTI, M= ASK_BEXTI, match_opcode, INSN_ALIAS }, > > > =20 > > > +/* Zbkx instructions */ > > > +{"xperm4", 0, INSN_CLASS_ZBKX, "d,s,t", MATCH_XPERM4, MA= SK_XPERM4, match_opcode, 0 }, > > > +{"xperm8", 0, INSN_CLASS_ZBKX, "d,s,t", MATCH_XPERM8, MA= SK_XPERM8, match_opcode, 0 }, > > > + > > > +/* Zknd instructions */ > > > +{"aes32dsi", 32, INSN_CLASS_ZKND, "d,s,t,y", MATCH_AES32DSI= , MASK_AES32DSI, match_opcode, 0 }, > > > +{"aes32dsmi", 32, INSN_CLASS_ZKND, "d,s,t,y", MATCH_AES32DSM= I, MASK_AES32DSMI, match_opcode, 0 }, > >=20 > > For these two and a few more with immediate operands and a trailing = 'i' > > in the mnemonics: Shouldn't they have i-suffix-less pseudos, matchin= g > > other insns with immediate operands? > >=20 > > Jan >=20 > I think the 'i' trailing is just a dinstinguishing symbol in zknd extensi= on, there are no i-suffix-less pseudo definitions in the cryptogrpah extens= ion spec, please check it. Perhaps I should have said explicitly that this is a question not so much on the implementation, but on the spec itself. Jan