From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x330.google.com (mail-wm1-x330.google.com [IPv6:2a00:1450:4864:20::330]) by sourceware.org (Postfix) with ESMTPS id 1F6B53858424 for ; Mon, 18 Dec 2023 08:47:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1F6B53858424 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 1F6B53858424 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::330 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702889278; cv=none; b=LC0EjNccaqGEEouQt+n2/IffM/Gbe2bFEbT9oc+ZhPL2WU5BM2RndxbYyDUhAfZBmHPMgGdU4qatfiHlxqL8TElUrUcuvo8De/j2oQE1sBoiQ1ynuS895YpHxIGsUgCjXJ/QTQM+PUuppehlS5ECloSHKhRUs1TKryNkGbjoRLk= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702889278; c=relaxed/simple; bh=puoeohUFTkesXbk9e/mS/o/9EkQ5ajy8eFmlQlW8ClU=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=tEi7Kd9Zg7zucJOqsDOlmzUQS5G4dC/yW+2OvCP4meAqZngy6DB0dgE8XQOMJPR3olHwf8GCclwWfiXbh38+FveHaVKC8KMgqMwxgxMU1e0ZCOLkBV+GxEJ3qTcvQoJ0lqbOVQQo+wL2mjUxpBzovKo95ygaTQQCdyb/R2UvC0g= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-wm1-x330.google.com with SMTP id 5b1f17b1804b1-40c3f68b69aso26516495e9.1 for ; Mon, 18 Dec 2023 00:47:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1702889274; x=1703494074; darn=sourceware.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:cc:references :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=YAvcb0NzU38cZmH58JVKcKJgyb6kHv3AvxL70B7QWx0=; b=PBShCjS/5awe/RdCD/WXLdZZiGSOpdLYlunuwwD81zAUnG7dPC///qaxqcNfOuS+KO lRgNcezUw/qDr2U/2S7SLHau9bcagSK14tPVdZPWsLDB2DZx1uAclWQi4qBqxW3Ng2oW DwIlsZqm+IblMfzaup8HoFIQkZ1EUZruOfOmjhP8Ss1erbhxO/PnWVZKBsp6Pd5yYBtY Gs4m6V+3Zq01TpSeWRIbytFHDf3jxl9D9oVG1rgoJy/nrBX5tshdWu+otmDXHQuNexz3 VdlVmBfgiXfuHGj3HPh6UVKTMNfkoMb29zGeLfCl759AiRltsHpko3uQtBFQUqMFxJk2 7FoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702889274; x=1703494074; h=content-transfer-encoding:in-reply-to:autocrypt:from:cc:references :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=YAvcb0NzU38cZmH58JVKcKJgyb6kHv3AvxL70B7QWx0=; b=ivhTQMMpL8NbtEk7qckPVWrqrur9/eBycQxtJJ/GpA3cW/OmQEwozZ3cQcsDZu5f/d bXrXA7sdU9d4opmx6ZD+msU6Wdt/Na6wwGv+QnR65BZmRQ0N779ludABPDIv9IE8DO28 EWFzf0EI9RNSoZW/4VDoa6/XJv2u7qcqlnzyn/U6KPp04PLH4i/jFUL3K63FttKProZm G/1e0K7YJtQtJV4dXf4ipGvYXH+5T33H6ByPvlddf8uYENy03vFOm7GrCXJ51hXdcR29 mVYxdB0jgJLU/+5XkT/+fYJf8ZzJBzOqQS847eDWrdsWOuDvgnErP4WxVqtSmAZpTsKI d/AQ== X-Gm-Message-State: AOJu0YzFh6h/R5wODkVG/+Rq50PYSdm+JwqPysGxTnZP2VUsbZAD9Z4O TJm42g0tv2ngbu4P7VIMvu/k X-Google-Smtp-Source: AGHT+IGgf2vcLE7gYgO7+6BVRhOj7pj1tsj+5Wkt2cCvx6MDA8kkS07pk7Zw/mmF2sIkmTlauE9eJg== X-Received: by 2002:a05:600c:3b26:b0:40c:34c1:45e1 with SMTP id m38-20020a05600c3b2600b0040c34c145e1mr9126570wms.38.1702889273770; Mon, 18 Dec 2023 00:47:53 -0800 (PST) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id he15-20020a05600c540f00b0040b5517ae31sm43074584wmb.6.2023.12.18.00.47.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 18 Dec 2023 00:47:53 -0800 (PST) Message-ID: Date: Mon, 18 Dec 2023 09:47:55 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH,V3 00/13] Synthesize CFI for hand-written asm Content-Language: en-US To: Indu Bhagat References: <20231211060359.3561062-1-indu.bhagat@oracle.com> <6db8b80a-ce1f-4f5d-9c3d-02ae76235903@redhat.com> Cc: Nick Clifton , binutils@sourceware.org, "H.J. Lu" From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <6db8b80a-ce1f-4f5d-9c3d-02ae76235903@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3026.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 15.12.2023 10:13, Nick Clifton wrote: >> This patch series adds support in GAS to synthesize CFI for hand-written >> asm, acronym'd as SCFI. >> >> Previous postings: >> - RFC patch series (https://sourceware.org/pipermail/binutils/2023-September/129560.html). >> - V1 (https://sourceware.org/pipermail/binutils/2023-October/130163.html) >> - V2 (https://sourceware.org/pipermail/binutils/2023-October/130210.html) >> > The patch series looks great to me. Series approved - please apply (with a > small update to the 09 patch as already mentioned). Please can you hold off committing the x86 part(s) of this, until I got a chance to look over them again? Furthermore, as expressed before, I'm wary of these additions going stale the minute the APX patches are committed on top, if your changes went in first. Despite APX work still being in flight, I would much prefer if that went in first, and then you re-based your work on top, such that the new MOV and ALU insns are covered right away. While this is an unusual situation - new very general purpose insns aren't introduced frequently -, I'd also like to see more formally addressed the idea of ongoing support: From the original review I recall that you need to minimally track insns altering GPRs, in order to avoid silently generating bad CFI. Remember that I haven't looked at v3 yet, but as long as that tracking is based on specific insns rather than a generalized pattern, any ISA addition allowing GPRs to be altered would be at risk of rendering the CFI generator code stale. Yet people, once they've started to detect availability of this functionality, may validly expect that their use of the functionality won't silently break behind their backs. In this respect, did you consider constraining under what conditions the generator code may actually come into play (at least for the time being)? Jan