public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: Jan Beulich <jbeulich@suse.com>
To: Achim Gratz <Stromeko@nexgo.de>
Cc: binutils@sourceware.org
Subject: Re: GNU Binutils 2.40 released
Date: Mon, 16 Jan 2023 08:59:04 +0100	[thread overview]
Message-ID: <eddc9798-913c-ca7f-ca33-00e41ec6c0b9@suse.com> (raw)
In-Reply-To: <87a62j5wey.fsf@Rainer.invalid>

On 15.01.2023 22:18, Achim Gratz wrote:
> Also, it doesn't build on Cygwin (and when building the cross compilers
> to MinGW64) when enabling target x86_64-pep due to doubly defined
> symbols when linking ld-new (pep-dll-x86_64 defines the same symbols as
> pep-dll).  The following patch seems to fix that particular issue, but
> is unlikely to do the right thing when other configure options are used.
> 
> --8<---------------cut here---------------start------------->8---
> --- origsrc/binutils-2.40/ld/configure.tgt
> +++ src/binutils-2.40/ld/configure.tgt
> @@ -1051,12 +1051,12 @@
>  			;;
>  x86_64-*-cygwin)	targ_emul=i386pep ;
>  			targ_extra_emuls=i386pe
> -			targ_extra_ofiles="deffilep.o pdb.o pep-dll.o pe-dll.o"
> +			targ_extra_ofiles="deffilep.o pdb.o pe-dll.o"
>  			test "$targ" != "$host" && LIB_PATH='${tooldir}/lib/w32api'
>  			;;
>  x86_64-*-mingw*)	targ_emul=i386pep ;
>  			targ_extra_emuls=i386pe
> -			targ_extra_ofiles="deffilep.o pdb.o pep-dll.o pe-dll.o"
> +			targ_extra_ofiles="deffilep.o pdb.o pe-dll.o"
>  			;;
>  x86_64-*-gnu*)		targ_emul=elf_x86_64
>  			targ_extra_emuls="elf32_x86_64 elf_iamcu elf_i386"
> 
> --8<---------------cut here---------------end--------------->8---

There must be more to this: The logic here isn't meaningfully different
from 2.39 (only pdb.o was added). I've also checked (cross) builds of
both targets (with recent master, not 2.40), and there's no
pep-dll-x86_64.o there.

Jan

  reply	other threads:[~2023-01-16  7:59 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-14 15:32 Nick Clifton
2023-01-15  9:17 ` Xi Ruoyao
2023-01-16 10:58   ` Nick Clifton
2023-01-16 11:35   ` Nick Clifton
2023-01-15 21:18 ` Achim Gratz
2023-01-16  7:59   ` Jan Beulich [this message]
2023-01-16 12:51     ` ASSI

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=eddc9798-913c-ca7f-ca33-00e41ec6c0b9@suse.com \
    --to=jbeulich@suse.com \
    --cc=Stromeko@nexgo.de \
    --cc=binutils@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).