From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mailbox.box.xen0n.name (mail.xen0n.name [115.28.160.31]) by sourceware.org (Postfix) with ESMTPS id A8059385DC05 for ; Fri, 30 Jun 2023 09:15:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A8059385DC05 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=xen0n.name Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=xen0n.name DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=xen0n.name; s=mail; t=1688116530; bh=UiUqGZntiJ4xdE2kOo8B6GKS1JGgRkWPLRU1vuStWVQ=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=cYhIuJECR8InzTkvWP7LZVlF4ClAwhL5/3wzbrxo4rb1h4y9j0NbnbttH4cqVYH2G uwdT3dqwjDC4+vzOv8arCpfL4vhjpDRKmwEtWZhKN95GsAs3IZ+DT4rysK58U9fpQX 910dNxi/HAibWt3cCjfKCoD06UfQLyXS9cPG+KVM= Received: from [100.100.34.13] (unknown [220.248.53.61]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by mailbox.box.xen0n.name (Postfix) with ESMTPSA id 06951600BD; Fri, 30 Jun 2023 17:15:29 +0800 (CST) Message-ID: Date: Fri, 30 Jun 2023 17:15:29 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v2 0/2] LoongArch: gas: Add LVZ and LBT instructions support Content-Language: en-US To: mengqinggang , binutils@sourceware.org Cc: xuchenghua@loongson.cn, chenglulu@loongson.cn, liuzhensong@loongson.cn, xry111@xry111.site, i.swmail@xen0n.name, maskray@google.com References: <20230630090416.3051425-1-mengqinggang@loongson.cn> From: WANG Xuerui In-Reply-To: <20230630090416.3051425-1-mengqinggang@loongson.cn> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2023/6/30 17:04, mengqinggang wrote: > Changes from v1: > Add LARCH_opts.ase_lvz and LARCH_opts.ase_lbt. > > mengqinggang (2): > LoongArch: gas: Add LVZ and LBT instructions support > LoongArch: gas: Fix code style issues > > gas/config/tc-loongarch.c | 4 + > gas/testsuite/gas/loongarch/lvz-lbt.d | 191 ++ > gas/testsuite/gas/loongarch/lvz-lbt.s | 181 ++ > gas/testsuite/gas/loongarch/uleb128.d | 52 +- > include/opcode/loongarch.h | 6 + > opcodes/loongarch-dis.c | 2 + > opcodes/loongarch-opc.c | 3195 +++++++++++++------------ > 7 files changed, 2105 insertions(+), 1526 deletions(-) > create mode 100644 gas/testsuite/gas/loongarch/lvz-lbt.d > create mode 100644 gas/testsuite/gas/loongarch/lvz-lbt.s > Thanks for the patches, this now LGTM. (I have to fixup some offset operands' format strings and it's better done after these are applied.) For the record: I got off-list confirmation that the "setx86*" and "setarm*" names won't get changed this time. While reasons were not given, I believe it's probably because the "setARCH*" ops are actually markers and do not actually touch arch-specific state, while the "ARCHset*" ones do; but without the manuals available that's just a wild guess. We'll have time to revisit anyway without compatibility concerns though, so I'm fine with the decision at the moment.