From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01on2047.outbound.protection.outlook.com [40.107.15.47]) by sourceware.org (Postfix) with ESMTPS id EEC8A3857B93 for ; Wed, 27 Sep 2023 12:09:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org EEC8A3857B93 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QLDK9N6dl3bXDAvXiHU5a1U1TXojH2VHMEhuk76T4c5ZhOImsbT/Lk2/Qzq1BBtFztfbeMYBwxSs7+K+9I0RFAOXvCDdfvHmgalU3K+aYng7i7pjsvDeHiQSP5GfIc4eYeXQQOeZDmrLhN/Vv5G35DG8oxujazKDJXkcVSjq7+LzELHr+FPF0yKRAd8J7hbGTcQzrqB9+2u+H4DRP8Wwe3S6tccUlU1NxVm0/H3PhVkiIbqcakpEvhdivtK+10g3bfq9PhyrUfA1im0qACqtvhIn2Iy9mmp8l4G2e24sFOsshEA3gpuqfiyCt6ymKPRhhU68v+Krv2eppg4T5gFwBw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=P+AzXexSeytJlymzrTqCAK7eH0t1cQ7b1JU4iTBe2zc=; b=m0ZU/eytu+jsQ4lwwgr2/ygvLpPD5HNebN4tc1FPKY0FoWJD3VMCx1s99BerffsJ+QsDw1OQ/8ueBMijcP/GwL4B/YkmjGbZQAez295HmvNSkBbxZ/LsdQ7F0WnNvau50k+qfu6KzaX6ncgJChhvBY+nMjZtGGyvx2l7nsQtQ+es8B2iyfd9aJs/eaKn187tPkl9/eDFGwTbQMvIjBx5b+/cnJwW0Xu4SUpyEJm516zv2cu3Am3hxRRp5qdax+AooBuW5X+3jjAVuqI3459YNj3465fvywLs3jTYq740u/NOLNDn1pqXVgYMdAVkvmRRlor49Bnhe4XVtVvky/Yw4w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=P+AzXexSeytJlymzrTqCAK7eH0t1cQ7b1JU4iTBe2zc=; b=HDBqoSD5Enat3KG/+i6HSN7Vkx9tI/gBIXQ75hT68t4iYeni6LXbhJiKytJ1b33D2FeGQQMFagKQ2tkZirubhg+THaDxpm7Q2XyMDvQ/oJ44AhIAFdVbbmH5zYWP31XEWYIpJ7Vw95HSwyR68eedKylAgakFHUibS0pFNe5ppLBoGO4tVw6GKlXYh5G3fU11pP/wA1CUpxfOEFz0FSi2TGQzOjz0qlpMRY2fUdfB6MX/W4mq/urEfwWe7/nMuN+RSv+gN/qqZYmW2RV4h2bgb0OZJdqcqIpoFyKRIBfiVIzSPhn70yH21p0uxkWiGGlSlRBv2UDKMfCBsyvTDQeynQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from AS8PR04MB8788.eurprd04.prod.outlook.com (2603:10a6:20b:42f::21) by AM7PR04MB7189.eurprd04.prod.outlook.com (2603:10a6:20b:116::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6813.28; Wed, 27 Sep 2023 12:09:33 +0000 Received: from AS8PR04MB8788.eurprd04.prod.outlook.com ([fe80::afae:3fda:c84d:bcdc]) by AS8PR04MB8788.eurprd04.prod.outlook.com ([fe80::afae:3fda:c84d:bcdc%7]) with mapi id 15.20.6838.016; Wed, 27 Sep 2023 12:09:33 +0000 Message-ID: Date: Wed, 27 Sep 2023 14:09:30 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH] RISC-V: Add support for numbered ISA mapping strings Content-Language: en-US To: Joseph Faulls Cc: "nelson@rivosinc.com" , "binutils@sourceware.org" References: From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0107.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a8::20) To AS8PR04MB8788.eurprd04.prod.outlook.com (2603:10a6:20b:42f::21) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8PR04MB8788:EE_|AM7PR04MB7189:EE_ X-MS-Office365-Filtering-Correlation-Id: 7f638614-71d0-4955-f9e5-08dbbf529bb3 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: eZZGk4h4vr1ooqFyBimt4KTXKgIyrwH5rRB/UaIJQxRTy8+z6EiBvMGvggOo292bivdQxntB3z4bQHLa31VTBCgoAbwZa97AUWSRyMVZOoKR/tHn0VdxZU7IZ5e1cAKaM6oXGDsqgDg8lTvOHqTfreL/oUNyHvAq/550S9jtbFSGhsHMyO3yZ9Uw/ursvJpGYqNOKXiXUXn2IFdlikE68HXdRFK/gzKikFB8mz9nehACzqDbO72YyIpFjNlrgCF1QQU3YSsbbrYKZwgapFNCz5ih84cHo7GuxcKhVnltJnO2vqVqm1B6HIH92sVLVVMPX5OLZeSgaa8M1GqYsrjSVkKA4m/4KQYM3Y+b38PKq9x0cJlBewkt95XYfnFl8zUgD0asLfMGcjedTj7ZhpVsiB1RhBT3xsm/ZzGk2gfHC5qxL5zxNZBZoPCbsn8DnmI6EMsxSIJBgxsVmcn+KIw9l8dGkS5ofl8rVbOP5VkTVEFc8MN9qiExCCR1iPSIei8bDy6NZn54SUf/xRFPaH2O6VG9xfY4ILfumqvMid6i7AFYzblPVGYKSPc4ZfMyijrHGQ2RXZldKkk92iZiurUGwv/cqOzLLbJGhfAsNR+/t537LCWKU6ZtyY+L5Oguc6eg/jLtD2m8+FqFy1eE7VaN7A== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR04MB8788.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(396003)(366004)(39860400002)(346002)(136003)(376002)(230922051799003)(451199024)(186009)(1800799009)(31686004)(26005)(5660300002)(54906003)(4744005)(2906002)(6916009)(41300700001)(316002)(36756003)(8676002)(8936002)(4326008)(6512007)(86362001)(66946007)(6486002)(66556008)(6506007)(31696002)(53546011)(66476007)(2616005)(38100700002)(478600001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QkE0azlCdFFFdTBSVU1ISjFWTG1HNEdvdUNjV2dkeklJV1UrT1RjdXZIYVI2?= =?utf-8?B?NE1KeXdZSUlZZGRpSlRMNUtYRHdlL3hpbWFwSjFaYzRCRWJUZnB5OENFdGNn?= =?utf-8?B?TnpuTENTb3JPSDVOeG5NT1dZdmg0TTBtV0c3ODQ5K29kV1h6YTQxZUpvaWhi?= =?utf-8?B?SytRTktSSUFoN1FWTC9pQS9DUTk1M01VRG56QW1UZmN2MWpBYTVoekxOZ1JL?= =?utf-8?B?SmluVy9ETjlVZTJtMXhuTHRRajJ6UzVKYnNldnJPNUlaY2NBdlVwdmdMVmhs?= =?utf-8?B?cjJCNnYySE82bVp5VHpyUU8xUSswVnJ3d2M1aFpGRlo1c2kzUlZCVkFWM09G?= =?utf-8?B?aGVjUHVGZ0JoeFE5RzkzQnJqZCtzUTd4TkR5cGJ2d3AwQjk4TE51UE5JVk5P?= =?utf-8?B?Mm82TVpISDhoc0NwaHpiUTNtY21SVVFCdWJibFRMS1VsY0QzVkZvT3Zsc2dZ?= =?utf-8?B?eWxBWnkyVVI2c2hoUG5CdW9RbkI1Z3F0YWs4N1QwdFMzUzluT2IvT2VvTnp2?= =?utf-8?B?OTg3cFBSREU1U3dXTDgvREErdDhLQ0FxTVdtMzQveFJiZDIxTUc3ckxCQzNk?= =?utf-8?B?ZVJHQVVvMU9jUU84a3h5K2s0c2FRT3pFRDMvK1NXNXlnaHhVTXEyOTc5alho?= =?utf-8?B?Mi9qR0l3Wld6VjJhb0sxSFBxamJBZ2g3NEE1NG85V01OMkVaVDh2OHd1dnV4?= =?utf-8?B?VUNTM3FpT1EzRlFxYVJoUFVCSHBpMnY4RzJYYzMzWUNaUGNJN29hbkFqMlla?= =?utf-8?B?aWY0NWVVMWxrSEYzdEJQc1V2OCsyS3BxMS9ZR3hITm15WlM3NmVzMGQ5MzNK?= =?utf-8?B?MTE1WnpTVlJ0ZjRFS21veXVyWnJrQVRPVmEwbjV3aExyQlI2NktpMlNCaFVa?= =?utf-8?B?WkZMZzAzL29nd1JBWG9MNEZKUXgvbzNWT3NQMWY5R0thaGhTV2kwUS84VjBW?= =?utf-8?B?OTZ0em5USnp4NlhXOHY3UjNyZDIvNzgwbllHNG9aSGlhOHpiY05OK0poZzl1?= =?utf-8?B?TUtiYjFkWnpPQW9aT01UVVJFWm5mV0dxVHJGaVBFY0p3ZVFNWUwyd0ptc3Vz?= =?utf-8?B?a2JtVzR3Y25Ja0hkT3NtTHhhdkhGTUlVZXk0TnAyZXlEZWJBekd3OC9uNG94?= =?utf-8?B?MitZRXFUZm95TzByWkpWeGEwRE9ISmJ1NlFBbEt4NHRBeEJuSHJLVWt6b1Ro?= =?utf-8?B?YTZaWk4vL0lKa094eFgyU0tQN0huektsY0sybHUrQkE0d1huc3VCRWZTVEFp?= =?utf-8?B?bXlnTnZVbG5ZZHVTNWg4RlJiZkE5UE8zbk9ITTlHbjNRdHdaK1U0MkpGaEV3?= =?utf-8?B?Qk5Ja05vYlVsa0pqYWE1UTZvVFNkZzdHQml4cjVvUTZVUkZNZmJjaHp0R3Uw?= =?utf-8?B?RW5JOGtnbTgwMXBmUWYyMFlaZTRNaEx2cllZeXFhUGhBZUgzOERWYlJRaWox?= =?utf-8?B?VFpjMjY2TmVZT1c0WmZCY0ZUdEZta2p3di9BM2Rlb0x2VXlVRmZvc2NPUm9E?= =?utf-8?B?ajUvOUFOSFowMXVRaFVROHNPeGRtVEErT285eEtUdWp4NHp5N1pFYWwzVDZ1?= =?utf-8?B?Z1I0NEpqa3d5bGhmQy9IK0xhdExLQWJPVXVubVdzRkg5VnJBdmw4R1lqS1Nz?= =?utf-8?B?blFwK2xWL3pIajBsazhrSWh4aVlmMlR3N21Tei8xRDlEa1VzVlhvVGF2QlJm?= =?utf-8?B?Tys0TUxkWlg3bzZxSytxM1YrQlVNSTVHbTZVOFU5RFo3RUR3M1Y4UzVzVGlt?= =?utf-8?B?dnh5M2Q1engwRFpldS9VcWN3ZVpNUU96RVd2VDNldVZpcWxOQmNDUnlUQUtU?= =?utf-8?B?OFRaMCtNR3lFM2JkRzNOU2RqVVhTQTFIcUR5YTVVUDZNZnFnT2RPcE0yczNE?= =?utf-8?B?MFhmRUREMnpIc0svY1V1T1lBMDVmVzdTSUNwZzdRQ2dqM2xHNjloclR2QU93?= =?utf-8?B?ektPZTVVd2FhQ2doeVVmZkhzQ1B6YU1iUzI2bjVMajNwanljV2dyRmhjcXFE?= =?utf-8?B?d1dxU25EeWpLWG5xQzJpaUpXYWhiTEdlU09mZnkxVTE4cmRqZ1VCaFBvd2xl?= =?utf-8?B?RlVBUHZlbU4ybVR5YkJ4SnVpY1ZIQVFLc3MwSG5URHN3aWhJVUxVWkNpUGlT?= =?utf-8?Q?AzkUrFtzoHijC+49C7Um2oQrc?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7f638614-71d0-4955-f9e5-08dbbf529bb3 X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB8788.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Sep 2023 12:09:32.9510 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ipclxj8iK0OfTePDoYsci5FrY5hGnSxXRfOIj4CqRhr7Tt50H2kl1ut93h6q08KbIYqWkOL+psw61bepEwaWIA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR04MB7189 X-Spam-Status: No, score=-3027.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 27.09.2023 13:20, Joseph Faulls wrote: > --- a/opcodes/riscv-dis.c > +++ b/opcodes/riscv-dis.c > @@ -869,7 +869,23 @@ riscv_get_map_state (int n, > { > *state = MAP_INSN; > riscv_release_subset_list (&riscv_subsets); > - riscv_parse_subset (&riscv_rps_dis, name + 2); > + > + /* ISA mapping string may be numbered, suffixed with '.n'. Do not > + consider this as part of the ISA string. */ > + char *suffix = strchr (name, '.'); > + if (suffix) > + { > + int suffix_index = (int)(suffix - name); > + char *name_substr = malloc (suffix_index + 1); > + strncpy (name_substr, name, suffix_index); You want to either use xmalloc(), or you need to check for getting back NULL here. Jan > + name_substr[suffix_index] = '\0'; > + riscv_parse_subset (&riscv_rps_dis, name_substr + 2); > + free (name_substr); > + } > + else > + { > + riscv_parse_subset (&riscv_rps_dis, name + 2); > + } > } > else > return false; > -- > 2.34.1