From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x434.google.com (mail-pf1-x434.google.com [IPv6:2607:f8b0:4864:20::434]) by sourceware.org (Postfix) with ESMTPS id 14AF03858D1E for ; Wed, 21 Dec 2022 20:50:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 14AF03858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pf1-x434.google.com with SMTP id w26so11524143pfj.6 for ; Wed, 21 Dec 2022 12:50:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=NHrz9rKRkb+dvT1OrWmDeXiOlYNN8XY9psouTb1MIOE=; b=I3DRqG/cUWHI7xLpW2zYOTz3preTbXLaICr+6xcYWBg486DkD2tPagrQbOnPvkT2J+ aMaasv/XL2Tpk9amjEz9wpJRqc+ULbGJe7i/Hd+kTK3/l9X+4I+2ISaJBaRByiUblbHp /EbMuA1AND/k0UZ3JXi9r7Gn7Y8vQBdpgStw50teLVEKi6ty4BqcMnNIJLtAxjFiIovt RcGtSaEbGlS4yfGH1FL3lGZ0Uf7ZBYj0/CFt3s+WK4JlNlC50uw1tHa5TRfKAbFHJJ7p jgWu+1y3fa/nuexEuOZkbdGNf4mJpy8NUWcdN5BBN6dMpDFU7GCxKgCOvkueZbN0AQRf JcLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=NHrz9rKRkb+dvT1OrWmDeXiOlYNN8XY9psouTb1MIOE=; b=Ci6ZiFeTe4cXpIji+VnwbmFHZQ5rUu0m0u8CWp6YkgqkY/v108zX6aQ2MQdgWehRnV aO7W7IIb9WwULiwfFgNwmsrlFCXHEBlBsFkoAagSs0sqR2kMolayoxCnfOnD1bfbqnHD opE3OSX1dxkVw/ENNnVe+yVIVKafe00elLV/NJsiftO03ha6343SIqCgNnmb32YpwiHk c8r0IEnelDjJvbLKjzE31ICNos0dc8qMWpV17DxzfH7ni92U8JkOyUVqU/knFyMAui2u lXsnA7oFo5P2t5sYN3q5Na9goMlG8gcifvJCOtuF865sZe8O671zfoe5VR6gdwUONE+5 t9vw== X-Gm-Message-State: AFqh2kq+FgrG0OQatWd7Dq02MBUxuraT2YFGagfTwwQ9qF2TVHLOMFns dTr7I0Pu/Gd0JTp39piXgeA= X-Google-Smtp-Source: AMrXdXt+26xkfAkvbDMac3bxw4DISz/22rZzcuRkj+bN+DmTWhufvE9K/f76EifzVwX9trY8dk6vwg== X-Received: by 2002:a62:ed08:0:b0:577:272f:fdb with SMTP id u8-20020a62ed08000000b00577272f0fdbmr2743868pfh.29.1671655827001; Wed, 21 Dec 2022 12:50:27 -0800 (PST) Received: from ?IPV6:2601:681:8600:13d0::f0a? ([2601:681:8600:13d0::f0a]) by smtp.gmail.com with ESMTPSA id l187-20020a6225c4000000b0057621a437d7sm10974545pfl.116.2022.12.21.12.50.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 21 Dec 2022 12:50:26 -0800 (PST) Message-ID: Date: Wed, 21 Dec 2022 13:50:24 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [RFC PATCH 1/6] RISC-V: Add Zvkb ISA extension support Content-Language: en-US To: Christoph Muellner , binutils@sourceware.org, Nelson Chu , Andrew Waterman , Palmer Dabbelt , Jim Wilson , Philipp Tomsich , Aaron Durbin , Andrew de los Reyes , Eric Gouriou , Barna Ibrahim References: <20221221170706.2877188-1-christoph.muellner@vrull.eu> <20221221170706.2877188-2-christoph.muellner@vrull.eu> From: Jeff Law In-Reply-To: <20221221170706.2877188-2-christoph.muellner@vrull.eu> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,KAM_MANYTO,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 12/21/22 10:07, Christoph Muellner wrote: > From: Christoph Müllner > > This commit adds the Zvkb ISA extension instructions, which are part > of the vector crypto extensions. > > Signed-off-by: Christoph Müllner > --- > bfd/elfxx-riscv.c | 5 ++++ > gas/config/tc-riscv.c | 13 ++++++++++ > gas/testsuite/gas/riscv/zvkb.d | 36 ++++++++++++++++++++++++++++ > gas/testsuite/gas/riscv/zvkb.s | 28 ++++++++++++++++++++++ > include/opcode/riscv-opc.h | 44 ++++++++++++++++++++++++++++++++++ > include/opcode/riscv.h | 5 ++++ > opcodes/riscv-dis.c | 4 ++++ > opcodes/riscv-opc.c | 16 +++++++++++++ > 8 files changed, 151 insertions(+) > create mode 100644 gas/testsuite/gas/riscv/zvkb.d > create mode 100644 gas/testsuite/gas/riscv/zvkb.s It all looks quite sensible to me. > +/* Zvkb instructions. */ > +#define MATCH_VCLMULVV 0x30002057 > +#define MASK_VCLMULVV 0xfc00707f I'm just going to trust you got these right and that the MATCH value in particular might need adjustment if the encodings change. > +DECLARE_INSN(vclmulvv, MATCH_VCLMULVV, MASK_VCLMULVV) So IIRC, these are only used in GDB's prologue/epilogue scanning code -- and we're quite unlikely to ever need any of these instructions for prologues/epilogues. I'm guessing convention is to go ahead and add the DECLARE_INSN instances for each instruction, even if they aren't likely to be show up in a prologue or epilogue? Jeff