From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk1-x733.google.com (mail-qk1-x733.google.com [IPv6:2607:f8b0:4864:20::733]) by sourceware.org (Postfix) with ESMTPS id AC8323858D33 for ; Mon, 25 Apr 2022 14:59:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org AC8323858D33 Received: by mail-qk1-x733.google.com with SMTP id e128so10933449qkd.7 for ; Mon, 25 Apr 2022 07:59:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=Hloj929ig635z4yMVM2Zn14c64x4sBgsTZXxWh7Zv2w=; b=wG5QXI1UNSr9pMsRcpCrG3NgcuF82o5WOxkGXOdJOI4V7GCfuIKOBJeKIyEfK1BXVn 3v+P4yZ7/5Up/SBJslErh9C/DeNMH/IMbGT2wpbNtsiAIHHmFMMfSnAJFyZahDaSQTWe rR1hykqCLPw2dbqnF5Z9OBaaOntz3HF5ApKD3pIBTvcIVzpNMkD0ttlv1wQgpBI4KkdB p11IRxKCpBcQ0V1FqFumg88ecRsxIFMnE5dPohpQ8HCyYaj5FteJ4MrQW5N+L4q8+prR bwSN8qc/8zNApKuTY7y/fjsIc53KLbDX5DY0RQmnWPXUxjUt6c0JEjWStn+GsrfCEACD bARw== X-Gm-Message-State: AOAM532RVEo4uh0ablEX0EDoDn10Re9siE9/XDxxYl9gQUjx2RYTcIKd SCaxRN/7L7WX9g+1SEsKVZusWtveGus= X-Google-Smtp-Source: ABdhPJwPLziFAkln/DvHmHR5Wx8+Xv11jTMMNNQ58OTEf3TAuEAKIFRwGACZbjjI9tAlalnr01qDvA== X-Received: by 2002:a37:8d43:0:b0:699:b613:be6 with SMTP id p64-20020a378d43000000b00699b6130be6mr10360999qkd.484.1650898762703; Mon, 25 Apr 2022 07:59:22 -0700 (PDT) Received: from [172.31.0.204] (c-73-63-24-84.hsd1.ut.comcast.net. [73.63.24.84]) by smtp.gmail.com with ESMTPSA id v21-20020ac85795000000b002f369abd498sm1739935qta.10.2022.04.25.07.59.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 25 Apr 2022 07:59:22 -0700 (PDT) Message-ID: Date: Mon, 25 Apr 2022 08:59:20 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [committed] exec-stack warning for test which wants executable stacks Content-Language: en-US To: Nick Clifton , =?UTF-8?Q?Martin_Li=c5=a1ka?= , gcc@gcc.gnu.org, binutils@sourceware.org References: <8e46710d-573b-bd06-cb80-518575dceefc@suse.cz> From: Jeff Law In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Apr 2022 14:59:25 -0000 On 4/25/2022 8:42 AM, Nick Clifton wrote: > Hi Jeff, > >>>> I used -z execstack rather than --no-warn-execstack as the former >>>> is recognized by older versions of ld, but the latter is a new option. >>> Thanks for it. >> Unfortunately, I should have looked at the other failures that have >> popped up over the last week.  Essentially all the nested function >> tests are failing on some targets due to the same linker warning. >> >> Either pruning or adding  the option to all those tests is going to >> be necessary ;( > > Sorry for causing you so much hassle. No worries.  It's a very reasonable warning.  And it's only if you're testing with the latest binutils that it causes problems -- which is one of the goals of the tester -- to find this stuff when it happens, not 6-12 months later. >   If it helps, Alan has already added > some pruning code to binutils/testsuite/lib/binutils-common.exp in the > prune_extra_warnings proc... Yea.  I saw that.  I ultimately decided against pruning as it would be useful to know if a test suddenly needs execstack.   That would generally be a sign of something gone horribly wrong.  I just (locally) added the magic to the rest of the affected tests and I'm testing it now. jeff