From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2073.outbound.protection.outlook.com [40.107.21.73]) by sourceware.org (Postfix) with ESMTPS id 5E6ED3858C74 for ; Wed, 23 Aug 2023 06:24:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 5E6ED3858C74 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RHmBbX74hxgCt4Nsu7BUVw8dlX1BqDH1i4j8CAPj6pxwSQfbQEkVMOmlptpkJVBsbKYCO/+P1iUta9Wc3cnNeJp3haqsxyfgen8UKZIh+dyaYYI4KYYcNs+6KTS6Ki0cgx66nt52oKY4Sgd95sVWqp+qrpNg0o+M1DMdwwUqZmUxr1oDBf54WGcmWdQCXuZUx6T8UFfC5x/R2ql4wmQuXyLKQlQlvMT4zdj1C3OraqWG6jCkuGUPQpwmGEma0Qnu0wvOTZJTI1vSYCrsOfV3G4yHuP/Vv3JUnK4Am7sJgpZHgFJPQg3poDu9FnlFjiVu/YqUw1WFjy2LzLdFuqJ4Ww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BtGehNxS99FfKdpb5GWPFC0wwqDHeIam6YZwZ1GKjYk=; b=aJLQiQP3J1Aqfq5i6+Gq7cdoqStX8+JQHmZ4bVZBuuFsjBnHFGTraMedPgHnVq0Kc6ElFG2ZI6zarXL1dR7kiEk31yGwEtqDSgZe+9SS/YEdrb8w5hWbbEZPe0KcqqqhHeGaSxQg054K5dTIuBd2YQrTKuLBm4D7cfOfJuAM9q15944Qqhedz8d9T9h/aPZpvJwTQNxuyKfAI1LZwxKnqAoeopRTdf3UmdW+tlgrVvh+nH545wouOC3ZUpXa1HnmZaYbIa8R+NepQQnCV3c2grK07N0mBexdWxAasCKJEd51VObgxWiMfn+F69TQqnlpW+7l1PoCvJBzWOPVTOmSCg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BtGehNxS99FfKdpb5GWPFC0wwqDHeIam6YZwZ1GKjYk=; b=OwECB6a046fmkZ6bnX0ceCuz6QPIpT3D4ASTDF+dNC7F8zCMit4X7Xk2Px1LQktju9+1R172f7RUOw4zuPxMwR2fE6l3XLTC533yHeLtnzQ9pUiyoL2XKQvjfkU++KSD/E4/NgSv2Hcf6XRXAZUlDztedfVY65+S02Auc06UEXqtpmLpRc3hI0Q6qjARd5XfJnC8t72zjeaEBxBgFLOtM0plkkXFsaZIaTSsoZFrxmitm0F+fzNXWSPiB9WIJM/g67x0dUJ2rDiR6XD+5DlClxAEFEiVvRPLfUqgW0sxKhN0pAtNl3hzWF2vQ9XeGOta9PfHvuxZZxC/s7xWWHUtAQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by DB8PR04MB7178.eurprd04.prod.outlook.com (2603:10a6:10:12e::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6699.24; Wed, 23 Aug 2023 06:24:03 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::f749:b27f:2187:6654]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::f749:b27f:2187:6654%5]) with mapi id 15.20.6699.025; Wed, 23 Aug 2023 06:24:03 +0000 Message-ID: Date: Wed, 23 Aug 2023 08:24:00 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [PATCH v2] Support Intel AVX10.1 Content-Language: en-US To: "Jiang, Haochen" Cc: "hjl.tools@gmail.com" , "binutils@sourceware.org" References: <5eb31b18-e1ba-dbf1-bddb-ff03b61b25de@suse.com> <20230814064535.3228154-1-haochen.jiang@intel.com> <96638e6e-142f-b7f2-3a95-56e70e8d159f@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0126.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9d::20) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|DB8PR04MB7178:EE_ X-MS-Office365-Filtering-Correlation-Id: 674f437f-02ea-4f72-dfe9-08dba3a18b79 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: LQy2imsm9G2jaBffSiyYn31hiFWYjX81u05h2mLVo7WiAINak940sxIC1y1w28V1O8Wh7stROH4EPk0lVBBQHhLy35Y5TGdXdB074h8UEPb8ixw6VHyzojgDGUuXViVOgTs7mEV85YI3Tfni20MvcAiDg4O7iUA+qLP1XrdnSHVsrvqNtVrA6sFxFA3Wl2CgtT6wsR9jA0FJIhRKis+Ce0G5H351NmU1Lpnm/rzZdRzIGORo0Fy3YghdR2PLFFdsOlxgyu33ruzCFgd7B2AmDirqdXv+nVJ7vHZ2IMqw67dDbmJpjqD69MY3jQawt/t02izT57S/BhLXwA5T4Wz7CX1nz3k96boOQixvXDbenDC0jbm72N8DaKw8slJTRZp0PwZsAoYovY2H1j9JnpCavFkEkasEMfUg9xSX3dJAwOE+Nucef8DEZ3FM2G8eApDgXgeIQGOfY9nOK3RP+RjEv6fXEMTt0mX0fSRWeJqGkL4fGMvDJrEY2mvTBMLAqDemVbSlFz/jy98WRRkhke3xpYbDBiZhzkueBMbkHGozOmmMYpID9h2fpHOk11jg5OtyM7PI3SxOWJNzi2egFsSFfiqI+i8ztwHXXmriQlO5Fm2bQ7g79KEW+69hd0n8Xl8l3n5jzyRR+EEqXIn3N0QW8g== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(366004)(346002)(39860400002)(396003)(376002)(136003)(451199024)(1800799009)(186009)(2906002)(38100700002)(6506007)(53546011)(6486002)(83380400001)(5660300002)(26005)(31686004)(31696002)(86362001)(8676002)(2616005)(8936002)(4326008)(316002)(66946007)(6512007)(6916009)(54906003)(66556008)(66476007)(478600001)(36756003)(41300700001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QWhnNmp1RHAxb01ZV3p6ckRrR2grV1E5STFJQzRiNmplOXB6VFhJU1ozbnNM?= =?utf-8?B?a2lyUUUrYjRrVW5WaXJHTlVDMFZzdnJBUnNGdTBqTnYxQXgrRGJIVk93RDhB?= =?utf-8?B?aTA2NXdqamFOR3N1NndkSkNhUXZ4dGtYN2ViUUp0K3ZuSDFtSUtNQ0UvMGx1?= =?utf-8?B?WlB4T25sUlZuRWJqUXpicGV6NkowNU01MzZWR01MQ3VEbDVodGR3Y2RkWW5D?= =?utf-8?B?SzNaa2N5enZTRFpDWUx1bEN1RTBwZkNQUndqTkpPMUcwWUR4MnFCMHhpUXpw?= =?utf-8?B?ODZHTGMyQlVZNWg3MXJ0dWl1Qm5uSDVBYkVwR0p4SVpzdkRhK3MyTzd3akMx?= =?utf-8?B?NEJEbHZHTVY1dzlmWnZEbzNRK3UrbHFVMXhncEY3ZnVUb3RKdWtOLzNDUk5R?= =?utf-8?B?TDZpdVg2Wjh6bkRtOHVwOFFwWTJpZGFXdHhvZXBXUjVMNS9nT3N0L0lUYXgy?= =?utf-8?B?ZHhrM3NWZW94ZmlDOWg5WXhvcURZVWgycWlQRzB3L3Q0dU55NURtWjBPVm5M?= =?utf-8?B?ZVAxSEhWSGFZOTl2eG5VcE5naG5XZDArdndCQThNM0dXTzdhdFVjNXdmays3?= =?utf-8?B?dk1Rc2d1WHl3R2Y0dGNhV0xpdmRpeGc1M0NDU3BnUVA2b1pYVituWi9VNFNt?= =?utf-8?B?eUZiZzZXam45KzVORzZpd2dvWVBka0w0d3Y3bTBSd2JnZTlGTzFFRHJCN0Np?= =?utf-8?B?czJrby9tUjBTajRUblNjdG1tNzZVeWg0eVh1SU5lSkE2QjJIZUYzTVUyZmVN?= =?utf-8?B?NDV0OHFyVjU5aWZwOCtreDkzTlFlTmlkeGU3OHlIeEdvWFE3Nng0S2Fnbk5V?= =?utf-8?B?VGVINTV0NTM0Y21qN1p3TE5idDhXMy9VK21hOEEzeVdJNm5KSWlVdk9ISW5P?= =?utf-8?B?MzlBWUsxdFk3dnQzNDZmL2dXYjl6andBUU5tL0Z3RUN1NlFtTnZ5eWE5OFh5?= =?utf-8?B?dmhHRjhvZUlqeUYzRERZengrY1RPSyt3YTVKSDRZTjRlSVRwS0l4TnpZSmxJ?= =?utf-8?B?a2NyUTdUamlteW13aU9kOGpLMVgycFB5Ujk4MXBPelJINHBqelZVekNYdHZS?= =?utf-8?B?NE1IMWxHMmhrS2dMV1BESEZjeVl5TUJ1TkREZGRhczBZR3Z6WlNEMzlIWnY5?= =?utf-8?B?M1JpaStaQ2wwUUFsR2FKVzErOUZlQnVEdUVpbVB3TnVqSEJwWkpOYWxoUDZV?= =?utf-8?B?cUFoL1FPNkNHVmVtV09OQUhzaEozUXg5MG8rZEpzZEZSNTJCZC9Wc1ZkZGhi?= =?utf-8?B?Uzd1aW9BU2pFZG1UL2pOYURvR3FhMFdoTWFob3pXQ2wwUUdFSk12Zm51SUlQ?= =?utf-8?B?cUhNcnpjMGl0ai91Y0xqOE1IMExzUGJtSmhNT1FVTHpFUGJWM1FlUVNtU0dN?= =?utf-8?B?TzJoN2xGRU5HbjlpeUdpMGpTQW1SbXEwVGhGeHJyeXlKMllUQUVFRTQ0SmFm?= =?utf-8?B?MjM3WENFWmx4U1hGY3YvMjdxVHg0bTlvZ3VWSGU2T0VqRzVVZXduRnBPUjJI?= =?utf-8?B?c3Ava1NpWS9DVnoxUS9oZW1oV0E5YXl4WXJLMndYdVlqTzBZTG5sak4yQ0Jo?= =?utf-8?B?ZDFZSmtPQUJPcUJpZzJ3aDNxdGh6NWJrRkZKU2p3TTB2OXN3RDlENFRSYnJJ?= =?utf-8?B?anNFVmlPN3RObnZIWmtheERYWVRNaUY0a095UWRkWnpzcVBLY0dhSENBc0N2?= =?utf-8?B?WHFmSVo1Z0p3MXlhQ1daWUFUZ2dVeTFydXE2Y29pUTlvaG5nZDlQVk9jVWlC?= =?utf-8?B?TWNXQkNtaWU5QzQ2SlJnRmduUEpvdCs0cm1CWG1kNlAxeC9XV3JNQlBsV3o4?= =?utf-8?B?U1VlUUY2U1lWeFhVQUJaU3l2QmVibjF1SC8xUHQ3NnQzRzl1SGczNHkzK0Iz?= =?utf-8?B?S0xvNDVNNkYyWGUwV2JLeGpaZDJ5K0FLdllRdlNVcURPdmNKOEU4T0hiaXE2?= =?utf-8?B?VWhRU2FnMmJIRnQ2bnRpZTk5Wi9yaEtqQy9YdUJENi9FS2FhU0p0TEtacSt1?= =?utf-8?B?M0xLc2xFMEhHeGdxTXM3SnpacHVQVUhUN09BNDFnd2lIQzQ0cmFKWFhtWG5I?= =?utf-8?B?UTR2UFlMSFBaVmpmYy9pZDdyaG1FQUd5ZWcrOHhUSm9MeTZ3VGFWYmo5WmI2?= =?utf-8?Q?xrbdK5gDiBKh373LLm3u+8Njf?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 674f437f-02ea-4f72-dfe9-08dba3a18b79 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Aug 2023 06:24:02.9889 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: xC+tO4O1yybUcCPWfO0a3Op6dhVhUIdmG2UR/idVIORwu9jqiZOf4MUkjRH0JEWU4BKGlfhVkT07iBN+gPYSmw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB7178 X-Spam-Status: No, score=-3028.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_NUMSUBJECT,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 23.08.2023 08:21, Jiang, Haochen wrote: >> -----Original Message----- >> From: Jan Beulich >> Sent: Wednesday, August 23, 2023 1:54 PM >> To: Jiang, Haochen >> Cc: hjl.tools@gmail.com; binutils@sourceware.org >> Subject: Re: [PATCH v2] Support Intel AVX10.1 >> >> On 23.08.2023 04:20, Jiang, Haochen wrote: >>> >>> >>>> -----Original Message----- >>>> From: Jan Beulich >>>> Sent: Friday, August 18, 2023 9:03 PM >>>> To: Jiang, Haochen >>>> Cc: hjl.tools@gmail.com; binutils@sourceware.org >>>> Subject: Re: [PATCH v2] Support Intel AVX10.1 >>>> >>>> On 14.08.2023 08:45, Haochen Jiang wrote: >>>>> @@ -1315,6 +1321,20 @@ output_i386_opcode (FILE *table, const char >>>> *name, char *str, >>>>> ident = mkident (name); >>>>> fprintf (table, " { MN_%s, 0x%0*llx%s, %u,", >>>>> ident, 2 * (int)length, opcode, end, i); >>>>> + >>>>> + j = strlen(ident); >>>>> + /* All AVX512F based instructions are usable for AVX10.1 except >>>>> + AVX512PF/ER/4FMAPS/4VNNIW/VP2INTERSECT. */ if (strstr >>>>> + (cpu_flags, "AVX512") >>>>> + && !strstr (cpu_flags, "AVX512PF") >>>>> + && !strstr (cpu_flags, "AVX512ER") >>>>> + && !strstr (cpu_flags, "4FMAPS") >>>>> + && !strstr (cpu_flags, "4VNNIW") >>>>> + && !strstr (cpu_flags, "VP2INTERSECT")) >>>>> + { >>>>> + cpu_flags = concat (cpu_flags, "|AVX10_1", NULL); >>>>> + k = 1; >>>>> + } >>>>> free (ident); >>>> >>>> While making a patch myself along the lines of what I had outlined, I >>>> came to realize that the above isn't enough. (I'm pretty sure I >>>> wouldn't have spotted this by merely reviewing your patch.) This may >>>> be a result of the spec being somewhat ambiguous when it comes to GFNI, >> VAES, and VPCLMULQDQ. >>>> There's a note there saying something about the respective EVEX >> encodings. >>>> But that still requires the VEX encodings connected to these three >>>> features to also become suitably available. While this works fine for >>>> GFNI, it doesn't for the other two: The 128-bit VEX encodings, which >>>> surely are available when the 256-bit ones are, would become >>>> impossible to use. The assembler would pick the (larger) EVEX forms >>>> instead. There are two ways to solve this that I can see right away: >>>> 1) AES becomes a dependency of VAES (and PCLMULQDQ one of >>>> VPCLMULQDQ) >>>> 2) We put in place extra templates. >>>> I'm wary of the first option as long as not at least informally >>>> supported by you (Intel). Hence I went with option 2 for now. >>>> >>>> I'm only done with the /512 patch, so I won't post right away. I'm >>>> still debating with myself whether to control maximum vector length >>>> via a new directive, or via a special form of .arch. >>> >>> Do you think a command line option like -mavx10maxvl=256/512 with >>> default 512 is ok for this scenario? I am working to revise the AVX10.1 patch >> like that. >> >> That's certainly an option, but right now I have different plans. > > Actually all the three options are ok for me, they should not be that complex > based on the current part of v3 patch setting/clearing AVX512 bit for AVX10.1. Mind me asking what "all the three options" you're referring to here? Jan