From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by sourceware.org (Postfix) with ESMTPS id 992723849AD6 for ; Thu, 18 Apr 2024 07:40:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 992723849AD6 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=oracle.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=oracle.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 992723849AD6 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=205.220.165.32 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1713426042; cv=pass; b=YcJ6em8gNIXvCvL+Q2W66zUIH7/Ch4jIqsY1SuSLLcQX4DI5J6AJO56XS6rR4apBpNzioKOeT0GMtPz2SmXyFsH2jIDucl479R4kExJ7lHsvmmwHj/LvMD6M4BTHAs3jLRTUlsrzJiLNULmCRAEjn6OIPOlyNQarT2ODhFKkN5A= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1713426042; c=relaxed/simple; bh=tnMHYieGS7tD1T3ByWg4i8Bzh/izTl4ShCsRGAengFM=; h=DKIM-Signature:DKIM-Signature:Message-ID:Date:Subject:To:From: MIME-Version; b=sd4MbMHaMz1Fm3ezUSAaq9lZmPLM6OxofajmM5bzHj+8bOqWe+rIhrWJ5WakMXEvO62KmByKP1isNi28zczP00gqjIfZKeJQolQ1fYRV7cyRdD8YW/pb6AmDuPLJ1QoFJnAOrxYbdIpWFpr1P76eafenD1x0KVjJHk/x4Ml2g3M= ARC-Authentication-Results: i=2; server2.sourceware.org Received: from pps.filterd (m0246617.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 43I3xjqA010681; Thu, 18 Apr 2024 07:40:38 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=message-id : date : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2023-11-20; bh=FMtqba1UMW7VKttJEOtgXV/YMxRDFC/kPzVjeayrWXs=; b=oCex61fpfsNOJ4WfUmlQ3psVS4/sqGNJLHfloVvs11MQ1ti+dduM8GNjZ3M8UxAUn8RW e0MYSazwTSBZwZLrHrV+lymF5EjXC4UAk1kCiGpUKCuj+ngQyC/jZ8CLeG90qib0CYw1 wewEGwbRWdS1GsmwOrxAc4TuzU8lr9jfzgFij3UG06uvntEAsw/8ipJBp7OQ46DIQlN9 p4EmpcngSqAx7EdsjkbfZQJZgwpZUP7d/xMcN1TTTJBMlH6JJzjvtm6FWK3hRfMj7qQV T1V8ojWJh5WBqSBQ1tx+RTlVLpuCd5qhQu2YpwW6ERYNBtwrhi7DlgStNApqMulaBrcg Gw== Received: from phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta03.appoci.oracle.com [138.1.37.129]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3xfjkv9mqr-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 18 Apr 2024 07:40:38 +0000 Received: from pps.filterd (phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 43I7VTv2012472; Thu, 18 Apr 2024 07:40:37 GMT Received: from nam11-dm6-obe.outbound.protection.outlook.com (mail-dm6nam11lp2168.outbound.protection.outlook.com [104.47.57.168]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3xgkwj400y-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 18 Apr 2024 07:40:37 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=W0hXQ+zeISsXYsEJ6vr5gbToOr/GK+5PwPnSHWltAUJoPYUorCfhBZFdIRLOpoE1tcGh+XsRhLZSSuMQctyl1dBXDGps3TEtnS/RahID0XF5oQ/DEX4BiLszcvCNfAqfH3WbYiu175c1uCXQR1/N2biwhl5/7xlr20gb+V7g2q6J7MI78QLMCDJjUFdWjKvnIqpQWy1V4DnF0XlJVyPX9jVqIgU+ORGfC5Kl6CTBWaiHw6czBnHDv8LqP52EX3sDabYqZUUX+U0QHppws50ViEOq6WYDEYcewD9L/7xaihEWnl3pYSLslQ1JOJD9Yx79AlJLRgB23uxc25R+fCJRvQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FMtqba1UMW7VKttJEOtgXV/YMxRDFC/kPzVjeayrWXs=; b=ZzWzBk8FxhwTY1gduzHWaaq15dXvAV1dGm6tUB9ZQbRPF33zNhOT149bmzCeF7VYYgRiBSsUhf9GnmH/xEo3SuekVi6He3U8wDZZecwm/bRjYVcQee+PABvMbX+wewcZ46RqYyebo/9nk7KO08zIHSOueLyJfmpRdfjpGeR9eVuN2NUn+ZH/xNsJzESULrgswtkSW2jKCAJuYE17ZlI8caiIq2iVp5ooAuAOq1n07u0VzEddRhWB56FNeJzt/HMlbHXLZb9qFDkjO/iWAckVecYwOkSlZMT3+gT5B0DvAfM7cZD1SOmPWvCi0j1WNnEKh6HSpB/ym2PJyNmU5dK1FQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FMtqba1UMW7VKttJEOtgXV/YMxRDFC/kPzVjeayrWXs=; b=KpDsfIgf5R4RcVDlqOjTc+0Zic54VidH0+c56T3zshOtw2fghdPpV41+bGl3bEBLXv496TyZ3FUMeqMpGTw2vrnRlluU3PQsXwtWi/pgGfHVoHNRJSOrJ3Gx6abxEpztxvboAyxxUNVyNk5JFAD3/XbzKtrXaQLP9Amd1tb3is0= Received: from MWHPR1001MB2158.namprd10.prod.outlook.com (2603:10b6:301:2d::17) by SJ0PR10MB5694.namprd10.prod.outlook.com (2603:10b6:a03:3ed::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7452.50; Thu, 18 Apr 2024 07:40:35 +0000 Received: from MWHPR1001MB2158.namprd10.prod.outlook.com ([fe80::6f0e:742a:270:889]) by MWHPR1001MB2158.namprd10.prod.outlook.com ([fe80::6f0e:742a:270:889%5]) with mapi id 15.20.7452.049; Thu, 18 Apr 2024 07:40:35 +0000 Message-ID: Date: Thu, 18 Apr 2024 00:40:35 -0700 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 07/15] gas: Warn if SFrame FDE is skipped due to non-default return column Content-Language: en-US To: Jens Remus , binutils@sourceware.org Cc: Andreas Krebbel References: <20240412144718.4191286-1-jremus@linux.ibm.com> <20240412144718.4191286-8-jremus@linux.ibm.com> From: Indu Bhagat In-Reply-To: <20240412144718.4191286-8-jremus@linux.ibm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: MW4P220CA0004.NAMP220.PROD.OUTLOOK.COM (2603:10b6:303:115::9) To MWHPR1001MB2158.namprd10.prod.outlook.com (2603:10b6:301:2d::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWHPR1001MB2158:EE_|SJ0PR10MB5694:EE_ X-MS-Office365-Filtering-Correlation-Id: efb74e8c-74fb-428c-c558-08dc5f7ad5a2 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: DgYK87LkBNshsbO32fX1T72px9+hvnGXysvb58DzhFb1CkNn+44bWeA+tO0nxrhRvHamkZiBJ+bqYi/7ssqxCjY04ZBPGiS5OlNuiXh3rXI1mh9yOkaDsfZZ08L/ySQf8lICGgo9PYBX4OEiRtXBk6TzLFHcWOrX5sWhJJzxHCQ6DxfKNhmcEmdh+6nhB+tuj5rHDznubi4YVj6dSbkvDaVquxJ5iRRE3QZZ6s8MMJAsd3jYhrfmn7QQ4ntqYy9meVoGVi2aNpi2VxZsyY9/nYsrq6pAxvWck2crzE2LIyENhfmUYzdtj6xpIyj3AqtsmQvDF8JKikxtPq5wNNIeQ4X11qGAe9oDD8k7Fyb9KzXOToU8c3i7u/fsL2CI47l6KtI+m9rCZBV1Mm1qIIdjM2WKPl5+fzO0nymY1JjoBKDYZZJs40hESbj6oLr4BO+3PWc12Q9lSGT+z0+Gywq6TvbIzwzu1KZs2Qh2t4R/pwGrN3TGkEBvDT2kIq2oIMCjW1bplMnKNbd2QUM/Ek0YF314GlIzvPMuaUBstXNaoTUN31ZceZ+rZ5QmyoB+PJI/wig2DIb/m/WAzHoUSPnEYgnmI+SQ2wULjdlxNk1I8TARgrSfTol95tVdZ5UNq4WAbW3N1UjdB/WV5zwWzkpim5mG6clwyvH7c//+2Oleouo= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR1001MB2158.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(366007)(1800799015)(376005);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?STFaK3JPL2oralRaemdQU3BES0hOTC9IRUs5bnNzb054VzdVMWtzM20wekY3?= =?utf-8?B?WDJLRkJPZkZLbm1NRTNQdmZZbndRczUvdGFKdGpnU2dMMWlqZlU4eEV5UE9p?= =?utf-8?B?TVcvNW9TVGQyWFhQa2NxOUNUb3NlbE1vVlZGK2IzN3czQTEyUHMzTmh3dTho?= =?utf-8?B?MnYzRmpvY1YzRnJuMjhZMjQ3ajUzZEc2OHF1R3JCcTkxaUlCL3B4Q05DUEx1?= =?utf-8?B?ZjJhblhYUnI1T2ljVEY2L3NqT1NtVmVvOWZSUnpkcmg1SW90VHJzVytXaGto?= =?utf-8?B?Y0VxLzRLSTNFK1dMZjBFNVB6djJFREdSMVAxTS81NWk1TFNFZ0IvVHMrU0E4?= =?utf-8?B?M3dHQ0Q4NFpMbzlVMWF3WDIyTWlCakh5aWUvNkdxTmtnSmRmTThYQUdKb2ZK?= =?utf-8?B?KzlIakJvUFZsWUVYNk4vSHR4UGRZeWpzUi85dUp3MjUzdnYzYnRUOEt2N25O?= =?utf-8?B?cU9EQkpaTFBKYW9RcFpVK1UxbkZadzlPVVdqY0NKNTBVak5vK1pidk9NYU5G?= =?utf-8?B?V3ZZT01nRnZGNnd0MnBxZ0dtTGRJdkl6K2NweFN1emlVUW5IdytFdWNoUzJa?= =?utf-8?B?ckhRNk1yTGN4WWtWb2VLT2g0V0lYTTJqa2k1SVFQRzRrblMvVjAwQ2F6d2FS?= =?utf-8?B?Q2tDSlZqR2FuMFZhQU9hbHBTZFJaakFCc0JCYzdPUEdjMVZaZWx5eWFEd1JC?= =?utf-8?B?d21Fb0lSNnpSclRTNk9ZRzNxTUNidFZLQzZHOFJEMFZYa0dRTWY1STdBbHJv?= =?utf-8?B?c2lOQzJ5dTQ1SmI1WktwWTlkM1htUWg0QldXUXVqSXVBb0NaSjZtWWFYSHhX?= =?utf-8?B?RFNOYXlZV0t3TE4weDNWejlQekRZSzJaNTdKZG1aSmk0cVozNEQraW1DN2dS?= =?utf-8?B?V3dYRUcrNnhvalBzc0tzSGRFaXZOMjhjLzJ3TnVrd0tPTEZrR1IrRHMxbHo0?= =?utf-8?B?a2oweXZJMjVNQmpqNVZmeFE5RHFEKzEzaUxkTDhGRk40ZG1YM3NxRFJac0F4?= =?utf-8?B?SmJlUm9hVHVPOUxxa0VYVzdrZTVvaVd1K0g1ZG1TYTdaOU9zQUhreVQ0RmhC?= =?utf-8?B?VHJVWU42VW9FUUQ5a0tsWFFIczg3WFJ5TDdqeVdua3BPRitYV0ZlQWhPT1lM?= =?utf-8?B?NHk3aGllZVgxaVZ5djNsQXFvRHVvV05OaEJpaVZQVWpqaE5sajg5eFJqRVk3?= =?utf-8?B?WStDMEpDQUd4MnNLMFo1RjBRRzY4QzNrNXVHVVRiSFgrRHd0NjNvODFqQzJC?= =?utf-8?B?eWVNVFZ3T3JkZ1ZLeVRGc1lkZXZqN3NsTE55ZjRGMXNXcjlzVjl6VWg0Qnps?= =?utf-8?B?cVJiUm5UOHVkZkEyUjVhOHB6QzJmTXFETzBXTVc5VklhZ09IS0l2YVl4TTFo?= =?utf-8?B?aUFyZzQyRzdNUno4R3BNNnlQb3EwTjZ5UzhFZkZvL2VROW00c0NCOGRBekRL?= =?utf-8?B?d0MrL0hpRHFXQ3dVaTJVb2E3c0lMMWNIY0hVVlh1K2NoU2pkMG1HRDAzVEtl?= =?utf-8?B?NURrWnZXdzVVd3daTUdJa1Z0cnFYb0hYTWlrTGc5YWlhcGFzWmVlVnZ6dnhq?= =?utf-8?B?NFJseDB0QnVqMGtpYzlrVmZyNnExMDNBS2trOXJnSWc1QXlpUDFFakN1SSsv?= =?utf-8?B?SE9wczJpdms5TFJCcEx6QmhJR0FLM2VkWXR1aW1mTGF5OTVHbG1DSTZIVnlV?= =?utf-8?B?ME9GbmEwSVgxV2NNV1hHZlFHdzhQQk56bnpTVmpnNy9KM3JBYWxweTdDczFN?= =?utf-8?B?UFltT3VUL0cyYXA1MGMyb2RIN3FrOXlGbkplRnpJeFFpNlJMVHJ0dmhYZEUx?= =?utf-8?B?bDB5V2lDdk9hSzRZUVlpZ1hkUFdxeldWMWtNZVNUZnI1ZXhVc2tlcTdzSTAx?= =?utf-8?B?OUdRSElsYS9hb1VpbTdXaEVoZ2Exd21LOWRvZlFKZUJEdUk4S2FEQnFObisy?= =?utf-8?B?cmU1bld4akp4V0wxTTlEQS9BK2RDeEYyNWRCeFZSRTRINWtKaG9yVWlhZ0lQ?= =?utf-8?B?R2lIRVY1ckxHRmxoS0FpNC9MSU1Fb0VoRi81MVRmUGRVdmhGanF1UmdhTzlh?= =?utf-8?B?SE9kUWIzWG1taFR4MDRNVWwvUzJ6OGJKekxiUFhTU3dORHJyK2Q1cnQzakpY?= =?utf-8?B?S0xpalN5Vkgwa0RhL3ZKNTVhSjZ2MVc2elFWTVlLNk96U09KUXdEeWZQWlpY?= =?utf-8?Q?m6lw8FC92KAfY47hEHY0eH8=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: bQyz6lmp3GNsn23QegzqXH8Ynm4IGCUcVfYNjrZ6ucsVnmOitF7p1PuMCW7vCh6nFHPgv0rWrBibtRlObO3DinqV/Q5C2T3H71RyUzIh+Wvi0mN0am9lUHbc43EmnK7AVz5hPmz5Jkl19h3EYGDmero0keC424+7a+18LF9wJPk+xwkotFf+Qu9hPvHnftWDVFCTiUWe+7n32MeS8n7NJMyiVTdy5/GFByyedarv4T47tIwr+Uc9x39jS7bHWIE1fAds2aPRKA/w+3KUDz2dDE13bBgqN7asrpwCBcTKVhcj70Mkxwh6z7uz+xTdnsWqSnYw6Vlgc/QJJLmgHESvHWz1UmCS2ExbIsBLTLu1ia6yA55zqYDcU0J+Ne5W/Og6DoepuXw0Y12VX13otV0AzzA+B7NCHrw8H2r0FuNtcP0TBq7K6Dp1exw7BE1A9vCj+rqD5O7QjknNJ7G/5PPVf6zr9q6Zjo876QGRHTltp2vuhxn6Ur3jAalnOAgh1bsT04U4qu1QkNqFYZcxOCkS/3WPmniOIIaM6EcywjBhJzfY0UPVPADsyDZL5dxEeNAWU0bCqvWbi+Z1q8qxklkY07fiRkOaPVY/m6PLMcLKKHY= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: efb74e8c-74fb-428c-c558-08dc5f7ad5a2 X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2158.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Apr 2024 07:40:35.5251 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 8j7+3+0IMGmR2zQaDBA4EwgR3kE6Uxdq++shXTY+gtXAqAtM47wFY+L4zMzEyYrHKU5in3IYP3Z1X7bXxauOUQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR10MB5694 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-04-18_06,2024-04-17_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 mlxscore=0 mlxlogscore=999 suspectscore=0 adultscore=0 phishscore=0 bulkscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2404010000 definitions=main-2404180053 X-Proofpoint-ORIG-GUID: VGEvvRwuJQkIE-ZJuDmbRwJsGXosp6k3 X-Proofpoint-GUID: VGEvvRwuJQkIE-ZJuDmbRwJsGXosp6k3 X-Spam-Status: No, score=-12.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 4/12/24 07:47, Jens Remus wrote: > Print a warning message if SFrame FDE is skipped due to a non-default > DWARF return column (i.e. return address (RA) register number). This > may be caused by the use of CFI directive .cfi_return_column with a > non-default return address (RA) register number in the processed > assembler source code. > > Warning: skipping SFrame FDE due to non-default DWARF return column > > gas/ > * gen-sframe.c: Warn if SFrame FDE is skipped due to non-default > DWARF return column. > > gas/testsuite/ > * gas/cfi-sframe/common-empty-3.d: Update test case to expect > for new warning message when SFrame FDE is skipped due to > a non-default DWARF return column. > OK. Thanks > Reviewed-by: Andreas Krebbel > Reviewed-by: Indu Bhagat > Signed-off-by: Jens Remus > --- > > Notes (jremus): > Changes v2 -> v3: > - Enhance comment in code as suggested by Indu. > - Corrected formatting of ChangeLog in commit message. > > Without this patch the assembler would generate incomplete SFrame > information without warning for the s390-specific SFrame error test > case 4, that gets introduced by patch "s390: Initial support to > generate .sframe from CFI directives in assembler". > > gas/gen-sframe.c | 10 +++++++--- > gas/testsuite/gas/cfi-sframe/common-empty-3.d | 1 + > 2 files changed, 8 insertions(+), 3 deletions(-) > > diff --git a/gas/gen-sframe.c b/gas/gen-sframe.c > index 1269b2b77c54..fe8b24906c1b 100644 > --- a/gas/gen-sframe.c > +++ b/gas/gen-sframe.c > @@ -1343,9 +1343,12 @@ sframe_do_fde (struct sframe_xlate_ctx *xlate_ctx, > > xlate_ctx->dw_fde = dw_fde; > > - /* If the return column is not RIP, SFrame format cannot represent it. */ > + /* SFrame format cannot represent a non-default DWARF return column reg. */ > if (xlate_ctx->dw_fde->return_column != DWARF2_DEFAULT_RETURN_COLUMN) > - return SFRAME_XLATE_ERR_NOTREPRESENTED; > + { > + as_warn (_("skipping SFrame FDE due to non-default DWARF return column")); > + return SFRAME_XLATE_ERR_NOTREPRESENTED; > + } > > /* Iterate over the CFIs and create SFrame FREs. */ > for (cfi_insn = dw_fde->data; cfi_insn; cfi_insn = cfi_insn->next) > @@ -1355,7 +1358,8 @@ sframe_do_fde (struct sframe_xlate_ctx *xlate_ctx, > if (err != SFRAME_XLATE_OK) > { > /* Skip generating SFrame stack trace info for the function if any > - offending CFI is encountered by sframe_do_cfi_insn (). */ > + offending CFI is encountered by sframe_do_cfi_insn (). Warning > + message already printed by sframe_do_cfi_insn (). */ > return err; /* Return the error code. */ > } > } > diff --git a/gas/testsuite/gas/cfi-sframe/common-empty-3.d b/gas/testsuite/gas/cfi-sframe/common-empty-3.d > index 5914c620760d..d17521dd88ea 100644 > --- a/gas/testsuite/gas/cfi-sframe/common-empty-3.d > +++ b/gas/testsuite/gas/cfi-sframe/common-empty-3.d > @@ -1,4 +1,5 @@ > #as: --gsframe > +#warning: skipping SFrame FDE due to non-default DWARF return column > #objdump: --sframe=.sframe > #name: SFrame supports only default return column > #...