From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mailbox.box.xen0n.name (mail.xen0n.name [115.28.160.31]) by sourceware.org (Postfix) with ESMTPS id BB7843858D37 for ; Wed, 20 Jul 2022 04:03:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org BB7843858D37 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=xen0n.name Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=xen0n.name DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=xen0n.name; s=mail; t=1658289817; bh=ojcMEvYH2Ol6lrxdkcogNWprFyQKLpQU4UYptqbh1jI=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=ag9PhcHiJYJM5zTPMk/TDNbLNhCUcFfCZ/BNNJ7f5ZQ2ZgYfJCUzJ4h72iQEb+eLq xlN+yHeaFZgg9EDHp8JFVUYNc6mSXWFPXVaGxz3d9+CsyKM+PJxDEuXQXOdISxAi5k qsG3gGGqYHrA8XAkNA6lGzA3XqH8Tj3kvIpFqE+Y= Received: from [100.100.57.190] (unknown [220.248.53.61]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mailbox.box.xen0n.name (Postfix) with ESMTPSA id 8F15B60610; Wed, 20 Jul 2022 12:03:37 +0800 (CST) Message-ID: Date: Wed, 20 Jul 2022 12:03:37 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:104.0) Gecko/20100101 Thunderbird/104.0a1 Subject: Re: [PATCH 1/5 v1] LoongArch: bfd: Add new reloc types. To: liuzhensong , WANG Xuerui Cc: Xi Ruoyao , binutils@sourceware.org, xuchenghua@loongson.cn, mengqinggang@loongson.cn, Fangrui Song , huangpei@loongson.cn References: <20220718084316.390672-1-liuzhensong@loongson.cn> <8b637076-eb4c-47e0-2987-ac0973e38bca@xen0n.name> <62de74c5cfc7e558f82025ccffe5547d58bff172.camel@xry111.site> <417f93f5-64ca-9eb1-c338-b55edfd8eb83@xen0n.name> Content-Language: en-US From: WANG Xuerui In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-6.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Jul 2022 04:03:46 -0000 On 2022/7/20 10:07, liuzhensong wrote: > > Some relocation name changes make sense. But, how to name a name is a > matter of personal aesthetics, and it is difficult to satisfy > everyone. Does the name of the relocation matter? should we pay more > attention to the specific implementation?  Remove useless and add needed? > Names do matter. You can't expect to lower maintenance costs and barrier to entry for newcomers with "bad" names. I showed the original names in the patch to some of my colleagues (with no low-level programming experience; they are all application developers), and they invariably can't get the distinction of "LO12/HI20/LO20/HI12". I then showed them my proposal, granted they needed a little explanation as to what things like "SK12" mean, but after that they can immediately get the feel of the relocs ("ah, it's like for this purpose, put this part of imm into this slot"). LoongArch is expected to remain niche, at least for the coming 3~5 years, so you can't expect to have many people working on low-level nitty-gritty details like this. I personally don't think your team's composition is going to remain stable over the years, either; in either case, people come and go, so IMO there is indeed value in this bikeshedding. The community as a whole can work over concrete proposals of better naming, and I think my proposal serves as such a constructive starting point. Also, if you think the current names are more appropriate, with objective reasons, then *please communicate* your justification and thought behind them. We "outsiders" actually intend to cooperate, and have voiced our thoughts, but we don't know what you and your team think. For now all we have is this "LO12/HI20/LO20/HI12" and outsiders can draw no conclusion other than "hmm this is going to cause confusion". We really need to communicate more in the open for pushing things forward, constructively.