From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 1AD51386C5AC for ; Fri, 7 Jul 2023 08:47:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1AD51386C5AC Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1688719667; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QDeypLb9BFIi/fYQ3qKPPliK/pUQE8ksi40hpbwvcas=; b=ZnX0OQzPq4oIBDHKxKK71kAIsTHmz43S/Zx95TCCoP9bQrKVfmXekFQjE3YmojtmWW3Xgk /NbT5JZsCb51EP61tZB5/Bm0TDcx/T8PdjOnrauDeelg05wqOMdWfm2/ccVxBtCpxEOsTf 0qvEtqUBcsUbte3Fq4YONsb+ADAJoLw= Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-295-6dylnH5cNZ6EtoRDKWn6qA-1; Fri, 07 Jul 2023 04:47:46 -0400 X-MC-Unique: 6dylnH5cNZ6EtoRDKWn6qA-1 Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-4039a277fcbso4969811cf.0 for ; Fri, 07 Jul 2023 01:47:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688719665; x=1691311665; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=QDeypLb9BFIi/fYQ3qKPPliK/pUQE8ksi40hpbwvcas=; b=bFM0nH5NvK6V6CKv5bgFW646nLjD+9idOrVrYtpf2ZHQgmeq/J7CNZkIY5MUVJwxvW bTMn2mFwKI/gvXso1qRvbqH5qvSnEJ0O7KHeT0jWs7QlcltoBH+Hx5DWELcZ1kMHOXbE aFC+tcAqBPkB7wFQ/bHmeGSkN7xb9r4r4gnxo7CRIjlNNBc7aZY+qcpy4JRpezGKu5ss QyUlQKeZqn/40KXZGqHSwnczvRphq3pYoHhMIDdWwbhCHtg72GvU5k4X+vxHm8OF+FMG WNs2ASC+ygk0IIhXGTGpojnz8CjxBPWa3B0W1NZeZmEjqgWiHjafiXMCYbmKnYDQdhsd SB4Q== X-Gm-Message-State: ABy/qLaqjT2XC9wimvd0EmEOgLXOqd0QzHGP0MYWoq5RF2iJU74M2M4C UeHdWwHnHDhWcVxkw3606j+fZ9czRpaE6eUtCO6EQCFdA+tlaOBEzdUM7O5buaM1zv8t16y9nPk aLc4sFLJJTuwe/+HGo+J0kLWhOg== X-Received: by 2002:ac8:58cd:0:b0:403:3605:5f6a with SMTP id u13-20020ac858cd000000b0040336055f6amr4783850qta.65.1688719665518; Fri, 07 Jul 2023 01:47:45 -0700 (PDT) X-Google-Smtp-Source: APBJJlGUFNuyxpjpvxCXjo8kk0fVvIqoqYGfGGZV/xOMJUELpbT9bXPBUWoCmGEhhG9qrSqs9276qQ== X-Received: by 2002:ac8:58cd:0:b0:403:3605:5f6a with SMTP id u13-20020ac858cd000000b0040336055f6amr4783837qta.65.1688719665309; Fri, 07 Jul 2023 01:47:45 -0700 (PDT) Received: from [192.168.1.7] (adsl-2-solo-172-78.claranet.co.uk. [80.168.172.78]) by smtp.gmail.com with ESMTPSA id t18-20020a0ce2d2000000b00636291d04adsm1864721qvl.47.2023.07.07.01.47.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 07 Jul 2023 01:47:44 -0700 (PDT) Message-ID: Date: Fri, 7 Jul 2023 09:47:42 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH] ld: Use [list ] syntax to define run_tests in indirect.exp To: YunQiang Su , binutils@sourceware.org Cc: amodra@gmail.com References: <20230630051451.1867944-1-yunqiang.su@cipunited.com> From: Nick Clifton In-Reply-To: <20230630051451.1867944-1-yunqiang.su@cipunited.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-GB Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi YunQiang Su, > Currently, the var run_tests is defined by syntax {{}}, > while in this case, variables cannot be used. > Thus $NOPIE_CFLAGS and $NOPIE_LDFLAGS are passed to cmd as names > instead of values: > gcc ... $NOPIE_CFLAGS -c .../indirect5a.c -o tmpdir/indirect5a.o > > Let's use [list [list ]] syntax instead. > > ld/ChangeLog: > > * testsuite/ld-elf/indirect.exp(run_tests): use [list [list]] > syntax instead of {{}}. Approved - please apply. Cheers Nick