From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com [IPv6:2a00:1450:4864:20::32c]) by sourceware.org (Postfix) with ESMTPS id A25F63858D1E for ; Mon, 15 Jan 2024 07:19:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A25F63858D1E Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org A25F63858D1E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::32c ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705303162; cv=none; b=R4G8NFj46Fj4UcRTAqrFCs5iB/EJPASlXCHMGONedpfREF8LWlSGve9j0l8kLMAAj+4ukVcm9YjAOLXsf9nwQI8eEHnXhMIHZxrDIJ7BzHCH9QlvF18hnHVpPfAHU9DOdvOevKf1gnQkAa8h7sOBjRrzxE0Oz0zyT4Lk0Gi6bpA= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705303162; c=relaxed/simple; bh=VWlOxKT1jblMFB1s0Ab/0ih9i2/aqOM77qUvgkAgQjc=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=hZb5LFTpCiGC5N3hWJx2yj4Aty4fxCfdskzbn3VfdSq8/LBZT6pDl3ALyzs4Sk0HSygeB/2GkckoLCDtrETjQvTtLyM8Lxs18/O7u2AUGO69bLfRBg1McPwut6qjiQDzvl3yEYmSQJSMzqjcOfgJo2iqZrdY4828N+Ct7H6r1jA= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-wm1-x32c.google.com with SMTP id 5b1f17b1804b1-40b5155e154so104928605e9.3 for ; Sun, 14 Jan 2024 23:19:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1705303156; x=1705907956; darn=sourceware.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=VcfT9NiK/H1PLAPAwOJBM9HIRrM6MOlRZ5PYFZvUL68=; b=WuBzRmwomrfwANooIVznj4irqBjhny5lIdkcIvsCk13fKQrmd6+AHZNK9gbLM9B14v Ns0pYLAHJKVeTVEkcQKuCs2gPoyVQT3PKgSQ4TVxJOyBf1cBKdNM4icjv+aFWR0oHwoF yZw4SLGZOxB7AVVHe6mDUIQATu2dbumfDJhhUwYs8JlmHSLrRzGC2ul0CAAgkOJp3hUT boVNMO328qa/49MS4M5Vn3MX+uho3PECHYewICjGE8JMs+6qN902REGBl334gaOyuRFJ 1HJcsJL/wkOVOhFMfmdfxch49TMZqLOT/A0PPBR7y1HKMYA8fdGln/LST4KFUGeTVPTP cGFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705303156; x=1705907956; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=VcfT9NiK/H1PLAPAwOJBM9HIRrM6MOlRZ5PYFZvUL68=; b=P9ijJQh0N+dlLXJI+ur9KjHaSNRcsQrFqgtjZL7Qhq5GE8/QXRoxrE0OPa/uOMqQJU SjbMcSkwFSM+onhjqoGJp4lPJ5/iKqySQLeOod/eQHjeaXx9lha/g1mixmStbUEeiJz/ jqT1meKhQ+46rgpdQkfnThmDSYkUA5cdUY7j/KVrHlVjU3MNLrRrvFtuRA4TUcK3tu8y Ox4BUCi0zrwK08ag3IvriI8qcPnEzOdLozlFNcBL/a7vc1Wl+z/kQKLnzPrDYDPPGfZ+ 2s7rH/A6aHDOnvzS6IPSJeVRQsvALKpdS+9UViJ4ZiXpwgKhw46iryDv4JmOHEGJaJNy sVOA== X-Gm-Message-State: AOJu0YzVfXZGG6dcAH6l/GT07xo/pqXDJcELp7+A3zCwQ+eFcFX6khhU y73nb+KVNAU+eQam/0mIkuX5VZalquXu X-Google-Smtp-Source: AGHT+IHF7PEGHr4Hydx3efAi/Zxzc2/fFywon2s/AOSH3NaltJlvACTkBaR10IuRWndh309UJb0ZHw== X-Received: by 2002:a05:600c:4445:b0:40e:66f2:ee42 with SMTP id v5-20020a05600c444500b0040e66f2ee42mr2169123wmn.195.1705303156323; Sun, 14 Jan 2024 23:19:16 -0800 (PST) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id q2-20020a056000136200b003373fe3d345sm10960154wrz.65.2024.01.14.23.19.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 14 Jan 2024 23:19:15 -0800 (PST) Message-ID: Date: Mon, 15 Jan 2024 08:19:18 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] x86: support APX forms of U{RD,WR}MSR To: "Cui, Lili" Cc: "H.J. Lu" , Binutils References: <9bf44f10-4ed9-45f2-b490-7af710da720b@suse.com> Content-Language: en-US From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3025.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 15.01.2024 07:41, Cui, Lili wrote: >> @@ -9090,6 +9094,9 @@ get_valid_dis386 (const struct dis386 *d >> case 0x6: >> vex_table_index = EVEX_MAP6; >> break; >> + case 0x7: >> + vex_table_index = EVEX_MAP7; >> + break; >> } >> >> /* The second byte after 0x62. */ @@ -9159,7 +9166,12 @@ >> get_valid_dis386 (const struct dis386 *d >> >> ins->codep++; >> vindex = *ins->codep++; >> - dp = &evex_table[vex_table_index][vindex]; >> + if (vex_table_index != EVEX_MAP7) >> + dp = &evex_table[vex_table_index][vindex]; >> + else if (vindex == 0xf8) >> + dp = &map7_f8_opcode; >> + else >> + dp = &bad_opcode; > > > The processing of this part of MAP7 seems strange. Maybe we can restore it when more map7 instructions appear in the future. You realize this is simply a copy of what we do for VEX map 7? And yes, should map 7 end up less sparse in the future, we'll certainly want to introduce a "proper" table. Jan