From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 63584 invoked by alias); 6 Mar 2020 14:51:17 -0000 Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org Received: (qmail 63557 invoked by uid 89); 6 Mar 2020 14:51:16 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-6.9 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,SPF_PASS autolearn=ham version=3.3.1 spammy= X-HELO: mx2.suse.de Received: from mx2.suse.de (HELO mx2.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 06 Mar 2020 14:51:14 +0000 Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 894ECB008; Fri, 6 Mar 2020 14:51:12 +0000 (UTC) Subject: Re: [PATCH 1/6] x86: allow opcode templates to be templated To: "H.J. Lu" Cc: "binutils@sourceware.org" References: <17ee93b3-33ea-5c10-23b2-408c7fb5b5a2@suse.com> From: Jan Beulich Message-ID: Date: Fri, 06 Mar 2020 14:51:00 -0000 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2020-03/txt/msg00150.txt On 06.03.2020 15:42, H.J. Lu wrote: > On Fri, Mar 6, 2020 at 12:11 AM Jan Beulich wrote: >> >> In order to reduce redundancy as well as the chance of things going out >> of sync (see a later patch for an example), make the opcode table >> generator capable of recognizing and expanding templated templates. Use >> the new capability for compacting the general purpose conditional insns. >> >> opcodes/ >> 2020-03-XX Jan Beulich >> >> * i386-gen.c (struct template_arg, struct template_instance, >> struct template_param, struct template, templates, >> parse_template, expand_templates): New. >> (process_i386_opcodes): Various local variables moved to >> expand_templates. Call parse_template and expand_templates. >> * i386-opc.tbl (cc): New. Use it for Jcc, SETcc, and CMOVcc. >> * i386-tbl.h: Re-generate. > > OK. Thanks. > >> --- >> The set* templates lack No_bSuf - is there an expectation that in AT&T >> mode a 'b' suffix may be used on them? Otherwise this should be added > > What does setb do? setb is just a normal mnemonic. I'm wondering about setbb or setnzb or alike. Jan