From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-x232.google.com (mail-lj1-x232.google.com [IPv6:2a00:1450:4864:20::232]) by sourceware.org (Postfix) with ESMTPS id 54E49385DC16 for ; Fri, 5 Jan 2024 12:08:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 54E49385DC16 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 54E49385DC16 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::232 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704456530; cv=none; b=OZvehaghStGbXqRh6oqDISwUF0A5AypDdxj0wn2yOanD96xjRRK03IMyARpGKxk9C5TSiNqHi6rXGNQjMjAzB3ivqv0QhtTxOMQw/OIUXxmDG3u1EmnsQ04aBxphhNgz3W3/nkBmgTkBul/qiJtS8aIJYCK/e1/w6nkor+JYOoU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704456530; c=relaxed/simple; bh=g7/48AiGAZmW6p/4pgYaxxkWvHMtW08qyOp6h87wzrM=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=mQ5l5QQpwCe+cEGHkjRu0CE4NbNs2XexUPvODweY8vCSqeJ+nfPooQ4j3OGh9IZkkTC48ZefMTSZdYOWZmKuO4gehVv/vu78yWyKQJ+9HKDrKM2kzFvJ3XkZatcwe/jb7ud2iZMNncCGtCcCQ/HxiD5ieMWGzyQeQb9FgEnbqLU= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-lj1-x232.google.com with SMTP id 38308e7fff4ca-2ccec119587so18097921fa.0 for ; Fri, 05 Jan 2024 04:08:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1704456527; x=1705061327; darn=sourceware.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=QatckXV/uXZDXhv7X07hQxYdgUTTxzjjewefvm7V9z8=; b=fHqU+5bTfzYHac/8sG4/bq/XTleT6XPzJhz/0l5J09TUuDaqbeju+/p0Wyyoyok1Um NwsBrvb8XEpTcSeVXniRtoeb91IBerZKFpkJ5Ip7vUHJW4N04erw33RWIx1jaHFG2mDN 3/KUaJuX41/zQQPDTkUmPD5kD5gg2j3NkG6HCk381dPiuZ0mJ4M3AlPLnBqyZYGQiCqT ysNjdqIJnNHmDK+JqypKb9BiNLZjNTxC+Gr8pSOCYIhYw4jwl8L70fYUvUgFNMpnyygU h4yIadzB0f3hTLN6W1x7oJLIOnvnEMOsUzFUU2gHJUuVUVUJ4RFx4lRNgJUVGft3It5T PSZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704456527; x=1705061327; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=QatckXV/uXZDXhv7X07hQxYdgUTTxzjjewefvm7V9z8=; b=nkNCi3fM1C9i20H84k8/Fg2d9v42W+yLP39swOGaiLiKrlCMFgn0aOpOdbaZuOt2M2 Q26jGN9dJThJDcq523peVSs18s/R02cQD7FOamEgKs59hAPFtsxmPHT8xle6iu6QgbpM lKwcTi7K5UKxnmCK2asUcku/03LKWRQCOxKffjdKBzG8RnyvzMTE7P9cLHynKrstHVCk Qip8rQvFAcfz/JYz85uWifLB+gX0bLxSQoK3OwK+cxWAYrC8ZRZmd/A8ABpb14xe2Ke9 YxDXpBa8Wtvv+LtV84+1afZB3PVjOfDUKiNoxslRgJ/SaZoEAw8y36pmXb+EvfcTF48Z kQjw== X-Gm-Message-State: AOJu0Yy7u48514087WjRyi5RIlUEYj1leUvd28CyjnL9SAoX/DqeLnAK LB+HOMUQweRPmDh1Qx61XNlr9sK3JaXkIMO0/NwxMNmOqA== X-Google-Smtp-Source: AGHT+IHe9iz0LIB1kFYDd2QM5Ub8sbD3ahkiVYNshiAGU3oQXaya7C0Y6QBVl9hux5BTDP/UMSITjg== X-Received: by 2002:a2e:87c7:0:b0:2cc:d555:bc66 with SMTP id v7-20020a2e87c7000000b002ccd555bc66mr1056623ljj.76.1704456526840; Fri, 05 Jan 2024 04:08:46 -0800 (PST) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id et4-20020a0566382a0400b0046dcd4d4229sm384567jab.125.2024.01.05.04.08.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 05 Jan 2024 04:08:46 -0800 (PST) Message-ID: Date: Fri, 5 Jan 2024 13:08:43 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH V5 9/9] Support APX JMPABS for disassembler Content-Language: en-US To: "Cui, Lili" Cc: hongjiu.lu@intel.com, "Hu, Lin1" , binutils@sourceware.org References: <20231228012714.2989658-1-lili.cui@intel.com> <20231228012714.2989658-10-lili.cui@intel.com> From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <20231228012714.2989658-10-lili.cui@intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3026.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 28.12.2023 02:27, Cui, Lili wrote: > --- /dev/null > +++ b/gas/testsuite/gas/i386/x86-64-apx-jmpabs-inval.s > @@ -0,0 +1,15 @@ > +# Check bytecode of APX_F jmpabs instructions with illegal encode. > + > + .text > +# With 66 prefix > + .byte 0x66,0xd5,0x00,0xa1,0x01,0x00,0x00,0x00,0x00,0x00,0x00,0x00 > +# With 67 prefix > + .byte 0x67,0xd5,0x00,0xa1,0x01,0x00,0x00,0x00,0x00,0x00,0x00,0x00 > +# With F2 prefix > + .byte 0xf2,0xd5,0x00,0xa1,0x01,0x00,0x00,0x00,0x00,0x00,0x00,0x00 > +# With F3 prefix > + .byte 0xf3,0xd5,0x00,0xa1,0x01,0x00,0x00,0x00,0x00,0x00,0x00,0x00 > +# With LOCK prefix > + .byte 0xf0,0xd5,0x00,0xa1,0x01,0x00,0x00,0x00,0x00,0x00,0x00,0x00 > +# REX2.M0 = 0 REX2.W = 1 > + .byte 0xd5,0x08,0xa1,0x01,0x00,0x00,0x00,0x00,0x00,0x00,0x00 Considering that I specifically asked that this use .insn, and that I further took the time to make a patch to make .insn work with {rex2}, I find it rather poor that here and ... > --- /dev/null > +++ b/gas/testsuite/gas/i386/x86-64-apx-jmpabs.s > @@ -0,0 +1,5 @@ > +# Check 64bit APX_F JMPABS instructions > + > + .text > + _start: > + .byte 0xd5,0x00,0xa1,0x02,0x00,0x00,0x00,0x00,0x00,0x00,0x00 ... here it is still .byte that is being used. Jan