On 2023-02-23 11:10, Nick Clifton wrote:
> Hi Ulf,
>
>
>>> Did you actually try running these new tests ?
>>>
>> No, I am yet to learn how to do the tests
>> so I hoped that copying the the resulting text segment
>> would be sufficient, and if not, someone would tell me.
>>
>> Is there any documentation on how to run the tests?
>
> Just run "make check".  (In the top level directory where
> you built the binutils).
>
> Or if you only want to run one specific testsuite, eg the
> linker testsuite then change into the relevant directory and
> run "make check"
>
> Or, if you only want to run a sub-set of a specific testsuite
> then use the RUNTESTFLAGS option to specify the test script
> you want to run.  For example if you only want to run the
> linker script tests then:
>
>   % cd <binutils-build-dir>/ld
>   & make check RUNTESTFLAGS="ld-scripts/script.exp"
>
Thank You.
I figured out how to run the test (I didn't have 'dejagnu' installed before)
and I got to run the script.exp and all the CRC stuff failed (not 
unexpectedly),
while the rest were OK.

==============

Had a problem with my system disk, and decided to upgrade
to from Ubuntu 18.04 to 22.04 and installed ubuntu-mate-desktop

Now everything fails :-(.

==============

Running 
/home/ulf/projects/binutils/binutils-gdb-digest/ld/testsuite/ld-scripts/script.exp 
...
FAIL: script
FAIL: MRI script
FAIL: MEMORY
FAIL: MEMORY with symbols
FAIL: ld-scripts/asciz
FAIL: ld-scripts/ascii
FAIL: ld-scripts/crc64-ecma
FAIL: ld-scripts/crc64-iso
FAIL: ld-scripts/crc64-poly
FAIL: ld-scripts/crc64-polyi
FAIL: ld-scripts/crc32
FAIL: ld-scripts/crc32-poly
FAIL: ld-scripts/crc32-polyi
FAIL: ld-scripts/pr20302
FAIL: ld-scripts/output-section-types
FAIL: SEGMENT_START expression not absolute (default)
FAIL: SEGMENT_START expression not absolute (overridden)

It looks like there is some basic error.
I get this: "WARNING: Couldn't find tool init file", but I do not know
if it is significant.

==============

If I get a FAIL, is there a log to look at to find out why it fails?

==============

Best Regards

Ulf

> Note - when you are creating a patch that affects generic
> binutils code, such as your CRC64 patch series, it is a good
> idea to test multiple versions of the binutils each built for
> a different target architecture.  At a minimum I would suggest
> using builds configure with:
>
>   --target=x86_64-pc-linux-gnu
>   --target=x86_64-w64-mingw32
>   --target=aarch64-linux-gnu
>   --target=powerpc64-linux-gnu
>   --target=mips-elf
>   --enable-targets=all --enable-64-bit-bfd
>
Cheers
>   Nick
>
>