From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x334.google.com (mail-wm1-x334.google.com [IPv6:2a00:1450:4864:20::334]) by sourceware.org (Postfix) with ESMTPS id A66AE3858407 for ; Thu, 21 Dec 2023 07:25:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A66AE3858407 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org A66AE3858407 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::334 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1703143521; cv=none; b=sWTYOJGbYB2UtOYyYXcgdUROaWGLSUsASkpl1aQxWDY14m5T7H9bLH5yzBWVlauN2RtJAMS8FK8+yuOgleQipqcHcjwoa+HubzKC2JRNTMhBiDoA2o3fuFf0TnXqbhKTVG0a0PmZWMt0wHALcK+S5UxEUETbtZ/XFItuDYZ4oZA= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1703143521; c=relaxed/simple; bh=NsCajpRf7GahuMvmuIIfMCIK9EAv5pLDc7YCsy97adY=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=VuA4y9TI+UPAqnAyWMqLJ5KAmVL82wJj5Qky837ivjJnDo03YX6NHecF4oYypOXGvS+YPNv3mfe4MkZDoUmzl7YzUu1b0aVY85lMS9UtPEHp2bPj1MxmY47ZpryaFvmfXetQ34VDsAWNeiN9Ynj4chrsVBQNsh5wm7eManf3csI= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-wm1-x334.google.com with SMTP id 5b1f17b1804b1-40d190044c5so4890035e9.2 for ; Wed, 20 Dec 2023 23:25:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1703143518; x=1703748318; darn=sourceware.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=vdGkrN83UmQ+lkVKqWuIjr0AxaCtWnPjAKD7DUs9K9s=; b=Wzk0wMdvN9RzEcwbTmAXsFP7gyqO2YzCPNFwGNd825+y1bdHUIiJupMTv3zOaeUXCG IW6QqLK1OcZ7spvkJ+FWcGvgoJ5joxaqojIi0FNwKo2lSufEscbKrWTKEfBVFtz2FS04 RkHGkt+NTKNuZNylUaL4VbOt0+eVHUgfatjovgS3ECW1SckBLJMCzEVk41PuLB++KXRf G8nStpnKX1B2D4P8HtPIj5uoin3OKQYt8KCCh0RJfNTaSa4juLGvUjYNxBQT2nSzOb8K K2UtXK7HSAuxoaGVmVfzhdSDyot6V2d21FhgvFVAVMw7q0JGAwTvD1JAJrtjC8QFfeIm U4zQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703143518; x=1703748318; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=vdGkrN83UmQ+lkVKqWuIjr0AxaCtWnPjAKD7DUs9K9s=; b=WZO3YdQsUVakwgnjTpb2iOpVBJQKj6fIwo1gnFpeVd3CfBAm/aUp4DX0ppSU7b0iJk 3pGuwZHVgf6h/1rCej/KteqXvfLZePKL1r1G/6BmHKHPZeivQIfP9MM2m6fxzpzpocrg 9k3lT5CdVeNZNuJzAwCSK0XvqZfaA7cD6wMAa4AaggvjCImd0lYlOt4lKOXOT269GvIS fk1YOg6a3zg9YIRT4n4Z+4heKNCXVlE3A4HMhoh59TApTVZyYddMCYh7RNaPWd0cffOc u7lJg9UA7Ch7WYUV0ZvvljI2xo/tiTVtPcFIOUHM1pfKUgVjudtjXnqIvSeLBdGEkk/D QLAA== X-Gm-Message-State: AOJu0Yz2fHFUtKZJcEeerOc6tsBck2V62TZLCFNZYePssIYNg+0nDZ8J 4wRCxoYnfGkTgeD10QwfuZy5 X-Google-Smtp-Source: AGHT+IG+EduSDvJhSdWzx/e+zuZhF0rb0LNZc2j+aaBm0773i8/SdCLbHdAXr3wMillcZDAnRlSMqA== X-Received: by 2002:a05:600c:3baa:b0:40b:54ef:ff07 with SMTP id n42-20020a05600c3baa00b0040b54efff07mr491213wms.32.1703143518401; Wed, 20 Dec 2023 23:25:18 -0800 (PST) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id p2-20020a05600c1d8200b0040596352951sm10621413wms.5.2023.12.20.23.25.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 20 Dec 2023 23:25:18 -0800 (PST) Message-ID: Date: Thu, 21 Dec 2023 08:25:17 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] ld: Add lib32 directories for 32-bit emulation on FreeBSD/amd64 Content-Language: en-US To: John Baldwin , Rainer Orth Cc: binutils@sourceware.org References: <6499aee9-3935-41c1-8897-a177f6173e8a@FreeBSD.org> From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <6499aee9-3935-41c1-8897-a177f6173e8a@FreeBSD.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3025.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_NUMSUBJECT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 20.12.2023 18:47, John Baldwin wrote: > On 12/20/23 1:12 AM, Rainer Orth wrote: >> Jan Beulich writes: >> >>> On 19.12.2023 23:23, Rainer Orth wrote: >>>> Ping? It's been a week: >>>> >>>> https://sourceware.org/pipermail/binutils/2023-December/131178.html >>>> >>>> Rainer >>> >>> Not knowing FreeBSD it's hard to approve a change like this. Specifically, ... >> >> Unfortunately, there's no listed FreeBSD binutils maintainer. I'm >> Cc'ing John Baldwin who actively maintains gdb on FreeBSD. Maybe he can >> shed some insight or knows someone else who could. >> >>>>> GNU ld currently fails to link 32-bit executables on FreeBSD/amd64 when >>>>> the linked libraries have dependencies on shared objects themselves: >>>>> >>>>> $ gcc -m32 -o ei ei.c -lexecinfo >>>>> /var/gcc/binutils/amd64/lib/gcc/amd64-pc-freebsd14.0/13.2.0/../../../../amd64-pc-freebsd14.0/bin/ld: >>>>> warning: libelf.so.2, needed by /usr/lib/../lib32/libexecinfo.so, not found >>>>> (try using -rpath or -rpath-link) >>>>> /var/gcc/binutils/amd64/lib/gcc/amd64-pc-freebsd14.0/13.2.0/../../../../amd64-pc-freebsd14.0/bin/ld: >>>>> /usr/lib/../lib32/libexecinfo.so: undefined reference to `elf_begin@R1.0' >>>>> [...] >>>>> >>>>> Fixed by handling FreeBSD/amd64 like Linux/x86. >>>>> >>>>> Tested on amd64-pc-freebsd14.0. >>> >>> ... it doesn't look implausible that things may have worked on earlier >>> versions (or else perhaps someone would have noticed long ago), and that >>> hence your change might break things there. >> >> I'm certain they didn't: I originally developed this patch 4 years ago, >> but either forgot to submit it back then or hoped an active member of >> the FreeBSD community would. This must have been in the FreeBSD 11 or >> 12 timeframe, and obviously nothing has happened/been improved since. > > FreeBSD has always used /usr/lib and for the "native" ABI and /usr/lib32 for > 32-bit ABIs on 64-bit platforms. This includes both i386 on x86-64 as well > as 32-bit powerpc on powerpc64 and more recently 32-bit arm (armv7) on > aarch64. Given that, I believe the patch to be correct (and it likely applies > for powerpc64* using "powerpc" emulation and aarch64* using "armv7" emulation). John - thanks for the feedback. Rainer - based on the above, your change is approved. Jan