From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x42c.google.com (mail-pf1-x42c.google.com [IPv6:2607:f8b0:4864:20::42c]) by sourceware.org (Postfix) with ESMTPS id 4F9033858D35 for ; Sat, 1 Jul 2023 13:33:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4F9033858D35 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pf1-x42c.google.com with SMTP id d2e1a72fcca58-666ecf9a0ceso1502560b3a.2 for ; Sat, 01 Jul 2023 06:33:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1688218434; x=1690810434; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=QVJoXiR9Cz0Cdy3uvJ5L97JUMA2OUUp2YJory/Hdcus=; b=LFSBHQf/yXWuwxQPMIKXiDzd6PTaYTiw8ZrpWzgtyADoTT7GyNGBlTIGQipwqYtwjF OjzedljSheD+w+kNWF2NnR7fZOhJ0nkivuIDJMwQ4DjkZTcDEQf1XOCFlPXb6m24ggJq rBmR4eEv5/jDy/rWsGZMp7eY3FkPaKw/vm0P0tG2BqGy5qipP/ZyO3m5UHSI6GlHxeyI TrRgqAk51O5mjKC2kqECS6HhCsSh6Kw1e3cAW+zFMv0m2kebNbTjkPPBkwxK0jYr9XXz IPuz0DOpR3hgCKWRez8+s6ixyLHYso0YNYCEDi+x4ZCjzBqaUMpB6x5r01t7k0sds8ao 7v7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688218434; x=1690810434; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=QVJoXiR9Cz0Cdy3uvJ5L97JUMA2OUUp2YJory/Hdcus=; b=BC75TP17TC/RQLjQgG259Nj7TXuGVVTEhBtt+pHa4+d1uda/cTs4hN8CU3JRnyyuhg 50WJaQPBzs7VztXZC3EiFLlr6hnmr9MLiB00KP3OtHSlCXBbDG89h40NrO9nD17wDzEr E0foyf6ErGPDQszWB+97hPLNBV0AB+nBNiVqrp69+I3g8RMH5Vf/8qr+iYyxQNrJXHjk Jh9D71EmbJOIjKYLw1Ip62d0+7/znoeXpo05Fv++rq3R9M3YM3hbrnmM+MwII6Z2UeUl IzeFwDqgyUEkbVDI3nKQg6rEssptUkrhZwUbSNGxDegB1rQgdGVD6lZT1TFhnJzOQk1O 4pCQ== X-Gm-Message-State: ABy/qLaEUHvKOuetxJjbUFi1dvPD2mjokvszOojeilib3tCIIIO2gcmR SaJWXUOIh0uuVXgnSC7WnfQ= X-Google-Smtp-Source: APBJJlGueEVV8YkZYe2Lcz/xWq054g7R/Dzb45kArbjoHbImrWf+5P/Nk7kfqtCRSeTuqm8DIiFG8g== X-Received: by 2002:a05:6a00:21ca:b0:67f:e74a:d309 with SMTP id t10-20020a056a0021ca00b0067fe74ad309mr4802788pfj.30.1688218434131; Sat, 01 Jul 2023 06:33:54 -0700 (PDT) Received: from [172.31.0.109] ([136.36.130.248]) by smtp.gmail.com with ESMTPSA id j1-20020aa78d01000000b00666a83bd544sm11400104pfe.23.2023.07.01.06.33.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 01 Jul 2023 06:33:53 -0700 (PDT) Message-ID: Date: Sat, 1 Jul 2023 07:33:52 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH 09/14] Allow nested implications for extensions. Content-Language: en-US To: =?UTF-8?Q?Christoph_M=c3=bcllner?= Cc: Nathan Huckleberry , binutils@sourceware.org, nhuck@pmull.org References: <20230629171839.573187-1-nhuck@google.com> <20230629171839.573187-10-nhuck@google.com> <91af0cee-baf3-fea1-9364-db269a232051@gmail.com> <346ebb6d-a65a-214e-2ab9-66844b463b03@gmail.com> From: Jeff Law In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 6/30/23 23:22, Christoph Müllner wrote: > On Sat, Jul 1, 2023 at 12:24 AM Jeff Law wrote: >> >> >> >> On 6/30/23 15:53, Christoph Müllner wrote: >>> On Fri, Jun 30, 2023 at 10:45 PM Jeff Law via Binutils >>> wrote: >>>> >>>> >>>> >>>> On 6/29/23 11:18, Nathan Huckleberry via Binutils wrote: >>>>> Certain extensions require two levels of implications. For example, >>>>> zvkng implies zvkn and zvkn implies zvkned. Enabling zvkng should also >>>>> enable zvkned. >>>>> >>>>> This patch fixes this behavior. >>>>> >>>>> Signed-off-by: Nathan Huckleberry >>>>> --- >>>>> bfd/elfxx-riscv.c | 16 ++++++++++++++-- >>>>> 1 file changed, 14 insertions(+), 2 deletions(-) >>>> No problem with the actual code. I would suggest a comment explicitly >>>> stating this only allows two levels rather than arbitrary levels of nesting. >>> >>> If I read the resulting code correctly, then arbitrary nesting should >>> be possible. >>> Whenever an implicit subset is found and added, `finished` will be set to false, >>> `t` will be reset to the initial value and the inner loop will terminate. >>> The outer loop will start over because `finished` is false. >>> Do I miss something? >> This is making my brain hurt, too late on a Friday afternoon to think. >> I should just put it under the debugger (the downside of trying to >> review code for a hands-on learner), but I don't have the time right >> now. ISTM there needs to be a worklist of things we've found that we >> then need to scan. >> >> But I'll trust you on this, you're a lot more familiar with this code in >> general than I am. >> >> I wouldn't lose any sleep if you fixed formatting in this code. We're >> supposed to be using GNU style. So the open curley on the IF statement >> should be on its own line, indented twice (which implies the code in the >> TRUE arm ought to be reindented) and the close curley should line up >> with the open curley. > > I tested all patches with check_GNU_style.sh and it only found > what you have commented here. > > Since nobody has pushed this series so far, I have updated the code > and sent out a v6 > which can also be found here: > https://github.com/cmuellner/binutils-gdb/tree/riscv-zvk-v6 I had to fix Nathan's email address in various commits to satisfy the commit hooks. So while the git hashes have changed, the actual source contents pushed to the trunk are the same. Thanks! jeff