From: Jinyang He <hejinyang@loongson.cn>
To: liuzhensong <liuzhensong@loongson.cn>,
Chenghua Xu <xuchenghua@loongson.cn>,
mengqinggang <mengqinggang@loongson.cn>
Cc: WANG Xuerui <i.swmail@xen0n.name>, Xi Ruoyao <xry111@xry111.site>,
binutils@sourceware.org, Xing Li <lixing@loongson.cn>
Subject: Re: [PATCH v2 2/2] LoongArch: ld: Fix other pop relocs overflow check and add tests
Date: Mon, 4 Sep 2023 10:24:47 +0800 [thread overview]
Message-ID: <f3dc7899-a286-23eb-bf23-1317c81e72ac@loongson.cn> (raw)
In-Reply-To: <6a594a88-d081-bc15-2d11-2ef4860c1d7a@loongson.cn>
On 2023-09-04 09:26, liuzhensong wrote:
[...]
>> bfd_signed_vma mask = ((bfd_signed_vma)0x1 << (howto->bitsize
>> - + howto->rightshift - 1)) - 1;
>> + + howto->rightshift - sign)) - 1;
>
> Is safe to compute howto->rightshift(unsigned int) and sign(bool)?
That looks confused when I see from stdbool.h that the definition
of bool value is always 0 or 1. Just to be safe, I'll pass "sign" in an
unsigned int type, in the next version.
[...]
prev parent reply other threads:[~2023-09-04 2:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-02 6:50 [PATCH v2 1/2] LoongArch: bfd: Correct the name of R_LARCH_SOP_POP_32_U in howto_table Jinyang He
2023-09-02 6:50 ` [PATCH v2 2/2] LoongArch: ld: Fix other pop relocs overflow check and add tests Jinyang He
2023-09-04 1:26 ` liuzhensong
2023-09-04 2:24 ` Jinyang He [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f3dc7899-a286-23eb-bf23-1317c81e72ac@loongson.cn \
--to=hejinyang@loongson.cn \
--cc=binutils@sourceware.org \
--cc=i.swmail@xen0n.name \
--cc=liuzhensong@loongson.cn \
--cc=lixing@loongson.cn \
--cc=mengqinggang@loongson.cn \
--cc=xry111@xry111.site \
--cc=xuchenghua@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).