From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id 488F63858D37 for ; Mon, 27 Jan 2025 09:12:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 488F63858D37 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linux.ibm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 488F63858D37 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=148.163.156.1 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1737969156; cv=none; b=GNukg1rf8GQpylmlvl/TH7QYpl3sVW9dcrVB+I+RPRZoJOgEgCf434vGfHoRxQE8fdd7fMO0ukPKNtEH8J3YjIkLNcwuplk9ALpBIx7tbSNYP1o79XbLl/1emJ9mSBYFW7QIaYyTmn3eo6ipJhEwjHQKWSZjHgsMcY9SociFBPo= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1737969156; c=relaxed/simple; bh=+ZvIbOUekmPEKyz8ufR7sBA49ybcOkz4zrU188oOARA=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=fNiLK+1JI8In5Th14d2WGUkNMJZNiC1f4J6fqCqPYapnyU1QZPOzjNq3NxEkiwrDxnUmChZbPNkxYLITfPDdHdOwnRyK9fO8TkTl/JE56rOwMvk7TZzt8aSxA77k7/a2enxUV0jAKteWvrf0P3LUlUHiN3QG8a50g7IKgdVyUeI= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 488F63858D37 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256 header.s=pp1 header.b=eOqVEPei Received: from pps.filterd (m0356517.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 50QGHfxr029804 for ; Mon, 27 Jan 2025 09:12:35 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pp1; bh=XoRIeb svV9elS5VM9mlfDNLxtpG3SyuIa4JTI+9ArjA=; b=eOqVEPeiAd/Nhv+OVai8TK 6RG3ehBtPlNNX/04R7ua/JZBypqlfKgjq5E4SAUzfkWz0JOq2FyT7uWGf4NMQcFc ZO5nGy6nXpbmHGXmRNv1reXi9EMBpZTjCm20b7uGbGKrIimwzIwUGbMAEJs91Krg JA+CUf/iRNEPTcvSQGmbrwKrA2qtuKTcC7P49JaBpAzmnei5EIyLZw3H5iBTTieO YYQmh0kE8qmCf47J+Fzhq8lRJBY0iCiZKN9vwJI1a3P7PPcYWz4uuzfyRVnbBj/f FCHFriM6g7JRnrkDZ5BFxejz5h2AUPZWUUd+CMwY3mOungXUgKp8SSQO2t8A8QmA == Received: from ppma13.dal12v.mail.ibm.com (dd.9e.1632.ip4.static.sl-reverse.com [50.22.158.221]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 44dqayb9qt-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 27 Jan 2025 09:12:35 +0000 (GMT) Received: from pps.filterd (ppma13.dal12v.mail.ibm.com [127.0.0.1]) by ppma13.dal12v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 50R9B7kX022264 for ; Mon, 27 Jan 2025 09:12:34 GMT Received: from smtprelay05.dal12v.mail.ibm.com ([172.16.1.7]) by ppma13.dal12v.mail.ibm.com (PPS) with ESMTPS id 44dcgjd95m-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 27 Jan 2025 09:12:34 +0000 Received: from smtpav01.dal12v.mail.ibm.com (smtpav01.dal12v.mail.ibm.com [10.241.53.100]) by smtprelay05.dal12v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 50R9CXIi31523502 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 27 Jan 2025 09:12:33 GMT Received: from smtpav01.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 24C5F58059; Mon, 27 Jan 2025 09:12:33 +0000 (GMT) Received: from smtpav01.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 4C30558058; Mon, 27 Jan 2025 09:12:32 +0000 (GMT) Received: from [9.171.0.107] (unknown [9.171.0.107]) by smtpav01.dal12v.mail.ibm.com (Postfix) with ESMTP; Mon, 27 Jan 2025 09:12:32 +0000 (GMT) Message-ID: Date: Mon, 27 Jan 2025 10:12:31 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/3] s390: Generate .eh_frame unwind information for .plt section To: Jens Remus , binutils@sourceware.org Cc: Andreas Arnez References: <20250122141058.3996604-1-jremus@linux.ibm.com> Content-Language: en-US From: Andreas Krebbel In-Reply-To: <20250122141058.3996604-1-jremus@linux.ibm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: Tjj8U0-y86ttcSheuWEL4GypZoI3T6_- X-Proofpoint-GUID: Tjj8U0-y86ttcSheuWEL4GypZoI3T6_- X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1057,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-01-27_03,2025-01-27_01,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 clxscore=1015 lowpriorityscore=0 phishscore=0 adultscore=0 mlxlogscore=999 spamscore=0 bulkscore=0 mlxscore=0 suspectscore=0 impostorscore=0 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2411120000 definitions=main-2501270072 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Jens, Patches are ok. Thank you very much! Andreas On 1/22/25 3:10 PM, Jens Remus wrote: > This enables the linker on s390x to generate .eh_frame unwind > information for the .plt section. Based on x86-64. This enables > e.g. perf to unwind through PLT entries. Furthermore this lays the > foundation to generate SFrame stack trace information in the future. > > Patch 1 resolves an issue in the linker s390 emulation option parsing. > This is a prerequisite to add support for linker option > "--[no-]ld-generated-unwind-info" in patch 3. > > Patch 2 adds basic PLT generation tests that are extended in patch 3. > > Patch 3 adds support for linker option > "--[no-]ld-generated-unwind-info" and enables the linker to generate > .eh_frame for .plt by default. > > Regards, > Jens > > Jens Remus (3): > s390: Fix linker s390 emulation option parsing > s390: Add basic PLT generation tests > s390: Generate .eh_frame unwind information for .plt section > > bfd/elf64-s390.c | 126 ++++++++++++++++++++++- > ld/NEWS | 6 ++ > ld/emulparams/elf64_s390.sh | 1 + > ld/emultempl/s390.em | 6 +- > ld/testsuite/ld-s390/plt_31-1.s | 40 +++++++ > ld/testsuite/ld-s390/plt_31-1.wf | 32 ++++++ > ld/testsuite/ld-s390/plt_31_non-pic-1.pd | 54 ++++++++++ > ld/testsuite/ld-s390/plt_31_pic-1.pd | 57 ++++++++++ > ld/testsuite/ld-s390/plt_64-1.pd | 38 +++++++ > ld/testsuite/ld-s390/plt_64-1.s | 26 +++++ > ld/testsuite/ld-s390/plt_64-1.wf | 33 ++++++ > ld/testsuite/ld-s390/plt_64-1_eh.wf | 31 ++++++ > ld/testsuite/ld-s390/pltlib.s | 16 +++ > ld/testsuite/ld-s390/s390.exp | 28 ++++- > 14 files changed, 488 insertions(+), 6 deletions(-) > create mode 100644 ld/testsuite/ld-s390/plt_31-1.s > create mode 100644 ld/testsuite/ld-s390/plt_31-1.wf > create mode 100644 ld/testsuite/ld-s390/plt_31_non-pic-1.pd > create mode 100644 ld/testsuite/ld-s390/plt_31_pic-1.pd > create mode 100644 ld/testsuite/ld-s390/plt_64-1.pd > create mode 100644 ld/testsuite/ld-s390/plt_64-1.s > create mode 100644 ld/testsuite/ld-s390/plt_64-1.wf > create mode 100644 ld/testsuite/ld-s390/plt_64-1_eh.wf > create mode 100644 ld/testsuite/ld-s390/pltlib.s >