From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 9877138515ED for ; Tue, 6 Sep 2022 13:06:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 9877138515ED Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1662469609; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=U1UXeaztNammdpZ0TMHoNKVEHbZkOi5ZPOmBNF6U4DE=; b=amfNmieWNne0XTcvVdlcWEdnbhdBv4rtaZXvbPRMFQokhRTRGot2lzyxMNKFwiUMtVfyTL NeIUROK6gr9NRBNcFKb8mgCRw7sQRT/IiZ90xpHFSgEGynkW94+aCBimVgdNsK43E413Ox CtPS829bIiCLX+g1Hyg+QtbjWX7U2tU= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-127-pD2Xk0_GPyqlvDOv14xORw-1; Tue, 06 Sep 2022 09:06:48 -0400 X-MC-Unique: pD2Xk0_GPyqlvDOv14xORw-1 Received: by mail-wm1-f69.google.com with SMTP id v67-20020a1cac46000000b003a615c4893dso6276300wme.3 for ; Tue, 06 Sep 2022 06:06:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=U1UXeaztNammdpZ0TMHoNKVEHbZkOi5ZPOmBNF6U4DE=; b=NSjLwYebNgqCKNa11dgI6w2K86rV0hRQdstnc3d9DL96j29Qvogg3mIhajbHAra+5V EJOQB88Gv08FwfP8+sbqMkXjRs1SsMdsqc8PcmDPxGAxbdDSOhVFA4eFAfTNnuVbb66O KN0UElvhUF0LYAwTNKWoVtGdziT/dPhoxhPrqC9IjmdifneYkRR9v1b7ByybxUteJTWT 7XgE/hvNQ2A3GAtqmBzQC6Ceossy+1g3NnGgykkugCkbDVxjq6v03TwAaGR1M1LQSkto Q2HMHaTgeT445ESE4sfaXCY/SqMJGZofd5Zmi2Fzg1Wcq0wuBl3ZSakO8UxMt+3N7wrc GjKw== X-Gm-Message-State: ACgBeo3lxsWhMqExLDQB1XWjkfThsn77gkPP8GlpLhM984hqIfBSzcYa ENCmmYbMUjVbznFVkjjo0x0vBSt+JiSyQ9ui8TPk73h7qPvw8PmiHB6PNpGuraR6jbTsNSfSbqM uEVAGEKOq3Or9Z8CL5Q== X-Received: by 2002:a5d:5a86:0:b0:228:6920:33d6 with SMTP id bp6-20020a5d5a86000000b00228692033d6mr6661626wrb.175.1662469605582; Tue, 06 Sep 2022 06:06:45 -0700 (PDT) X-Google-Smtp-Source: AA6agR4dE8ZKFcdykJuxi5NwVYG0jTymURu8CAZbvxkuV+8P5wXlxPSSYluun9/TjaDMOJsPhG6qrg== X-Received: by 2002:a5d:5a86:0:b0:228:6920:33d6 with SMTP id bp6-20020a5d5a86000000b00228692033d6mr6661613wrb.175.1662469605361; Tue, 06 Sep 2022 06:06:45 -0700 (PDT) Received: from [192.168.1.6] ([79.123.81.183]) by smtp.gmail.com with ESMTPSA id g13-20020a05600c4ecd00b003a4c6e67f01sm24454123wmq.6.2022.09.06.06.06.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 06 Sep 2022 06:06:44 -0700 (PDT) Message-ID: Date: Tue, 6 Sep 2022 14:06:44 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH] ld: pe: Improve performance of object file exclude symbol directives To: Jan Beulich Cc: binutils@sourceware.org, =?UTF-8?Q?Martin_Storsj=c3=b6?= References: <20220902105903.2249507-1-martin@martin.st> <174963e9-fa71-b70e-7659-0f534db073f8@redhat.com> <242a402a-57be-0738-d7b8-c19e1a631bb7@suse.com> <2568a388-02a9-4beb-f20b-e2493cda4a64@redhat.com> <959c6306-60c5-41b7-d22c-18baf3b35ffc@suse.com> From: Nick Clifton In-Reply-To: <959c6306-60c5-41b7-d22c-18baf3b35ffc@suse.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-GB Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Jan, > Well, first I was thinking of a hybrid approach - double until reaching 1024, > then increment further by 1024. But then this seemed to be going a little too > far, so I suggested the simpler alternative. Thoughts? I came to exactly the same conclusion. We are definitely at risk of over-engineering this problem. My feeling is that the best thing to do is to choose a constant, any constant, set it in a #define FOO and then use FOO in all the right places. Then, if at a later date we discover that is too small/big we can replace it with another value, or even a call to a function. Cheers Nick