From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) by sourceware.org (Postfix) with ESMTPS id 3C9AE3857359 for ; Thu, 14 Apr 2022 14:12:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 3C9AE3857359 Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01lp2054.outbound.protection.outlook.com [104.47.1.54]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-39-ywSdj_AYPcCj8I-D0qCPtA-1; Thu, 14 Apr 2022 16:12:35 +0200 X-MC-Unique: ywSdj_AYPcCj8I-D0qCPtA-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NXL+Md2NktAaJxHVEAMs1s28O/BwGgwdXjxxytpiIn/kbXQbXTYP7WEalkwTvQJ+nurBcUgEkHxcsVPCng+3kwjuo3Ocyb1nfs42FLdVGYvwH0zs+vxc12T2wqCHLMuBpzJKZZtBs/uPkoby4cZbFOCzP2PkGjusCREyHRS6tmvXa+0BGH/azYS1c+WdAwNminHkdZaykCosFNmyNjYjd/j5Sj38s1xLhFgG66DdGq0a+JAuiLOtvAQ5qie102+OeJ+b8R3r7JSzH+yd/42kufWCrJvhkpRupzh6ymE1RH9xfw46cLP7lrPhbA4RsJrNyU6mylUBmXrCtNQWC4deEA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lPJ++FX8byyCyIxUbjYeilz8NhBDldnTmeRwv0+IE7c=; b=N8eNj00eMt8pgxQtinU4tJOW+Pfh70w99kkw77Y72NZ8t+EB4740aH3Mgc/XmfFK1FA5IRy8pWlQGDB4djJvQGiHlVyiz2Ml15+KhTzC6uCgcR7iOl4DPa/4baj27agOAwlOTv3llAcWn2zh5m2LydMbX8bYSaAgJi5dczuRsXOo8aVMvYkOSNTKiV2hvoltMGJUJyhYt3z84WtxXBrxpqyjQ5sRsUO+toJvOnpzJIjJvFhtUQxdJlfrNW5WYH5RlEUgpBrpCtgFafobRm69BLnWZrr7vnEl+sJ9HnRb/ucs1Pc8nHw+a7M9HqVzBY5/DzBhtzKuPJsrh2ijT/PLdA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16) by AM6PR04MB6312.eurprd04.prod.outlook.com (2603:10a6:20b:72::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.29; Thu, 14 Apr 2022 14:12:34 +0000 Received: from DU2PR04MB8616.eurprd04.prod.outlook.com ([fe80::5592:2abe:fb16:6cd1]) by DU2PR04MB8616.eurprd04.prod.outlook.com ([fe80::5592:2abe:fb16:6cd1%6]) with mapi id 15.20.5164.020; Thu, 14 Apr 2022 14:12:34 +0000 Message-ID: Date: Thu, 14 Apr 2022 16:12:32 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Content-Language: en-US To: Binutils From: Jan Beulich Subject: [PATCH] x86: don't mistake ordinary immediates for SAE / rounding control Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM6P191CA0054.EURP191.PROD.OUTLOOK.COM (2603:10a6:209:7f::31) To DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: fb2f6ca2-2415-4617-ea5e-08da1e20d233 X-MS-TrafficTypeDiagnostic: AM6PR04MB6312:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: wwvQYlkkaWOs+JBAgjltc+ytlHEYq1eZVWR5bIN1E6kIJ+8cLlcVaAV+jZZqozG1otG970aVtfUx27Fa2l5TiiWkFzBPc3Vkl73zuYRA5HJ92QnYwo7BPEWbHQaez3DDSTTs6vlUkkQFPRPjOR7A2JM3LxzoTuuFDMV/RYJMsSMXZFzouXaQi8vCkCuDDXVHCtaadaRNGFOXRXHhLx5um2hWfkmTbGVyLp48H7k6QMYXeUCZof3OsW4k+azYg/p7n4KaBbGdXYLNw07xYNxXLKN+LUG8MMi8ioHHdCrboOcNySg8fsdU0vcYCQU6U7qk+sfFz1k+eZukdj7y2rD2cBeCT6dXmK/HxRl8yCYA42gnhJb0ExZHNWZQtPJNDjpwC1rwZd8uOicEcgCgMvSkDrbW8A8eBseRtG2PwLY0Vtai0/wlUKyWglNdtigxm960bUkNQr73dwdArbmnZzNbIj0tdXRFX89wDV9OYCsA1Wuwlv5dDRlqnfqRp7cNwoCg3Q9+kfPI59ADOQeD7Ik8yvVQa4IlpifAwMamhREgkrJsaCfeKNX/mEJwzpyT7FUEfsa3kdhl5CJsZORQISOY7+fx8XfBLjVEVHjB/lFlMvv3/eAQK42qnAiOy8ERfYe8xsSc6YpSVeV6p4TK7jUDMrzhve1xzga/62kMO4eco/QI7jagANro0spd8DRqONKUz3ceZpZc2NVQEEkt6MSg+arLd/Fp2iJKuMrJUXJwodOvfptQtrqVQ3VO7iQp2CshXTGeUUKOwROvaYu46gd7Ng== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DU2PR04MB8616.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(66476007)(66556008)(316002)(31696002)(8936002)(2616005)(5660300002)(6916009)(8676002)(186003)(2906002)(38100700002)(31686004)(508600001)(4326008)(26005)(36756003)(66946007)(6486002)(6506007)(6512007)(86362001)(14773001)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QS95dHlTT3NBQ0ExNDNZQXQyRCtxV1NRY3hRdEcvOVhKUm5BeGR2T0FzZzA3?= =?utf-8?B?ZDNTaW1leENmYVJaVE5MRXNxTkJQRERiZWFEdDJGTS9HSGJLZ0lkSmwrSGUy?= =?utf-8?B?cVJqZkxCSkZBNzBTandwWGZ1ZDRHV1VlZVVZNkcwWitpQ0tqM2FxYWVpYWox?= =?utf-8?B?QjgrMkIvLzVjcXBmQnpUZXZPVmhNRFVRYU1FKytNL0dpa1daSU55UGN2OFNI?= =?utf-8?B?T0x3TTJGM1pSZndscmxibHpSOEFOazBxRU5OSC9zLzdMMDRaYThiODI2QlJW?= =?utf-8?B?anM2WWFHUmRUQ0NkK2F3V2Q2SWd4eE4yeGFwUkI4d3o3SFFaeTBZeWxoVUJU?= =?utf-8?B?Z3FUbWJ0MWxlM1RmeTZ5SVl5dVoyVzFCcGZLbU00VG9kYmIxd3RkMGwxai90?= =?utf-8?B?LzFaZlpVcUF2SzNieUJuVHM5ZFBUOXdxbm1tYXRrRVJlYkFKdjNrbFoyL1ln?= =?utf-8?B?amdzMi9QaGljc0hsdFB3QzVlZGJFeGhlZGRtSGMvT0pHaitYd3J6UkszNEtN?= =?utf-8?B?aXV5a1ZYdGN6VUs5K2hkN1JhNkNHNHlobWFwWEl4bW5maktUcHd4M0NxMUpu?= =?utf-8?B?Zm45VVBlZXh2UnJMNWRaaTMwK2JmVHNTdGJQUHZ4SlFsMVBQaVIrSEsxS21O?= =?utf-8?B?NHFEOWRsSU9obTlIby9oZmpvL1FMMGNyZTNSN1E3YlVmaVhUQjloemRDMUlY?= =?utf-8?B?cmFlYUI2Y2Fkc1BOSUVBWExlbTZxdWo5aE9GaTVkNmNXclFLNitKOWdWUzIz?= =?utf-8?B?QldGalpEdGgyOVZzMkxrdi81N2szcTYzVmUwVHNDdzZpTmRSb0hoWTg2TzhS?= =?utf-8?B?czloT01PcFN0QUhxVnQ0YXliR0hPS1VaNis0cHo2aWZIK0ZYVFpQa3dCSVpm?= =?utf-8?B?aVNxb1Ztem1wSjExSXJTd09uTi9FS2NFV3pockhRQXU3TVRWWU1Cb3k4dmRM?= =?utf-8?B?Z3VwZ2UxanN4RkpUNjJZMktxbEVJWUMzb0JXdDZOSEZFY3Y4eEZ2cE9jbTBu?= =?utf-8?B?VHFNb2lhRDNxcXUyZUJmMnVKZGNGSUNybHNMbkNXdjVwRmpLVHBodFM1aUh1?= =?utf-8?B?VDFhN2szTzNJQnUzTGhsVlFUYlFzVFFUM2VBQ1hOQXNrT0dpSS92ZU9XVU1T?= =?utf-8?B?ZG9FeCsvRDBWdmFYMzB6Rnc3NUZ3YjV4RnpYcjNJL25SNFBqVnNPbFZkZnhj?= =?utf-8?B?MnNVdlYzYkhnbW1CNlFwOWVaQVlKRjFOamg5YmM4akx0WThuVFp0Y1d4dDVR?= =?utf-8?B?VHk3ZGVQOFNORzROUHljRWplUEFJZ1BKT1dZbW9YM093YTg4eGNUTGFhc0Na?= =?utf-8?B?S2N2SjZkejdqWDNnOUNPYVVYOFQyNnBsR3R3SWVSQ1hubTBXdWxjcTBtckVM?= =?utf-8?B?YTRzTm1veldieUpWRElqc0JQN1psNHVHVzl0ZTFkMmlvWXhpN3Ztb01lbGps?= =?utf-8?B?TTNmMVlXd3Z4VzI3cWcyc2VaRzJGL01XRG1OeldwSWxLbzJzUG00bXJkVHlx?= =?utf-8?B?cUluTC9vbnVLRHBLR2hWT3NaQVVhSFRuYkszVmxobEcvRkR1aFMrcUc4dUZm?= =?utf-8?B?aFNOWCtwUlMxc3ZDYk02QXlBVmNDS0Z4YkNMMjVuZ1pYaHlQam1xRnJmMnZt?= =?utf-8?B?aEVucGpEbzVUQTRwSGZSeHM2dXF4OVRHZjZ1Ynl1Y0ZhVFh1RjVjZmRDVXd0?= =?utf-8?B?NVVIUWV0aXNIQzUxMy9WSVRpelF6WE13Mml4aGF6RHNOeCtraTdIbi8rVzFF?= =?utf-8?B?M1NMMVM1K2swMWpPVUJBNnlXa2ExRWJGczlFbzBqQ3hTR25Yd0hNYVNTR2hC?= =?utf-8?B?dUxIcUNyYkwyS3NwMndzY3JmaDFZUkYxRDE0M3BWazIzbnR2S2pvRUlpNzlo?= =?utf-8?B?MmdjRHkxU01MWVNHZk9nbkpHOW5Wd2ltM1FRM2pER05iT283K3dFRXVyS3Mw?= =?utf-8?B?S3hqbW1ZSGVvdXJ6UE52VnZDdTVLcWQrVzNjSHVhTDQ4aDZybUhkczBFeXJY?= =?utf-8?B?VWVyMy9rVmQyaEVDNFFBL0Fyd0w2LzVNRDYzQkVhM1puU1YzYXFDRnBJNlpl?= =?utf-8?B?TERERHBjSDJ0SFhSdjF2MG8zZzByNGEvZ2hCMkdWNGlock44VHNXQ09jdTBE?= =?utf-8?B?RHNKaVlhalp3WE0yWW1ONkp2RXR0NXBERWNwbTBudmJxUCs2ckUrYkgwdUVj?= =?utf-8?B?ZDY2SU13NWE5bTV5N2NGSmJ1MWVybzJPS3JTbjFZUUU2ckplK3NaajUzNjJp?= =?utf-8?B?RGFIeEN1KzQ5dUJkaHVJNFNXa2JTKzJmbjNiSDMwK2xkUnpKUnFUOE5rNzcv?= =?utf-8?B?RDQ4MDJOS2k5Ny8wbU9yVW15ZThtdW1OZnBQUlYvT0orUjNzOVMvUT09?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: fb2f6ca2-2415-4617-ea5e-08da1e20d233 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Apr 2022 14:12:34.1844 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: zzhd6SuoeqJ3JUV82/0h6byjQDtUnKfuflymez6Xa58oiLmnKpl7GSVuBM6xPsjvk91L11NdUN89iHz7MGx43Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB6312 X-Spam-Status: No, score=-3031.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Apr 2022 14:12:38 -0000 The way SAE templates are constructed was always puzzling me (including the need for separate templates in the first place), and expressing the extzra attribute via Imm8 actually has a bad effect: Ordinary immediates would also be accepted, leading to an extra byte being added after the instruction (i.e. generating bad code). Before re-working this (in particular to accept proper Intel syntax there), fix the immediate issue by adding the so far missing check. --- a/gas/config/tc-i386.c +++ b/gas/config/tc-i386.c @@ -6285,6 +6285,11 @@ check_VecOperands (const insn_template * return 1; } } + else if (t->opcode_modifier.sae) + { + i.error = unsupported_syntax; + return 1; + } /* Check the special Imm4 cases; must be the first operand. */ if (t->cpu_flags.bitfield.cpuxop && t->operands == 5) --- a/gas/testsuite/gas/i386/inval-avx512f.l +++ b/gas/testsuite/gas/i386/inval-avx512f.l @@ -218,6 +218,8 @@ .*:313: Error: .*unsupported broadcast for `vcvtneps2bf16' .*:316: Error: .*unsupported broadcast for `vcvtneps2bf16' .*:319: Error: .*unsupported broadcast for `vcvtneps2bf16' +.*:321: Error: .*vaddps.* +.*:322: Error: .*vcmpss.* GAS LISTING .* @@ -569,6 +571,7 @@ GAS LISTING .* [ ]*318 \?\?\?\? 62F27E38[ ]+vcvtneps2bf16 \(%eax\)\{1to8\}, %xmm1 [ ]*318[ ]+7208 [ ]*319[ ]+vcvtneps2bf16 \(%eax\)\{1to16\}, %xmm1 -[ ]*320[ ]+\?\?\?\? 8DB42600 \.p2align 4 -[ ]*320[ ]+0000008D -[ ]*320[ ]+7600 +[ ]*320[ ]* +[ ]*321[ ]+vaddps \$0xcc, %zmm0, %zmm0, %zmm0 +[ ]*322[ ]+vcmpss \$0, \$0xcc, %xmm0, %xmm0, %k0 +#pass --- a/gas/testsuite/gas/i386/inval-avx512f.s +++ b/gas/testsuite/gas/i386/inval-avx512f.s @@ -317,4 +317,8 @@ _start: vcvtneps2bf16 (%eax){1to4}, %xmm1 vcvtneps2bf16 (%eax){1to8}, %xmm1 vcvtneps2bf16 (%eax){1to16}, %xmm1 + + vaddps $0xcc, %zmm0, %zmm0, %zmm0 + vcmpss $0, $0xcc, %xmm0, %xmm0, %k0 + .p2align 4