From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ej1-x630.google.com (mail-ej1-x630.google.com [IPv6:2a00:1450:4864:20::630]) by sourceware.org (Postfix) with ESMTPS id A758F3858428 for ; Mon, 14 Nov 2022 17:24:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A758F3858428 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-ej1-x630.google.com with SMTP id y14so30044625ejd.9 for ; Mon, 14 Nov 2022 09:24:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:from:to:content-language:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=jZ1oViYbOQgdx5GeEUcMS906YTUYpC6X5q3Wipap1PQ=; b=Pl9VuwPqELYzj49DIsKk9I9IQnsJntfBg1pScPGMDtc8ek8IintM+H8CCf23G5iddF 8eN6p6usR36kMNPlnXrKX7pE46ob3Q/qlFW6XvQ3tGXyTsftB2pfBg1Nje48zK3WdwuW zbQ5zCnmBnmYSWNgPUc3fbQucLmc4bzc8naCBNyM1nm76tiyeqcEzropE5nxYJrbYBhM Na5dAMa4dK8gwskmNz+jJSxZy7dfDEsdTi8ozISJCvE9CjnSDNvX722t/1FqL2xJL9xp cX8VxW93DLmrWAcZf7A2OPrAYOeUjYnOX/OXUlcGxKkFd6i3phOF/545zqox/x0EP3S3 yGyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=subject:from:to:content-language:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=jZ1oViYbOQgdx5GeEUcMS906YTUYpC6X5q3Wipap1PQ=; b=PBvPfO2IsBh8f4eOsob18U4kALyqLb3K0A4fRL7v/72eRAuclqYZlXmWjxRshbXHq9 9K6zRuySAovNO1kAj0xcFYcyLyDwJAAoqDnKxve4k5xNJGF16GrBYCGrxZteIvf12yt7 yBob3TAoPvwoyP+bMsYd6x3iYJCSHHSmO2VRED4s86AT+b1urFJUgk1Khc5uziS1mFTH qkyYVYx7id/nlNJUNZr6MkXKldAAPYXsVtcHkyIUBATjcOxt5vYx6Ovo83dsPDaykeja rFfxbJAUSfbpzbMGYqHaGB4fqvQ5MDV1DA6v3xrVaUFRUjMRhlNZd7+CD1/jdFThKL0j aMyg== X-Gm-Message-State: ANoB5pn3+oQOkdJ9RhMkN2WHEs1cfRLYJsIT+YmUkwfJq9ZVMZECA/V5 UX4fc4dqZHtK06OItu9FjkrBtC+z68Vz0A== X-Google-Smtp-Source: AA0mqf6eTPnpvqBmsEXqmeDlTDgfpt02ZSiSEHvREU6bDFZ3FhgpOXz2+X1HJfuO5vQkci4ZoTiL+A== X-Received: by 2002:a17:906:1441:b0:7ad:b97e:283a with SMTP id q1-20020a170906144100b007adb97e283amr10697188ejc.567.1668446664184; Mon, 14 Nov 2022 09:24:24 -0800 (PST) Received: from [172.31.227.58] ([94.230.145.250]) by smtp.gmail.com with ESMTPSA id q12-20020a056402032c00b0045d59e49acbsm5078422edw.7.2022.11.14.09.24.23 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 14 Nov 2022 09:24:23 -0800 (PST) Content-Type: multipart/mixed; boundary="------------aGPsUm981q4giGHWkL2zs1v2" Message-ID: Date: Mon, 14 Nov 2022 18:24:23 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Content-Language: en-US To: binutils@sourceware.org From: Zac Walker Subject: [PATCH V2] GAS fix alignment for aarch64-pe X-Spam-Status: No, score=-12.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: This is a multi-part message in MIME format. --------------aGPsUm981q4giGHWkL2zs1v2 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit For the aarch64-pe target various values of '.align' causes writing of COFF files to fail. This version of the patch differs from the first by using the write.c implementation of SUB_SEGMENT_ALIGN. This means there was no need to modify md_section_align or aarch64_handle_align. The change is specific to the aarch64-pe target. In my testing generated aligned code was correctly padded with nop. Thanks, Zac --- gas/config/tc-aarch64.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/gas/config/tc-aarch64.h b/gas/config/tc-aarch64.h index 2d514ff610..0ea73021f2 100644 --- a/gas/config/tc-aarch64.h +++ b/gas/config/tc-aarch64.h @@ -191,7 +191,10 @@ struct aarch64_frag_type goto LABEL; \ } +/* COFF sub section alignment calculated using the write.c implementation. */ +#ifndef OBJ_COFF #define SUB_SEGMENT_ALIGN(SEG, FRCHAIN) 0 +#endif #define DWARF2_LINE_MIN_INSN_LENGTH 4 -- 2.25.1 --------------aGPsUm981q4giGHWkL2zs1v2 Content-Type: text/x-diff; charset=UTF-8; name="0001-GAS-fix-alignment-for-aarch64-pe.patch" Content-Disposition: attachment; filename="0001-GAS-fix-alignment-for-aarch64-pe.patch" Content-Transfer-Encoding: base64 RnJvbSAzOTJlOTE5ZjM1YWQ3OTBiMjExODVhYjFjZTM4N2JiMDY5NGNkZGQ5IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBaYWMgV2Fsa2VyIDx6YWMud2Fsa2VyQGxpbmFyby5v cmc+CkRhdGU6IE1vbiwgMTQgTm92IDIwMjIgMTc6NDg6NTggKzAxMDAKU3ViamVjdDogW1BB VENIXSBHQVMgZml4IGFsaWdubWVudCBmb3IgYWFyY2g2NC1wZQoKLS0tCiBnYXMvY29uZmln L3RjLWFhcmNoNjQuaCB8IDMgKysrCiAxIGZpbGUgY2hhbmdlZCwgMyBpbnNlcnRpb25zKCsp CgpkaWZmIC0tZ2l0IGEvZ2FzL2NvbmZpZy90Yy1hYXJjaDY0LmggYi9nYXMvY29uZmlnL3Rj LWFhcmNoNjQuaAppbmRleCAyZDUxNGZmNjEwLi4wZWE3MzAyMWYyIDEwMDY0NAotLS0gYS9n YXMvY29uZmlnL3RjLWFhcmNoNjQuaAorKysgYi9nYXMvY29uZmlnL3RjLWFhcmNoNjQuaApA QCAtMTkxLDcgKzE5MSwxMCBAQCBzdHJ1Y3QgYWFyY2g2NF9mcmFnX3R5cGUKICAgICAgIGdv dG8gTEFCRUw7CQkJCQkJCQlcCiAgICAgfQogCisvKiBDT0ZGIHN1YiBzZWN0aW9uIGFsaWdu bWVudCBjYWxjdWxhdGVkIHVzaW5nIHRoZSB3cml0ZS5jIGltcGxlbWVudGF0aW9uLiAgKi8K KyNpZm5kZWYgT0JKX0NPRkYKICNkZWZpbmUgU1VCX1NFR01FTlRfQUxJR04oU0VHLCBGUkNI QUlOKSAwCisjZW5kaWYKIAogI2RlZmluZSBEV0FSRjJfTElORV9NSU5fSU5TTl9MRU5HVEgg CTQKIAotLSAKMi4yNS4xCgo= --------------aGPsUm981q4giGHWkL2zs1v2--