From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ej1-x631.google.com (mail-ej1-x631.google.com [IPv6:2a00:1450:4864:20::631]) by sourceware.org (Postfix) with ESMTPS id 1B5CF3882123 for ; Fri, 14 Jun 2024 06:21:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1B5CF3882123 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 1B5CF3882123 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::631 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1718346093; cv=none; b=oyJVk/JtM3TKx6MXtRZ/tzw6couU/SDk/kKiG1hAlTwsxJeLufxIxDig/Uvy5uy1zXM2Ff7n58ZirB9sES8ILZ7pxtTGnf1LYP5PWZIaWFtzPfUPEfLIDot+2eoz+mc0dd/bNcvkJN3dkonpI5aijK955cddN8O/8eRybEC4420= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1718346093; c=relaxed/simple; bh=bH1ps6bcVp+0RDmbzXLYIO9dkudkJENLdZ5o43cZDMc=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=JVg7b6982e0DohYJLucEEmzXVrRHNzz5QMOeO+4kkseWnFZ1x4Zt5Dk3oLeeSBq+cyjN75ULoiGdhJoU9WLZNEBEI0G6UfHVsxxDLpf8ITxDDQY0XzuVe/4DvzFGRYTs8CtaVV98OHNr6g24zWJSXx5zLTxCagPVtbdqXh0buHE= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-ej1-x631.google.com with SMTP id a640c23a62f3a-a689ad8d1f6so235397066b.2 for ; Thu, 13 Jun 2024 23:21:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1718346089; x=1718950889; darn=sourceware.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=b23462kYDNydPM0kiGZbR1zE4FW4xh91cXJ96Ws8O1g=; b=abSlozFQVFFf5hgDnu7ENpBjc1C4oNkbbvKKFfSv5G98T0Upv2JWAi+upZbiNnRnLf YHDEsHVY9LdEmJgG8ikI15Jj9H/ArlE/jbG+vyhdkKItluk4sn0JSwb6GzHwjKSZl/4C c7zUeUSjBN4UyYwrGnUWtkThvtVlPvrQlEMwq/gCxzeoGYRwbCxstYp0BAdrCqqNOZnu soTX0kqxTz1zh8hBStcvUN/3yOzDBhcc3W3DakH6VRREG+SQ4TRiLrnNreJGfK9TDLM1 4qAl3iYZmDJjf7IM+Jgehxkns5lgJibfMYftkhPBgzcROr0rzSGkmk09A2LY6Ip7slwy t06w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718346090; x=1718950890; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=b23462kYDNydPM0kiGZbR1zE4FW4xh91cXJ96Ws8O1g=; b=jT2cmKyuPWcdcPrtO7lihTtOwY7CvQuErj3eGO/96KMj29Lu/DrldaVzSUMzxfWarD t/FlxfgZt9YeB5JNKSgBb32I+i5PRU+Z8hhmxUqU1FmNLaUotgleYmIYlokV/wHXN2RB SkUOE+a/OyWg1P/pCAWnMGDaff6s2zJPifFfSXD0OPZZzg6fbfiuGG8DsaFPzH0cGJJ5 i08Q26fR5JA//yruCXFNTPhxum5KqQGvJlGLj5cmElkMRoqi9Q7fHC3AsyBSgk3e1Vq6 dZNb/HZIp1z/1mKH/pm9LnIYlqlpffnJC8V9yYNOGP/Vpc+54PR027KBIL9YDP64alYr e7gw== X-Forwarded-Encrypted: i=1; AJvYcCXftlg6SFjca6eFyHeuLG6mPfXMOzlW6HqBuda3CCm1PTTf08mbtSkWny8WNbzPgo9yXeoWnLu46sdx3r8HQktw6vVjCE4Geg== X-Gm-Message-State: AOJu0YzAOPYID2XVJ52OfGB/yvizqf+fj59RG2ogPU95imC6Pk9NiHC8 a1nm90Z39ns84O3gacivgiFS/2EW9Mvkl4Tsejp3x6s/NQHqUs4FiKFXcf7pX2js2Q7/eHeCHss = X-Google-Smtp-Source: AGHT+IGsmf7nUIGsxOZe0DJJrAfpmdjqpV8/5nsTy6K39SYYkiOvZFUwz//c3aCD4vPWD3mIUZ4RWA== X-Received: by 2002:a17:906:c291:b0:a6d:ee51:793b with SMTP id a640c23a62f3a-a6f60de1cc1mr92636866b.73.1718346089657; Thu, 13 Jun 2024 23:21:29 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a6f56da4087sm149131066b.2.2024.06.13.23.21.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 13 Jun 2024 23:21:29 -0700 (PDT) Message-ID: Date: Fri, 14 Jun 2024 08:21:28 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/3] Support APX CCMP and CTEST To: "Cui, Lili" Cc: "hjl.tools@gmail.com" , "binutils@sourceware.org" References: <20240611080630.163749-1-lili.cui@intel.com> <20240611080630.163749-2-lili.cui@intel.com> <998600c8-09b2-4769-a885-faee4f348d39@suse.com> Content-Language: en-US From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3024.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 14.06.2024 05:29, Cui, Lili wrote: >>>>> @@ -1929,6 +1939,114 @@ static INLINE bool need_evex_encoding >>>>> + /* Parse 'of , sf, zf, cf}'. */ >>>>> + while (*suffix_string) >>>>> + { >>>>> + if (*suffix_string == ',' || is_space_char (*suffix_string)) >>>>> + suffix_string++; >>>> >>>> Like for the earlier loop in the earlier version: Is it really okay >>>> to have multiple successive commas (with or without whitespace in >> between)? >>> >>> Ok, I'll add a check for it. >> >> It's not really another check that's needed. When put at the bottom of the >> loop body, your expectation simply is to find a brace or a comma. Anything >> else is an error. (That way "{dfv=,cf}" would then also be properly >> rejected.) >> > > I don't understand the logic of your approach, I think I missed some information. Currently I am using the following method to implement it. > > bool check_comma = true; > > while (*suffix_string) > { > if (*suffix_string == ',') > { > /* Report an error for illegal commas. */ > if (check_comma == true) > { > as_bad (_("Illegal comma found in pseudo-suffix")); > return -1; > } > check_comma = true; > suffix_string++; > } > else if (is_space_char (*suffix_string)) > suffix_string++; > else if (*suffix_string == '}') > { > suffix_string++; > return suffix_string - l; > } > else > { > check_comma = false; > ... > suffix_string += 2; > } > } (just an outline) while (*suffix_string) { if (is_space_char (*suffix_string)) suffix_string++; if (TOLOWER (suffix_string[1]) != 'f') break; ... suffix_string += 2; if (is_space_char (*suffix_string)) suffix_string++; if (*suffix_string == '}') return suffix_string + 1 - l; if (*suffix_string != ',') break; suffix_string++; } as_bad (...); return NULL; The only special case not covered (perhaps needing an extra check ahead of the loop) is "{dfv=}", which I have to admit I'm not entirely certain needs supporting at all (for being the same as omitting the construct altogether). Yet I'm certainly okay to permit it, allowing people to write what some may call more explicit code. Jan