From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 5526E385840D for ; Wed, 24 Apr 2024 11:25:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 5526E385840D Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 5526E385840D Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713957915; cv=none; b=Aywb1mIws0lUj8E5wrNvtKqc9s5tJuf4Uo00rJiNwAUdc1ju3xOPAjtD+9gC+RJcXm1pfKLN9t2gtILrcEBqSlsG1zZ4MnmEYmwc8aR1wgLt7N0S8DPkJpUSKCipSH+H0ycNplL2ru0OTxld4mxyyn+RptOxkfLTxxWqaENkUKY= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713957915; c=relaxed/simple; bh=1qyTm3etsZpEjybvpQmRX7Qito+jf/DRCKIXjOxWdU0=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=IRdtmMn4qWuLS+qnsIZG45aNNDxYoIyYhuWpf46RBokm7NoHVUUehyuJG1FDtFr8G0y5HMtNNHQCJiJmgPeCnbFNgAaPym2XTnsaXoEyzG2tWcN+FiOx1B3gXQfG4t/FHuX0Ih1vQQQEJfSa7DGkOjwoiL5TdsCrTVp8JAj4u7E= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1713957911; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=LBab+eXgv1IOcw15liXou6W4vHKXunyeu/JOtHogtjM=; b=MwCdoG0Npecx5i+iZ1Mg4GZBjwoxJjN03iWjk5XYEqZynZN1am5DBnYYnStS69f06cTw/J 6al2lbOZct/l08QK8ys18m667ANvY0U27rjBsVMUEQoIsT+dCtiCM98c6MdOcbp06oh8iG kiA2JhpEt4ELt/DoxPeAy6mfcz+GUdo= Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-298-dP2F3zuFOcW3XudVbamw-w-1; Wed, 24 Apr 2024 07:25:09 -0400 X-MC-Unique: dP2F3zuFOcW3XudVbamw-w-1 Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-78d5ef6055fso938596485a.1 for ; Wed, 24 Apr 2024 04:25:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713957908; x=1714562708; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=LBab+eXgv1IOcw15liXou6W4vHKXunyeu/JOtHogtjM=; b=RX+P2fZiLJb7qweZEiabkgEC/T68O+UNjwOtlZuouYBkgxjyivVv4Y0mT97/ef4CYI 8BnLLkOymzwRYwFuGjBvyx6qgZERJDFO90ZWxt/Cn4dPVk8fzyHuwp50W0VltV8gv6DA bz8mGiQyIa40vNxSn+Kz7qKVa9wTJ3EJ7MEWl+EagztAFewCyPSFJrbrEl+qCk4VFU4f oEQOIMbSN55+k4EJGuQtJs8UdptQSrnG2oYEZOJb3Dtyp2UZDZv41voTFX83/1RX72EW sMvTX65t0n9saH9htpDLvp5rL6ReJ3oi6GoD7my5/GngC3zpRvosthjzSw48pfar3qrL YxSw== X-Gm-Message-State: AOJu0YyFlvWS2nP7bdlB0JogUObVDUeHXz7PvQTy8sMpe+3CcYn3/XSS 79S/wleRfjcnN4sv5HFnHj29fYQqHO5D4yaG9vMq4VkMw1+gxrsq6HJtt1Sa01Xbga5cJOrIpSR n3xbrlNXym6z+m31QiUXgeIJamp/hVbinnQAaE9SvhnxypWqv8TDxChqD/tpccoE= X-Received: by 2002:a37:de19:0:b0:78d:61c2:4ee9 with SMTP id h25-20020a37de19000000b0078d61c24ee9mr2167197qkj.26.1713957908291; Wed, 24 Apr 2024 04:25:08 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHMtoPJRIA4RubKZO/ntarrMlyI47ljObOpcgLft8whyuArxnUgvL/v+XcMK6Zdf1epeyRc0g== X-Received: by 2002:a37:de19:0:b0:78d:61c2:4ee9 with SMTP id h25-20020a37de19000000b0078d61c24ee9mr2167185qkj.26.1713957907951; Wed, 24 Apr 2024 04:25:07 -0700 (PDT) Received: from [192.168.1.18] ([79.123.79.31]) by smtp.gmail.com with ESMTPSA id vv26-20020a05620a563a00b007907b57aa1fsm2112764qkn.12.2024.04.24.04.25.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 24 Apr 2024 04:25:07 -0700 (PDT) Message-ID: Date: Wed, 24 Apr 2024 12:25:05 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: Commit: readelf: Improve display of RELR relocations To: Fangrui Song Cc: binutils@sourceware.org References: <87edbb99kx.fsf@redhat.com> From: Nick Clifton Autocrypt: addr=nickc@redhat.com; keydata= xsFNBFm/2cUBEADkvRqMWfAryJ52T4J/640Av5cam9ojdFih9MjcX7QWFxIzJfTFYq2z+nb4 omdfZosdCJL2zGcn6C0AxpHNvxR9HMDkEyFHKrjDh4xWU+pH4z9azQEqJh331X7UzbZldqQo 16VkuVavgsTJaHcXm+nGIBTcUbl2oiTtHhmuaYxx6JTMcFjC7vyO5mLBw78wt52HBYweJ0Nj HBvvH/JxbAAULSPRUC61K0exlO49VFbFETQNG1hZTKEji95fPbre7PpXQ0ewQShUgttEE/J3 UA4jYaF9lOcZgUzbA27xTV//KomP0D30yr4e4EJEJYYNKa3hofTEHDXeeNgM25tprhBUMdbV RZpf2Keuk2uDVwc+EiOVri48rb1NU+60sOXvoGO6Ks81+mhAGmrBrlgLhAp8K1HPHI4MG4gH nrMqX2rEGUGRPFjC3qqVVlPm8H05PnosNqDLQ1Pf7C0pVgsCx6hKQB7Y1qBui7aoj9zeFaQg pYef+CEERIKEcWwrjaOJwK3pi9HFdxS0NNWYZj8HPzz/AsgTTQdsbulPlVq2SsctmOnL42CZ OCTppGYwl53CG/EqVY+UQBzFzJBaY8TJRFFYVEy5/HH4H11rMoZwqIkk71EOGU3X6mWlANRi kR3M4GhVITRzuaV69Fed+OeXcCmP94ASLfuhBR2uynmcHpBKpwARAQABzTtOaWNrIENsaWZ0 b24gKENoaWVmIEJpbnV0aWxzIE1haW50YWluZXIpIDxuaWNrY0ByZWRoYXQuY29tPsLBeAQT AQIAIgUCWb/ZxQIbAwYLCQgHAwIGFQgCCQoLBBYCAwECHgECF4AACgkQE/zvid2ePE9cOxAA 3cX1bdDaTFttTqukdPXLCtD2aNwJos4vB4LYPSgugLkYaHIQH9d1NQPhS0TlUeovnFNESLaV soihv0YmBUCyL4jE52FRoTjE6fUhYkFNqIWN2HYwkVrSap2UUJFquRVoVbPkbSup8P+D8eyd BbdxsY6f+5E8Rtz5ibVnPZTib7CyqnFokJITWjzGdIP0Gn+JWVa6jtHTImWx1MtqiuVRDapU hrIoUIjf98HQn9/N5ylEFYQTw7tzaJNWeGUoGYS8+8n/0sNbuYQUU/zwMVY9wpJcrXaas6yZ XGpF/tua59t9LFCct+07YAUSWyaBXqBW3PKQz7QP+oE8yje91XrhOQam04eJhPIBLO88g6/U rdKaY7evBB8bJ76Zpn1yqsYOXwAxifD0gDcRTQcB2s5MYXYmizn2GoUm1MnCJeAfQCi/YMob R+c8xEEkRU83Tnnw3pmAbRU6OcPihEFuK/+SOMKIuV1QWmjkbAr4g9XeXvaN+TRJ9Hl/k1k/ sj+uOfyGIaFzM/fpaLmFk8vHeej4i2/C6cL4mnahwYBDHAfHO65ZUIBAssdA6AeJ+PGsYeYh qs6zkpaA2b0wT4f9s7BPSqi0Veky8bUYYY7WpjzDcHnj1gEeIU55EhOQ42dnEfv7WrIAXanO P8SjhgqAUkb3R88azZCpEMTHiCE4bFxzOmjOwU0EWb/ZxQEQALaJE/3u23rTvPLkitaTJFqK kwPVylzkwmKdvd2qeEFk1qys2J3tACTMyYVnYTSXy5EJH2zJyhUfLnhLp8jJZF4oU5QehOaJ PcMmzI/CZS1AmH+jnm6pukdZAowTzJyt4IKSapr+7mxcxX1YQ2XewMnFYpLkAA2dHaChLSU/ EHJXe3+O4DgEURTFMa3SRN/J4GNMBacKXnMSSYylI5DcIOZ/v0IGa5MAXHrP1Hwm1rBmloIc gmzexczBf+IcWgCLThyFPffv+2pfLK1XaS82OzBC7fS01pB/eDOkjQuKy16sKZX6Rt57vud4 0uE5a0lpyItC2P7u7QWL4yT5pMF+oS8bm3YWgEntV380RyZpqgJGZTZLNq2T4ZgfiaueEV4J zOnG2/QRGjOUrNQaYzKy5V127CTnRg4BYF/uLEmizLcI3O3U1+mEz6h48wkAojO1B6AZ8Lm+ JuxOW5ouGcrkTEuIG56GcDwMWS/Pw/vNsDyNmOCjy9eEKWJgmMmLaq59HpfTd8IOeaYyuAQH AsYt/zzKy0giMgjhCQtuc99E4nQE9KZ44DKsnqRabK9s3zYE3PIkCFIEZcUiJXSXWWOIdJ43 j+YyFHU5hqXfECM6rzKGBeBUGTzyWcOX6YwRM4LzQDVJwYG8cVfth+v4/ImcXR43D4WVxxBE AjKag02b+1yfABEBAAHCwV8EGAECAAkFAlm/2cUCGwwACgkQE/zvid2ePE/dqQ/6ApUwgsZz tps0MOdRddjPwz44pWXS5MG45irMQXELGQyxkrafc8lwHeABYstoK8dpopTcJGE3dZGL3JNz 1YWxQ5AV4uyqBn5N8RubcA8NzR6DQP+OGPIwzMketvVC/cbbKDZqf0uTDy3jP65OFhSkTEIy nYv1Mb4JJl3Sq+haUbfWLAV5nboSuHmiZE6Bz2+TjdoVkNwHBfpqxu6MlWka+P98SUcmY8iV hPy9QC1XFOGdFDFf1kYgHW27mFwds35NQhNARgftAVz9FZXruW6tFIIfisjr3rVjD9R8VgL7 l5vMr9ylOFpepnI6+wd2X1566HW7F1Zw1DIrY2NHL7kL5635bHrJY4n7o/n7Elk/Ca/MAqzd IZxz6orfXeImsqZ6ODn4Y47PToS3Tr3bMNN9N6tmOPQZkJGHDBExbhAi/Jp8fpWxMmpVCUl6 c85cOBCR4s8tZsvGYOjR3CvqKrX4bb8GElrhOvAJa6DdmZXc7AyoVMaTvhpq3gJYKmC64oqt 7zwIHwaCxTbP6C6oUp9ENRV7nHnXN3BlvIgCo4QEs6HkDzkmgYlCEOKBiDyVMSkPDZdsspa+ K4GlU2Swi/BDJMjtDxyo+K0M81LXXxOeRfEIfPtZ3ddxBKPva1uSsuz+pbN9d1JY8Ko5T/h1 6susi2ReUyNJEJaSnjO5z13TQ1U= In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-GB Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Fangrui, > I've only got two nits: > > Perhaps PRId64 should be changed to PRIu64 as num_rela is unsigned? Good point. In fact there are several places where this change would be appropriate. > At /* It is theoretically possible for nentries to be 1. */ , `if > (nentries == 0` does not free `relrs`. > Can `if (nentries == 0` be removed since the for loop handles the > zero-entry case? I could do that. But since we know that the number of entries is zero, why bother loading the relr data at all ? It makes more sense to move the check for (nentries == 0) to before the call the get_data() and thus eliminating the need to load - and free - the section contents. I am just running some last minute checks on the revised patch and then I will check it in shortly. Cheers Nick