From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-x22d.google.com (mail-lj1-x22d.google.com [IPv6:2a00:1450:4864:20::22d]) by sourceware.org (Postfix) with ESMTPS id 4D8663858402 for ; Fri, 5 Jan 2024 14:05:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4D8663858402 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 4D8663858402 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::22d ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704463528; cv=none; b=jZ/0/0gmThs/Ljl3BWppti15hAPcWzCwxLl3M7hgMmkI+2kiaU/eKqHnWTGMw9VUkcK1pwV44eGltFnjGb4BBU0TEasCurDQw6p1dVuzY3eW9Uvbh3KflkqVXj0PCgKXNVnB5vitGiWYWrjltAo0XNRU2w1aVHxW6D7tY8CHob4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704463528; c=relaxed/simple; bh=MyMJbZSLkJNpzIisScgt5Xfaep0xU96JMnGnpbZgWik=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=rgmjz/Wo7MxM2rBgechdRj36Famx8CQFuKv9W366JJ8L1q0xf+wIkRvvscyUBU+Nu0oV8NVcIlzc0tytOwAyp7A0uMShzCnUXMh/dvg2mRfXIvnRK7zYw/WNKHQqyIo83JKOt+6G4RGOmOFJpY/zaZVSIY5v4hCeBXMuWgHhxuo= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-lj1-x22d.google.com with SMTP id 38308e7fff4ca-2ccbf8cbf3aso23432571fa.3 for ; Fri, 05 Jan 2024 06:05:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1704463525; x=1705068325; darn=sourceware.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:cc:references :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=CFRa8/5LOLRIZ5e38QSY03G80XmMwSRNQXJgqgpiftI=; b=RBJv+7G6aVVo13JOedDgi9+QwfDFkf1L2cWtfG35iFt4ADO3eHS9WEZl4tnaxq2ORC h74ncBB+7ShBCPM/Z65SeGZIjw8rn8VviXakHIw2GVjTX4R+/g3Xb3xnp9+5jQorWMzm QWVr50Q3AD4W3pqWdylRS/DAdYqDn1IhBtuI37bZqa83cbHswCpzPyP7JV2ld45e8uIp Jrp9wlOVBZS9R6/As7j73PenJWWusxAr//ppb/l3ZIDSQLBHWgjz0JIhE0N/YN+qia7m 0cXq3jB/DxzwiKgu1iR/93s1D2cYdhq+hFtLRCMJrV5z/ufBFRQxwFfkjpPEAumIBKUy PeGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704463525; x=1705068325; h=content-transfer-encoding:in-reply-to:autocrypt:from:cc:references :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=CFRa8/5LOLRIZ5e38QSY03G80XmMwSRNQXJgqgpiftI=; b=pu70OO7D0VzMFJOjOqLjzU5bCGPvteU+b48Z50RhaUcQFUcdQ50k3bSeaJPm0c8TLq ZZNtSm98Od4VWln2pl/nRlFAkhWbEFj/5uMYDM1B66gbi9DJG8G26MiRh6tyV4dFW7Z0 QhwAps0PCTlweT5NMIPKR3/z1v4NmGQ7aEQTm5sw3nXTBVj2oGHtpePljbh2UVYdLw4L IlCVSfr0VCtTUJmFiB13ydEe++FPVd6kiMgtn2IHSSi2jlWcG/IWSoE1I+6SuXIBzE2k 2rGz3Z3KZ4TVAtyEnO0qcq8YrhVHhWCdA53sjaJjVC3z+4vJXq/D1h8iiEs0csqcL9Zg sGig== X-Gm-Message-State: AOJu0YxlKtfbp/XfUFM1E3gxmLj8wcthZH/Z0GmpJbj0JKAWmrTOut4R LCLMszhOoLs1udsFKHO6hdLFTCD+XslX X-Google-Smtp-Source: AGHT+IFnMVrNwDdc5VX7aAfogLc7CGMMSAksWFqIBoncPlFpy8XDy0qyUmYgQAQWx9Rh1Af8eX86bg== X-Received: by 2002:a2e:b987:0:b0:2cc:7103:6b21 with SMTP id p7-20020a2eb987000000b002cc71036b21mr1140938ljp.53.1704463524785; Fri, 05 Jan 2024 06:05:24 -0800 (PST) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id bb32-20020a0566383b2000b0046ce40d28a9sm433385jab.105.2024.01.05.06.05.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 05 Jan 2024 06:05:24 -0800 (PST) Message-ID: Date: Fri, 5 Jan 2024 15:05:21 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH, V4 09/14] opcodes: i386: new marker for insns that implicitly update stack pointer Content-Language: en-US To: Indu Bhagat References: <20240103071526.3846985-1-indu.bhagat@oracle.com> <20240103074341.3858511-1-indu.bhagat@oracle.com> Cc: binutils@sourceware.org From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <20240103074341.3858511-1-indu.bhagat@oracle.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3026.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 03.01.2024 08:43, Indu Bhagat wrote: > --- a/opcodes/i386-opc.h > +++ b/opcodes/i386-opc.h > @@ -750,6 +750,9 @@ enum > /* No CSPAZO flags update indication. */ > NF, > > + /* Instruction updates stack pointer implicitly. */ > + ImplicitStackOp, > + > /* The last bitfield in i386_opcode_modifier. */ > Opcode_Modifier_Num > }; > @@ -796,6 +799,7 @@ typedef struct i386_opcode_modifier > unsigned int isa64:2; > unsigned int noegpr:1; > unsigned int nf:1; > + unsigned int implicitstackop:1; > } i386_opcode_modifier; I'm not happy to see a new attribute be introduced for this (a new OperandConstraint enumerator would seem more appropriate), while at the same time I can see that the Rex2 attribute used in two of the affected insns presently makes this impossible. However, with no other way out, I'd rather see Rex2 become a standalone attribute, and this one be another operand constraint. Jan