From: "Richard Earnshaw (lists)" <Richard.Earnshaw@arm.com>
To: Nick Clifton <nickc@redhat.com>, binutils@sourceware.org
Subject: Re: Commit: Fix gas testsuite failures for non-ELF AArch64 toolchains
Date: Tue, 27 Jun 2023 14:45:17 +0100 [thread overview]
Message-ID: <f8c3ffb3-4bca-1f7a-0510-d9cb74a3fcba@arm.com> (raw)
In-Reply-To: <87mt0myyc2.fsf@redhat.com>
On 26/06/2023 17:37, Nick Clifton via Binutils wrote:
> Hi Guys,
>
> A lot of AArch64 specific tests in the GAS testsuite assume that they
> are targeting an ELF based toolchain. This does not have to be the
> case however, so I am checking in the attached patch to skip any tests
> that are just not supported and to tweak the regexps in those that are
> supported.
This seems a little draconian (a test doesn't work so we ignore it)?
Most of these tests ought to pass (or have equivalent dump files that do
pass) in all object format types; they're not really ELF-specific tests.
The bfloat16 tests should really be fixed so that the test source is
tail-padded with zeros to at least a word boundary (perhaps even
64-bit); then a regexp to ignore the tail wouldn't be needed.
Those looking for specific relocations should have coff equivalent '.d'
files to check the coff format output.
I'm not sure why netbsd is excluded, it's been always ELF format on aarch64.
I'd be much more inclined to rename the problematic .d files as -elf.d
and then add variants for coff, with both using the same source .s file.
Only where the test is specifically designed to test the ELF format
(or an feature of it) should we be skipping the test entirely.
R.
>
> Cheers
> Nick
>
> gas/ChangeLog
> 2023-06-26 Nick Clifton <nickc@redhat.com>
>
> * testsuite/gas/aarch64/bfloat16-directive-be.d: Adjust regexps
> to allow for non-ELF based toolchains.
> * testsuite/gas/aarch64/bfloat16-directive-le.d: Likewise.
> * testsuite/gas/aarch64/optional.d: Likewise.
> * testsuite/gas/aarch64/pr20364.d: Likewise.
> * testsuite/gas/aarch64/adr_1.d: Skip for non-ELF based toolchains.
> * testsuite/gas/aarch64/advsimd-mov-bad.d: Likewise.
> * testsuite/gas/aarch64/b_1.d: Likewise.
> * testsuite/gas/aarch64/beq_1.d: Likewise.
> * testsuite/gas/aarch64/codealign_1.d: Likewise.
> * testsuite/gas/aarch64/dwarf.d: Likewise.
> * testsuite/gas/aarch64/ilp32-basic.d: Likewise.
> * testsuite/gas/aarch64/int-insns.d: Likewise.
> * testsuite/gas/aarch64/ldr_1.d: Likewise.
> * testsuite/gas/aarch64/mapping_5.d: Likewise.
> * testsuite/gas/aarch64/mapping_6.d: Likewise.
> * testsuite/gas/aarch64/mops_invalid_2.d: Likewise.
> * testsuite/gas/aarch64/movw_label.d: Likewise.
> * testsuite/gas/aarch64/pac_ab_key.d: Likewise.
> * testsuite/gas/aarch64/pac_negate_ra_state.d: Likewise.
> * testsuite/gas/aarch64/pr27217.d: Likewise.
> * testsuite/gas/aarch64/pr29519.d: Likewise.
> * testsuite/gas/aarch64/programmer-friendly.d: Likewise.
> * testsuite/gas/aarch64/reloc-data.d: Likewise.
> * testsuite/gas/aarch64/reloc-dtprel_g0-ilp32.d: Likewise.
> * testsuite/gas/aarch64/reloc-dtprel_g0.d: Likewise.
> * testsuite/gas/aarch64/reloc-dtprel_g0_nc-ilp32.d: Likewise.
> * testsuite/gas/aarch64/reloc-dtprel_g0_nc.d: Likewise.
> * testsuite/gas/aarch64/reloc-dtprel_g1-ilp32.d: Likewise.
> * testsuite/gas/aarch64/reloc-dtprel_g1.d: Likewise.
> * testsuite/gas/aarch64/reloc-dtprel_g1_nc.d: Likewise.
> * testsuite/gas/aarch64/reloc-dtprel_g2.d: Likewise.
> * testsuite/gas/aarch64/reloc-dtprel_hi12-ilp32.d: Likewise.
> * testsuite/gas/aarch64/reloc-dtprel_hi12.d: Likewise.
> * testsuite/gas/aarch64/reloc-dtprel_lo12-1.d: Likewise.
> * testsuite/gas/aarch64/reloc-dtprel_lo12-ilp32-1.d: Likewise.
> * testsuite/gas/aarch64/reloc-dtprel_lo12-ldst16.d: Likewise.
> * testsuite/gas/aarch64/reloc-dtprel_lo12-ldst32.d: Likewise.
> * testsuite/gas/aarch64/reloc-dtprel_lo12-ldst64.d: Likewise.
> * testsuite/gas/aarch64/reloc-dtprel_lo12-ldst8.d: Likewise.
> * testsuite/gas/aarch64/reloc-dtprel_lo12_nc-ilp32.d: Likewise.
> * testsuite/gas/aarch64/reloc-dtprel_lo12_nc-ldst16.d: Likewise.
> * testsuite/gas/aarch64/reloc-dtprel_lo12_nc-ldst32.d: Likewise.
> * testsuite/gas/aarch64/reloc-dtprel_lo12_nc-ldst64.d: Likewise.
> * testsuite/gas/aarch64/reloc-dtprel_lo12_nc-ldst8.d: Likewise.
> * testsuite/gas/aarch64/reloc-dtprel_lo12_nc.d: Likewise.
> * testsuite/gas/aarch64/reloc-gotoff_g0_nc.d: Likewise.
> * testsuite/gas/aarch64/reloc-gotoff_g1.d: Likewise.
> * testsuite/gas/aarch64/reloc-gottprel_g0_nc.d: Likewise.
> * testsuite/gas/aarch64/reloc-gottprel_g1.d: Likewise.
> * testsuite/gas/aarch64/reloc-insn.d: Likewise.
> * testsuite/gas/aarch64/reloc-prel_g0.d: Likewise.
> * testsuite/gas/aarch64/reloc-prel_g0_nc.d: Likewise.
> * testsuite/gas/aarch64/reloc-prel_g1.d: Likewise.
> * testsuite/gas/aarch64/reloc-prel_g1_nc.d: Likewise.
> * testsuite/gas/aarch64/reloc-prel_g2.d: Likewise.
> * testsuite/gas/aarch64/reloc-prel_g2_nc.d: Likewise.
> * testsuite/gas/aarch64/reloc-prel_g3.d: Likewise.
> * testsuite/gas/aarch64/reloc-tlsdesc_off_g0_nc.d: Likewise.
> * testsuite/gas/aarch64/reloc-tlsdesc_off_g1.d: Likewise.
> * testsuite/gas/aarch64/reloc-tlsgd_g0_nc.d: Likewise.
> * testsuite/gas/aarch64/reloc-tlsgd_g1.d: Likewise.
> * testsuite/gas/aarch64/reloc-tlsldm-1.d: Likewise.
> * testsuite/gas/aarch64/reloc-tlsldm-ilp32-1.d: Likewise.
> * testsuite/gas/aarch64/reloc-tlsldm-page-1.d: Likewise.
> * testsuite/gas/aarch64/reloc-tlsldm-page-ilp32-1.d: Likewise.
> * testsuite/gas/aarch64/reloc-tlsldm_lo12_nc-1.d: Likewise.
> * testsuite/gas/aarch64/reloc-tlsldm_lo12_nc-ilp32-1.d: Likewise.
> * testsuite/gas/aarch64/reloc-tprel_lo12-ldst16-ilp32.d: Likewise.
> * testsuite/gas/aarch64/reloc-tprel_lo12-ldst16.d: Likewise.
> * testsuite/gas/aarch64/reloc-tprel_lo12-ldst32-ilp32.d: Likewise.
> * testsuite/gas/aarch64/reloc-tprel_lo12-ldst32.d: Likewise.
> * testsuite/gas/aarch64/reloc-tprel_lo12-ldst64-ilp32.d: Likewise.
> * testsuite/gas/aarch64/reloc-tprel_lo12-ldst64.d: Likewise.
> * testsuite/gas/aarch64/reloc-tprel_lo12-ldst8-ilp32.d: Likewise.
> * testsuite/gas/aarch64/reloc-tprel_lo12-ldst8.d: Likewise.
> * testsuite/gas/aarch64/reloc-tprel_lo12_nc-ldst16-ilp32.d: Likewise.
> * testsuite/gas/aarch64/reloc-tprel_lo12_nc-ldst16.d: Likewise.
> * testsuite/gas/aarch64/reloc-tprel_lo12_nc-ldst32-ilp32.d: Likewise.
> * testsuite/gas/aarch64/reloc-tprel_lo12_nc-ldst32.d: Likewise.
> * testsuite/gas/aarch64/reloc-tprel_lo12_nc-ldst64-ilp32.d: Likewise.
> * testsuite/gas/aarch64/reloc-tprel_lo12_nc-ldst64.d: Likewise.
> * testsuite/gas/aarch64/reloc-tprel_lo12_nc-ldst8-ilp32.d: Likewise.
> * testsuite/gas/aarch64/reloc-tprel_lo12_nc-ldst8.d: Likewise.
> * testsuite/gas/aarch64/sve-movprfx_1.d: Likewise.
> * testsuite/gas/aarch64/sve-movprfx_10.d: Likewise.
> * testsuite/gas/aarch64/sve-movprfx_11.d: Likewise.
> * testsuite/gas/aarch64/sve-movprfx_12.d: Likewise.
> * testsuite/gas/aarch64/sve-movprfx_13.d: Likewise.
> * testsuite/gas/aarch64/sve-movprfx_14.d: Likewise.
> * testsuite/gas/aarch64/sve-movprfx_15.d: Likewise.
> * testsuite/gas/aarch64/sve-movprfx_16.d: Likewise.
> * testsuite/gas/aarch64/sve-movprfx_17.d: Likewise.
> * testsuite/gas/aarch64/sve-movprfx_18.d: Likewise.
> * testsuite/gas/aarch64/sve-movprfx_19.d: Likewise.
> * testsuite/gas/aarch64/sve-movprfx_2.d: Likewise.
> * testsuite/gas/aarch64/sve-movprfx_20.d: Likewise.
> * testsuite/gas/aarch64/sve-movprfx_21.d: Likewise.
> * testsuite/gas/aarch64/sve-movprfx_22.d: Likewise.
> * testsuite/gas/aarch64/sve-movprfx_23.d: Likewise.
> * testsuite/gas/aarch64/sve-movprfx_24.d: Likewise.
> * testsuite/gas/aarch64/sve-movprfx_25.d: Likewise.
> * testsuite/gas/aarch64/sve-movprfx_26.d: Likewise.
> * testsuite/gas/aarch64/sve-movprfx_27.d: Likewise.
> * testsuite/gas/aarch64/sve-movprfx_28.d: Likewise.
> * testsuite/gas/aarch64/sve-movprfx_3.d: Likewise.
> * testsuite/gas/aarch64/sve-movprfx_4.d: Likewise.
> * testsuite/gas/aarch64/sve-movprfx_5.d: Likewise.
> * testsuite/gas/aarch64/sve-movprfx_6.d: Likewise.
> * testsuite/gas/aarch64/sve-movprfx_7.d: Likewise.
> * testsuite/gas/aarch64/sve-movprfx_8.d: Likewise.
> * testsuite/gas/aarch64/sve-movprfx_9.d: Likewise.
> * testsuite/gas/aarch64/symbol-variant_pcs-1.d: Likewise.
> * testsuite/gas/aarch64/symbol-variant_pcs-2.d: Likewise.
> * testsuite/gas/aarch64/symbol-variant_pcs-3.d: Likewise.
> * testsuite/gas/aarch64/system.d: Likewise.
> * testsuite/gas/aarch64/tail_padding.d: Likewise.
> * testsuite/gas/aarch64/tbz_1.d: Likewise.
> * testsuite/gas/aarch64/tls-desc.d: Likewise.
> * testsuite/gas/aarch64/tls.d: Likewise.
>
next prev parent reply other threads:[~2023-06-27 13:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-26 16:37 Nick Clifton
2023-06-27 13:45 ` Richard Earnshaw (lists) [this message]
2023-06-27 13:58 ` Nick Clifton
2023-06-27 14:33 ` Richard Earnshaw (lists)
2023-06-28 10:34 ` Nick Clifton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f8c3ffb3-4bca-1f7a-0510-d9cb74a3fcba@arm.com \
--to=richard.earnshaw@arm.com \
--cc=binutils@sourceware.org \
--cc=nickc@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).