From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gnu.wildebeest.org (gnu.wildebeest.org [45.83.234.184]) by sourceware.org (Postfix) with ESMTPS id 5DC893858D28 for ; Tue, 17 Jan 2023 12:53:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 5DC893858D28 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=klomp.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=klomp.org Received: from r6.localdomain (82-217-174-174.cable.dynamic.v4.ziggo.nl [82.217.174.174]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by gnu.wildebeest.org (Postfix) with ESMTPSA id 35929302BBEC; Tue, 17 Jan 2023 13:53:06 +0100 (CET) Received: by r6.localdomain (Postfix, from userid 1000) id 25EDD34024C; Tue, 17 Jan 2023 13:53:05 +0100 (CET) Message-ID: Subject: Re: [PATCH] C-SKY: Fix machine flag. From: Mark Wielaard To: Nick Clifton , Xianmiao Qu , binutils@sourceware.org, lifang_xia@linux.alibaba.com Date: Tue, 17 Jan 2023 13:53:05 +0100 In-Reply-To: References: <20230113125454.75744-1-cooper.qu@linux.alibaba.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.2 (3.46.2-1.fc37) MIME-Version: 1.0 X-Spam-Status: No, score=-3028.9 required=5.0 tests=BAYES_00,BODY_8BITS,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,RCVD_IN_BARRACUDACENTRAL,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi, On Tue, 2023-01-17 at 11:49 +0000, Nick Clifton via Binutils wrote: > Hi Xianmiao Qu, >=20 > > bfd/ > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0* elf32-csky.c (elf32_c= sky_merge_attributes): Don't save > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0and restore the ARCH at= tribute, it will actually clear > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0the ARCH attribute. > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0(csky_elf_merge_private= _bfd_data): Store the machine flag > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0correctly. >=20 > Approved and applied. Note that this broke the build on all arches: https://builder.sourceware.org/buildbot/#/changes/17260 ../../binutils-gdb/bfd/elf32-csky.c: In function =E2=80=98elf32_csky_merge_attributes=E2=80=99: ../../binutils-gdb/bfd/elf32-csky.c:2867:17: error: unused variable =E2=80=98tattr=E2=80=99 [-Werror=3Dunused-variable] 2867 | obj_attribute tattr; | ^~~~~ ../../binutils-gdb/bfd/elf32-csky.c: In function =E2=80=98csky_elf_merge_private_bfd_data=E2=80=99: ../../binutils-gdb/bfd/elf32-csky.c:3067:56: error: suggest parentheses around comparison in operand of =E2=80=98&=E2=80=99 [-Werror=3Dparentheses] 3067 | || (new_flags & (CSKY_ARCH_MASK | CSKY_ABI_MASK) !=3D | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~ 3068 | old_flags & (CSKY_ARCH_MASK | CSKY_ABI_MASK))) | ~~~~~~~~~ =20 cc1: all warnings being treated as errors make[3]: *** [Makefile:1765: elf32-csky.lo] Error 1 make[3]: *** Waiting for unfinished jobs....