From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 5CCC43858D1E for ; Mon, 13 Mar 2023 14:26:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 5CCC43858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1678717563; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=InLhnw+DGIzXbUvxwWAELlCmaBRp5h9PmNRTObvxSbs=; b=aYlomuW8rudh6nlpwfgb4n5DldbIc/LFAtGHa5K18BeHjj9nqZZV7+Iz/8AM69QCLsFJby zOglPK5CboX2GyBSk+H4IqURVndz8PA+aOY2AE5zlYhg+mQkaL3q2ObC9JbQ4HercheeVW ZIsZvIfmmzKSDD+LStZRwiJk9Pxmios= Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-397-jidj3uI6NZKbIncJTDtizA-1; Mon, 13 Mar 2023 10:26:01 -0400 X-MC-Unique: jidj3uI6NZKbIncJTDtizA-1 Received: by mail-qt1-f199.google.com with SMTP id h21-20020ac87d55000000b003bffb1c9745so6886690qtb.4 for ; Mon, 13 Mar 2023 07:26:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678717561; h=content-transfer-encoding:in-reply-to:subject:from:references:cc:to :content-language:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=InLhnw+DGIzXbUvxwWAELlCmaBRp5h9PmNRTObvxSbs=; b=7WnioX9yqlXjYAigi2WwMV0eOXFevz1eVErWUTNoQImfBP9YVouWPIuAId71P6xfxA P+StQPdpyIuhytN0RCvFej/oyRK1H38G0kg6P/CILnmYPydKspkfq6VPymZBJMyUFOgE MXeWwyTnW3zY2GRsDU0ujBAISvgdqpYb/jFTTPQ5lMqfscE6z90jl+sJ57vsHFqjoL81 S9IUJTsqaRcrtnSjySPnemynVg8hM/XoWRLoDRpuVknlbNWXBQUZfW6k9DHMzkMZ/N7q qdCEKVkmwYeKQuxIk79BnYLECF/IjXyLvr6rJ3XUp+qDo/lhi2gE7eaqDW4o1OEz3e9W 2z8A== X-Gm-Message-State: AO0yUKXRlabGncSEK8hYMu9vEdaXizwv96A4x4GpQvV//ME/LqTmjXFx bfU5QkiMf64PXEW/J1c50EmsrUgesmZ+EQeeGQ0/YoD1w/3giuOB5xQq7ocuE4e2pUnFLKNFwWg N0VKznaYzBf8uJOwr6w== X-Received: by 2002:a05:622a:1304:b0:3bf:a461:e6f0 with SMTP id v4-20020a05622a130400b003bfa461e6f0mr27817633qtk.31.1678717561132; Mon, 13 Mar 2023 07:26:01 -0700 (PDT) X-Google-Smtp-Source: AK7set+VkX+ZmbMltnrNq3g9bUywtZ+UWycweSJ88/0mc6dJsLKspQRrOe/h+7a5yR5VBL9sSZ1DAQ== X-Received: by 2002:a05:622a:1304:b0:3bf:a461:e6f0 with SMTP id v4-20020a05622a130400b003bfa461e6f0mr27817596qtk.31.1678717560861; Mon, 13 Mar 2023 07:26:00 -0700 (PDT) Received: from [192.168.1.7] ([79.123.86.193]) by smtp.gmail.com with ESMTPSA id c11-20020ac8008b000000b003b835e7e283sm5567952qtg.44.2023.03.13.07.25.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 13 Mar 2023 07:26:00 -0700 (PDT) Message-ID: Date: Mon, 13 Mar 2023 14:25:58 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 To: Jan Beulich Cc: Palmer Dabbelt , Andrew Waterman , Jim Wilson , Nelson Chu , Binutils , Alan Modra References: <150b4184-62af-3f5c-c07b-24b0c2ae788f@suse.com> <9f769d26-f51c-4f85-f61b-330226c1cc2d@suse.com> <0a576110-624b-6339-b24d-907d6df72e09@suse.com> From: Nick Clifton Subject: Re: [PATCH RFC] RISC-V: alter the special character used in FAKE_LABEL_NAME In-Reply-To: <0a576110-624b-6339-b24d-907d6df72e09@suse.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-GB Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Jan, > What I don't think you addressed is my 2nd observation wrt quoted symbol > names. There all characters can appear in symbol names, and hence > deriving "local" (or not) based on symbol name looks wrong to me. Ok, that is fair. Let's see. So the issue is, what should S_IS_LOCAL do if a user provides a global, quoted symbol name that includes characters that match DOLLAR_LABEL_CHAR, LOCAL_LABEL_CHAR or FAKE_LABEL_CHAR, right ? I would imagine that this is an extremely unusual case, which is why it has not come up before. First off, I wonder why S_IS_LOCAL does not check to see if BSF_GLOBAL is set in flags and return false if that is the case. If it did, I think that that would solve the problem. I cannot think of any situation where you could have a global symbol that needs to be treated as local for the purposes of S_IS_LOCAL. Alternatively, maybe it would be simpler to just document that quoted symbol names that contain special characters might be treated as if they were local symbols, and leave it up to the user to decide whether they want to risk such behaviour. Not very user friendly, but it would match the current behaviour. We could also add a warning to read_symbol_name() and get_symbol_name() to alert users to the problem. What do you think ? Any preferences ? Cheers Nick