From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2059.outbound.protection.outlook.com [40.107.22.59]) by sourceware.org (Postfix) with ESMTPS id C6B903858C74 for ; Wed, 23 Aug 2023 05:54:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C6B903858C74 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cER/1/oQX44D7K01UMlvYfh5jM4zm4AUbuAEq0LtZpoPpMOKd+L1OWFvBx2FzTtiNZNgElV79+dfS9wNVVXmM/aQmlQKsXqsC1yC4w9s1LvrSsnipdJv6zMDVnBA3b/GyTWXMhvS7I06/Ew87TV78ZgbLT756SMlxi8VCJgqTz+t+fR5yw322S/bH3s1yR4encqhip85fXqqcjVArRQL+xMx6y0ELeMMorwsV5epuRrhNojdW6gVzwU+fEumSoPcWfaN+MqiWM0Y5R9S7ZK0UeRixwJgBTo9zEbftAAURzh5QfqbwfjyU/wTvVDFklw2Lur2xAqAVhCg33vZJsTFKA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Q8FDEc+2/ulsFKPysu1x4FIA1yAVGpMV0VtQIAeX9rc=; b=NRT/oksAT20usLwezKLTApkQq8TJMT3QUdM+Ik/LPzR9+4TYyf50wuM5GGzlAbvgUAmu35PsM/e9ibbp1GXU/XuUXRju3f2mpsTKS4hEicGIlGiHEWidc7JGnAauG1s8DN86Xu8UUb/Ffg/NVy0aBBgMb0se40IxVCcGuuaS075b4HF2YrDXob9CIlh8yPKxFO0glWkUcWiv/HQVLamOQV6UrSJHfxvHcTWcJ2UR73x2fXMsPAftbezRr5p++16KZ2iNMeoSP/QXXey4YDZsTUrU6xYJJjhWcM7SFylGj1uZWbBFMmPbgJNZCIApnyEdYtBe+wPnqBRUotijP3asJA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Q8FDEc+2/ulsFKPysu1x4FIA1yAVGpMV0VtQIAeX9rc=; b=LmJ+XhtWRmK8nXas4zS+AANnCTZWa9Yjhmo7xCbSBvg6b0q08d55s7T8VZeFn2PgeVI5bOwk38F43UtiAodXgKNRNgBeR8dQcYLk5nmgmm+cJqVfOyx8AXpPdAbxKfMdQWjCvQdl34W4qkzt4wy04ZBNT2kMZ/8r3svob+R3RMf7qwPp1cXbt2cDUG9aRcMJkJrxgMglWKKSbQg4LT1/XAawxZWZI1EBTmSqQJNqK6qCZpIpBsxKh0FnyNxaH5zKWZzwakqkteIhNDd1IG65OVw9PJj54K4q9qdxXQf0AvuVmLDmGnVRDxroZB+vp7SfL8tPq8K/8kzaZ+4khHO4VQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by AS1PR04MB9407.eurprd04.prod.outlook.com (2603:10a6:20b:4d9::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6699.24; Wed, 23 Aug 2023 05:54:16 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::f749:b27f:2187:6654]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::f749:b27f:2187:6654%5]) with mapi id 15.20.6699.025; Wed, 23 Aug 2023 05:54:16 +0000 Message-ID: Date: Wed, 23 Aug 2023 07:54:13 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [PATCH v2] Support Intel AVX10.1 Content-Language: en-US To: "Jiang, Haochen" Cc: "hjl.tools@gmail.com" , "binutils@sourceware.org" References: <5eb31b18-e1ba-dbf1-bddb-ff03b61b25de@suse.com> <20230814064535.3228154-1-haochen.jiang@intel.com> <96638e6e-142f-b7f2-3a95-56e70e8d159f@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0169.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:b4::11) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|AS1PR04MB9407:EE_ X-MS-Office365-Filtering-Correlation-Id: 2752e76c-93ed-4b3a-c258-08dba39d6286 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: RsGlyo4ek1GHiwR4ekqeHXbxi5U3Zp1DsPZKi3Qy67zlRF2OSfrayBOLIGUujT1VjczN6IZeraSGU3oYNEOcmNuHTNznI5LivAeKEKpc0QvLwp3ONrcleQuPeeSRMdvafXrrU85d/IfphkwvxC80cZA6lnjCh1jDU6fKI+aB3+XlZnh17sr1Z6Wf3pMc62gAXsiRWQp2VxDhU+FdMhzfQe6XqUmmi+zBkRzSN8R09RBDEjvc4VPdZcISljcZMGUFPFI0V1RutljO7cRF7B9Eytknf9uV3GwopedORi0f9mklDpvnx8K50EY/IUnGhyd+4Db9tjVMHOG3g+Ee3CLn9Brc2l7/PjLnW2SHQfbVdRGqWZy2wKEivub3NuHuCSwFu6iqftAM63W5klI+ciJi+vPXQmSSjqZd8n8KHapW7+joioUyDg2hwmiFzC21XjOt/1cwvcpL62WWMPgbK2jziEDxsyCutoXGgOg4TidwFiqVsuzFhT4MRzs5EYTZfC7Lv3SCeLhghn4EA/29iljJ7C8kDS2l5Dc/VL/b58R8Vf+9lKDyFPalSdDMwwb3My9NTOXJYc2zSkyWTEiuOmFgxxYYphAIDB1gRM8S6+rMx4d3cWI2Cr1rbQ3j5v6gz8/v9l3Zy8l35qDjfVbAP0l8zg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(136003)(376002)(396003)(366004)(39860400002)(346002)(186009)(1800799009)(451199024)(54906003)(6916009)(66476007)(66556008)(66946007)(6512007)(316002)(8676002)(8936002)(2616005)(4326008)(36756003)(41300700001)(478600001)(6666004)(38100700002)(6506007)(6486002)(53546011)(83380400001)(2906002)(31686004)(31696002)(86362001)(5660300002)(26005)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VDczYzVaemEwa25nSGRhdW4xU3BtdllBbmlvNUFmWnZpbGY5MElQbTFhZE1t?= =?utf-8?B?UFE2K1ZWVGlqYnFldExVRWd6TVcyU01nckRvbUVmclZoZFpQTS9ZdlFneCtI?= =?utf-8?B?YnhTWjZJZGJiMnFERGhlZjBQdXNjdHp3bFZGa05MZ21qbVdjZHQwQXJkOE0r?= =?utf-8?B?NUp3a2dDUHZlcU9hbVNQdWcvOHhXSEdkZm9pUVRhbHoxLzhLMlg1b1Z6MlhI?= =?utf-8?B?OGYzVk5tZGhnWG9xMUg2YnZVYzViNDdEOS83c0JJc214TVNaanNqTWFYNjlJ?= =?utf-8?B?dWdFMjJORkF1bnMrK1lxelp6WjBud2ZvdFI4NGl3RXp1WnY3N0RDMVV3OVFz?= =?utf-8?B?WXF3cjFBcE9EcUw1U3RvcWk0bzhML0Fnamp6ZHJlMXNtWHhEWGNrb3BlQ3cz?= =?utf-8?B?a2gyUXJSS2tRbE9xWGxqdW1xOUsyT29CUGhaSzl5Z1Y3Umx6THdHb1dIZjdT?= =?utf-8?B?SEt1cHRWN0JWaEM3RHV4c2RIa0M3TEwrbzh6cDUvUzg0RGFNRkZubmEyK0t5?= =?utf-8?B?VHQ3QmttS21zUTNjZ3pYMEt5RUdzeGRkT0pvMVIyTGJEU204aU1kVTlzaHI2?= =?utf-8?B?WDVZdndGbGUzb09LSENFTXZqU0oyWUtNK0hxeVhJZGhBMEE2SUFOL25Wc2l0?= =?utf-8?B?TzJCaS9uUjh1R1YzWmFidXowbTg3MW16UDNESXN1OUI3ajRrSnFyN0YvV3pl?= =?utf-8?B?aDBBZ1BtWmxDaWFoWnpmOW5TOHhaZmo1TmNqZGNxZlpXTkhycmtwTzRhYmtq?= =?utf-8?B?UzBBcnpBRXpDL0trVEgwMlB1Q1FYZTJ2enhmckQ3b3pwRXZKSlh1ZUV6ZEtY?= =?utf-8?B?VmpKOGt6blNWSjF1VEhUVmFLVEE5WlhlVFdvUnFIa21zR1d5c01rZHVSTm51?= =?utf-8?B?ZG05SGd5L3BDc0ZtSHExcHRTREpjcko3aTRuTlVuQWdkOUp5UmxFQXQxbkZE?= =?utf-8?B?SS9BNnRYRE8vUzl6RTNMWEVBbWRJZm13Q29mT2kxcFpieG4vWGRsVzE5MzJh?= =?utf-8?B?SzczOG5oRkZVQWUvaTVaOXF6R0R0bW5zWnRRck1Scng4SXFrVzVWR0RtZjQ5?= =?utf-8?B?Ni9FYjkxMENGaitjamk2VW92c1RvcHBRWVpJdHZhMW5mUU5VTk80ODZ6KzdF?= =?utf-8?B?OVhUUWFTcXZiWE1LS0VIdlNGMlE4WHd5QkZsSStjNXJLR1RVODI1NmpHNlNa?= =?utf-8?B?Y2lpMDgxREtwa3NBK0d2UDBtSXROM2JveTNoTk5md1R0ZEp3T1pPZ2ZkTi8r?= =?utf-8?B?OWVYdmllejV1NVJpUytHc1YzS2QyK1hwT0pHS1h1aFUyYjRmWFR4a0x5OFNN?= =?utf-8?B?ZmtWVU91YWFqcFoyTVkvRytXMDJHT296aG5pWWJVT0ZJd1NrK3d3QnVYS21i?= =?utf-8?B?T3NqYWtJWklVd21nY3FNL3JrdW9ucTZyY3hLRnB6SHBhT0hPSjdkelQ0SUdM?= =?utf-8?B?aDJDSTlpV09ZV3JPOEpLdHpBRERobVAycC9lUFBHKzNCUkdiSjhRMTExdHFD?= =?utf-8?B?a1hiVno2dlgxZTJFbUNVMGtENVdrdkkwTTlmVFIwbXRNMXdudklabGpiZWgz?= =?utf-8?B?b3puajBONFE5ODRobG5QVlpxZS85UGh5NGVMUHZwUEJhV04rbmw3NXB1cGdi?= =?utf-8?B?YnU5V2tiL3p2Mk9uMGF4QzJnb1hRMG5DbnZRVjJUSEw2QTVoRTNiNEJOWDF1?= =?utf-8?B?UTk4SlFZQmpMS1FYeDRmSXk3TGRNblZmRkwzUmtQajFybkpJQ0E3bFJGYk1Q?= =?utf-8?B?RTdzdVVtVytCYWFBb0padVI1RXFmM3pOa0xUY0txMTU4T1dBVVN6SnFCZzFY?= =?utf-8?B?Wkkrd3ROc3ZKd2hCYXlaTUs3djRHdDFXZnJJTTcwajU5STU2SkJqN2lMYkRB?= =?utf-8?B?SXJnUEJaaXRlY0ZFY3pGUkcxVFQwYStRaWduY3JhNlhtSWhhazdLMGd6T2Na?= =?utf-8?B?dktzWG9FUDlKdW5FZjV3YzZVa2NVd0NEUmJ4ZkxGUzF5NzhqejRMcFRxS3VH?= =?utf-8?B?NkxqKzNCdVFoOVRnQlVKTEswUjJNZTZja0lUOWJTU0d3VmJyUDNPT3U4djBr?= =?utf-8?B?NzBpWjV4VHdpTnFvbWdMYWFWT0NVaU9mMDJwNWpOQVE3V3kvQS9XYm5lR1JC?= =?utf-8?Q?HOSNwGO4+bp/HFjo9QJuPCnZC?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2752e76c-93ed-4b3a-c258-08dba39d6286 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Aug 2023 05:54:16.3398 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: SG2Hbnhifl8TQFQDiVgYYudXksRa/n4uS223ZSbYYDCw5nDA3L+mS26r5jtNWBy+b9U5f6zi/SGEeEayzq3RlQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS1PR04MB9407 X-Spam-Status: No, score=-3028.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_NUMSUBJECT,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 23.08.2023 04:20, Jiang, Haochen wrote: > > >> -----Original Message----- >> From: Jan Beulich >> Sent: Friday, August 18, 2023 9:03 PM >> To: Jiang, Haochen >> Cc: hjl.tools@gmail.com; binutils@sourceware.org >> Subject: Re: [PATCH v2] Support Intel AVX10.1 >> >> On 14.08.2023 08:45, Haochen Jiang wrote: >>> @@ -1315,6 +1321,20 @@ output_i386_opcode (FILE *table, const char >> *name, char *str, >>> ident = mkident (name); >>> fprintf (table, " { MN_%s, 0x%0*llx%s, %u,", >>> ident, 2 * (int)length, opcode, end, i); >>> + >>> + j = strlen(ident); >>> + /* All AVX512F based instructions are usable for AVX10.1 except >>> + AVX512PF/ER/4FMAPS/4VNNIW/VP2INTERSECT. */ if (strstr >>> + (cpu_flags, "AVX512") >>> + && !strstr (cpu_flags, "AVX512PF") >>> + && !strstr (cpu_flags, "AVX512ER") >>> + && !strstr (cpu_flags, "4FMAPS") >>> + && !strstr (cpu_flags, "4VNNIW") >>> + && !strstr (cpu_flags, "VP2INTERSECT")) >>> + { >>> + cpu_flags = concat (cpu_flags, "|AVX10_1", NULL); >>> + k = 1; >>> + } >>> free (ident); >> >> While making a patch myself along the lines of what I had outlined, I came to >> realize that the above isn't enough. (I'm pretty sure I wouldn't have spotted >> this by merely reviewing your patch.) This may be a result of the spec being >> somewhat ambiguous when it comes to GFNI, VAES, and VPCLMULQDQ. >> There's a note there saying something about the respective EVEX encodings. >> But that still requires the VEX encodings connected to these three features to >> also become suitably available. While this works fine for GFNI, it doesn't for >> the other two: The 128-bit VEX encodings, which surely are available when the >> 256-bit ones are, would become impossible to use. The assembler would pick >> the (larger) EVEX forms instead. There are two ways to solve this that I can see >> right away: >> 1) AES becomes a dependency of VAES (and PCLMULQDQ one of >> VPCLMULQDQ) >> 2) We put in place extra templates. >> I'm wary of the first option as long as not at least informally supported by you >> (Intel). Hence I went with option 2 for now. >> >> I'm only done with the /512 patch, so I won't post right away. I'm still >> debating with myself whether to control maximum vector length via a new >> directive, or via a special form of .arch. > > Do you think a command line option like -mavx10maxvl=256/512 with default 512 > is ok for this scenario? I am working to revise the AVX10.1 patch like that. That's certainly an option, but right now I have different plans. Jan