From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by sourceware.org (Postfix) with ESMTPS id 4BE8738582A7 for ; Sat, 24 Feb 2024 07:44:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4BE8738582A7 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=oracle.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=oracle.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 4BE8738582A7 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=205.220.177.32 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1708760676; cv=pass; b=AodnYHcmxQlTkKZKYxXdpUerNYz5GLB+YVZC5Cz1AxHWE+a1LJ58m928tPtOqWN09taVI4NDN3cahbLfHh0FMRUaiDjpkra1mOqFYj8nBDkI6S2hLVlGj+3J7unTfeIoYJrGnfNbV6BTBvYqNkMTbQoTALk6vCHFfqGYk3W/dNc= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1708760676; c=relaxed/simple; bh=TDrDay1YjxoiW3JkxqG2pNkhlLKfBPDrkLGqF3n79Bw=; h=DKIM-Signature:DKIM-Signature:Message-ID:Date:From:Subject:To: MIME-Version; b=tFGBd2yxYhzsRwEGxLt2PYnAwrxBOXG6D5hB1MF7rte4Q/MfijkiprhX0tRU1EE5PNCq7KiVQ0gCeH0fxeuKEoxzp/JVpjbS4ltCpAAgv51wLLcoI2zB392DE7YdciKVHDBgxWxFpVo4aD+eMaSRNBtMnBmzMCwuJQfWnxEbXgo= ARC-Authentication-Results: i=2; server2.sourceware.org Received: from pps.filterd (m0333520.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 41O5ZKS7031471; Sat, 24 Feb 2024 07:44:31 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=message-id : date : from : subject : to : cc : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2023-11-20; bh=50NBJVD5Xvw3DFPkGr+4gQMSG184YWI9CmNz7u65Riw=; b=m3+pC37d8faVhylqXCLxEOcy6dwHm9/XTZECMBpqj06SfSK2DVqsUb8RC3dDwJTEQQec xOwtTE6M9km2oCIak2s95lip7bPy6havloVVwAqijM/T4JCgmoNnhFwD1yR8MF8iqyUZ yvLPfaiPlBuXFHzm9jEEGEj1dgxJq5UmemNp00FUF1KQl1905o3l8DujGbRDPoP9jIzn irRtuh16WVhNR67ee/Tqx49s/TbMJoI8hLxapkNp/7TQTDN6xI5E8m6mz9MKG3Cvgn+L VCs455m5GKG8gtSt4fe/jEOi0Rv03RK1WTlY+TjFZjORlxqF1YwjGbkvC79QqA2RFf/L Vw== Received: from iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta02.appoci.oracle.com [147.154.18.20]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3wf8gd891j-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 24 Feb 2024 07:44:30 +0000 Received: from pps.filterd (iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 41O4ibeW012689; Sat, 24 Feb 2024 07:44:30 GMT Received: from nam11-dm6-obe.outbound.protection.outlook.com (mail-dm6nam11lp2168.outbound.protection.outlook.com [104.47.57.168]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3wf6w3fe46-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 24 Feb 2024 07:44:30 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JdKFx1/2fOIqdjojfIH4VWtyxH1xnPJ0pboMAQwW4azP8Zl+oX5pzC+4EYsH+6TRYeBPTVHN3WopRgcH2WVkqj9qMqUnI8jCa0kEQT7wliX1vGgXKw7K4gVH/cbim7vavuIoz3whDM/NqL2dCKnbSlB9KA73S1Zq4iD8gb/WIj8taT3cYETn25nPWbw7Mw4x3Apit3h8EF8Mc4Xwz/ThTHoSyqVRgM0s0p9y0td1h4qg5KB3zTGK2fWBO79v25vdYyvi8NEmzNm8oodYitKnQly4cNHcPSZlT4a/zsdX6qQCJPmdj0cRE2tWP9UjMbGOiCT+AyUzbEQJtDPJfUgYlQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=50NBJVD5Xvw3DFPkGr+4gQMSG184YWI9CmNz7u65Riw=; b=kDfgLWrKebl5qyagZD4GgfpuIgpUKUNmwRcgzWAES7n1lGvuuurNk1QRxv9D84pqbc4sKqutmQuPpN/NLCPI2LSY3EIIwg05DbaJ25Qh0gOLF10nYPUuqJCzMHPj4OOGHhjoT1eufxRtw12boaBNFdGVFhFP7KWjaFpap8f++j+ODaogVHUMFgzi9xbveo7k8QTsIovHn/orLkNXE0g1bdfaW7rhGaRuwYu4/F8755clkfieeA7XgLy1qYSEbaFfI+2eMvEhRrTqjChWj8b5gVwH5uNDsd9n4/kED9AkXYkIP3+bW5XTLOqjv+2gbLvL6qA61jCaxuzpteGPp8XuZQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=50NBJVD5Xvw3DFPkGr+4gQMSG184YWI9CmNz7u65Riw=; b=sJezdAS2sHmoof88WvYwCnNvRV3i2tzuXzlNIOjLDWJfyQEfsGl5islc8W+8j9YFdSJrlqtcLsDm1Encwq0QNrMr7AN0lXsffEFga11Hkc1myoGd4gsTquzswE7OuQCGFxNc5NNSCKOoRnDck8OAjHxkCsH5uHEWaU43+zwm3zg= Received: from MWHPR1001MB2158.namprd10.prod.outlook.com (2603:10b6:301:2d::17) by DS7PR10MB7345.namprd10.prod.outlook.com (2603:10b6:8:ef::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7316.27; Sat, 24 Feb 2024 07:44:28 +0000 Received: from MWHPR1001MB2158.namprd10.prod.outlook.com ([fe80::a450:c423:d1fb:3f86]) by MWHPR1001MB2158.namprd10.prod.outlook.com ([fe80::a450:c423:d1fb:3f86%5]) with mapi id 15.20.7316.023; Sat, 24 Feb 2024 07:44:28 +0000 Message-ID: Date: Fri, 23 Feb 2024 23:44:25 -0800 User-Agent: Mozilla Thunderbird From: Indu Bhagat Subject: Re: [PATCH v2 2/9] aarch64: Align SFrame terminology in comments to specs and x86 To: Jens Remus , binutils@sourceware.org Cc: Andreas Krebbel , Richard Earnshaw , Marcus Shawcroft References: <20240223170800.3993092-1-jremus@linux.ibm.com> <20240223170800.3993092-3-jremus@linux.ibm.com> Content-Language: en-US In-Reply-To: <20240223170800.3993092-3-jremus@linux.ibm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: MW2PR16CA0031.namprd16.prod.outlook.com (2603:10b6:907::44) To MWHPR1001MB2158.namprd10.prod.outlook.com (2603:10b6:301:2d::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWHPR1001MB2158:EE_|DS7PR10MB7345:EE_ X-MS-Office365-Filtering-Correlation-Id: a4dc2369-47e9-440d-cfd5-08dc350c6de9 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: juUgHflws8Os/4o+BFtlp/ptMnWFj2XugemwxvSlc3+DMuu4H5r3uNzuj11mXq4inSMe7gBQ25UbwEADbthKDjsrvqp6uqzNSB2nPSfUkFLd7ArU6rP0HdJc2LLrZ2EWhXEuNJ7ejwD9YKMX2k0Eznefn04TeKDleBqwAuQz92GdxyQgMTRX0AFcJiZCXuzi2teKdj53kyRAqq/E9+Wil62V33Ly+5rTINICaqgoURsYVgBphR1lgD3FbhLZSJZ2q7yLwDR9RS77XbGGC/MwVkPX2rnoF23L0Oj3dtuRmD0WXUHZRsy+Az1WwdyrF9dBek+wkQgW8auzUDJdufHR7QYKA9elArbxIVWGEw1VjjMvhly3x69lTDcaFHAauKo2CAyTMB2xIP0rvhaFwnPN7jMHYJe74Xwte8rmrZOR39cwJ1ZXJj4NGJYaFPQo2Aid+6cF5VsvXvK6AbqfVpCsUAjgZtn20DImQ9WJalSLn+oTCY4Jx3NphU9nqvgvDcctCcMQPtrVTxdzkmGSVXka809G01yEI7qW2v2nk9an9O8= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR1001MB2158.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?KzloaG9vNjJ6ZWFFSlNBVFgvbS9RNUNaKzA0aTlZL3hHTnJWOXh0TzRpaGFP?= =?utf-8?B?MGIxZGFSaXJ1TmJTL28xWjErQktKY3dLckxHUUJLUE5Yc0d0YXZmWlcvcEJY?= =?utf-8?B?RWp0QUxyYkNEZWZxZlBKZmxYa1N3YTNpMC83RWRROUJuOGdJRzF1aWJ2Q29E?= =?utf-8?B?UHJVYWlvUHJqY3dVQ0NTcG9nT01SVGp1djFTaE91SlY0cFc1bkxjcUhyUXRt?= =?utf-8?B?SGJzc1IycmZHZjBrTS9vcHRwZEdSRG1md3B3Yy93SUp4aVd0eWI1d2EycTJD?= =?utf-8?B?MWJhcUV2NFpRbG5sK2NXNUFONlJsN1kxTmFkMXMrUFZSNDFsYmdMMHZqc0Zj?= =?utf-8?B?TTZSTGRVVHVTUGhlOEwzaytqdC9RblVETmpWSmlyVlhlUlhPV1Vpd0RTY0ZH?= =?utf-8?B?d0dRbUxWYjc4Vldyd3pIZndyU3BzZlpSbERlVURISmdsbXc0OEhnTmdQN2hr?= =?utf-8?B?ekdpbUNObzJmMWV0cHIxejhZakczeUFjdU9FYjh3RkpQK3JXc0NlRGpCcDJS?= =?utf-8?B?T0U2S0dCTzAwZDFJYUIvWXFnR09rczdDc1dIUm41czV3c2RsUlNrbk9ZYXdH?= =?utf-8?B?SHRNdnNZeGloNEowUHo5NnQxc2ZjNGdRTEI1N1QyWDBvZEU5YitrQTlsSlM0?= =?utf-8?B?R2pSbXhxTG53VlAxMDU5dm00M2x2K2hTSTZkb1E3dE90Smd5TUlpYlc4MmRK?= =?utf-8?B?VzhIb05PTnNBaUFUeGQ5R0xXUHdzQWpoQ3pGM3B3NHZtbEEzNEZrY2pTdmk1?= =?utf-8?B?bHBzSUh0Z1A4UDdQV3J1eFE0WWRxRVNGRkhEWlg3UU1kbXdrNFlxelUyNFZT?= =?utf-8?B?V2NPajhKTGtsQUh3ZHlSb005Tm9ZQjZWL2Rvekl2bXVBcHZhdmpaRUR5bVho?= =?utf-8?B?NklEN01LTnNEWWVROFo4VG9Qb1oreCtkZHlnUDlqdlh0Vi8rTmhzeERydU9C?= =?utf-8?B?MTJMalZ0TTdGK0lLOGlrUGVrVzN0cVgzRWFLVGNjVHg5T2RGVk44SFBnOGtC?= =?utf-8?B?ZG9JdDVEdHNBQUlsRkFRdUo4NStnU2hidENvUFZpR3A5aTg0TERoTkV0bVJl?= =?utf-8?B?QjZlNzRVb25wbTg4bVFROW85Uk1HY01EN3d5cTlLdEJaRjRYUFFqUkt0WGdU?= =?utf-8?B?SjIyWk0wMURUcThJMHV2WnBsK29LdEdBSlB3cTRzNGdia25UQ2I2WmNMekhn?= =?utf-8?B?L3F4ZEtqTytDL3hmMFZFdHNpL09hRVEzc3JRcTFjVVlpWmFVSFo5L1FUcjRD?= =?utf-8?B?cE5kZ3VvWmZMZzhNcUIvR1pyVnFYbjFjUFNFc0lseHU3Z1A4YWoxTTB0TWhP?= =?utf-8?B?dDVUY1hNMG9KUWhVV0prMVZNMi9XenF3UmtyOU05T01NeUlyTmg4MmxlYlBR?= =?utf-8?B?V0JlN3hvV0hndlRzVVNjWjM5TldycVo2eHRSbjZ5WDB2M1hmQ2VBdlVmRld2?= =?utf-8?B?OTZUcG5FVlR0M1dLWitKRVQzTG9nL3pQVzNUUFdMUnlsN2RxajdqNkpaMnd4?= =?utf-8?B?dTZEeFRxeHBESVUwU0tVSG13R3hZaVd1LzVTYmN0YkRid05ad0dDa2VWZ0Ra?= =?utf-8?B?VHBmTTlab3lmSWljQkNhTVhBNzJkY3l0QjRIelQxd09ONk5WRkV0QlBES1cz?= =?utf-8?B?TGlsaXJGaXBoM2grR3A4NUhtbTYrazRKR2lPaElvY1pqbVpCVHpsSHd3VFJz?= =?utf-8?B?azhDcll2WjRtbWp1Qml3dWwxbk9URGpUa3RCTXYxMGUyRGtlY2puRU5mc242?= =?utf-8?B?bXR5STZFTnZFRVlaWjZRR1ZYVlVDWDhFZnlpQnRiRWtKMTlJdFpNQWxEMmdC?= =?utf-8?B?U2ZPOUJsanlCMC9QWnlZTW1zcDA4SkRXMUZ3N3U2MHEzL3VFZWo4azZ1bWRN?= =?utf-8?B?QlhCRVIwVXFYOFpnQ29yL21lbkR2M1JMRVExZGwzSnA4c0hMS3ZxTzJjOUc2?= =?utf-8?B?Sk5FVXRmUTNEVzBGai93QUpYV2wwNmtDNHN2Y1VTUjVEZEN2RDJOWDlpQjRR?= =?utf-8?B?dDVOMFBhelhod2ZBUWFvMG9JSmRQQmtDQjZDc1g4dExhUlNiaVEwS2J2b0g2?= =?utf-8?B?MWtPSE5FWGpoOXVXalhPMXdvMllkcHVqbDJjN3FST3VQM25kVk9vQUFweThH?= =?utf-8?B?QTlNd2VSN1p1WEpPd0dscFE0L2pSaC85bWs2cGpueWYvQjA5VHdzK2V1ODVa?= =?utf-8?Q?0ZhsXvKnlRlA1O00sxHBd8s=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: F0aD1SEBIKn1gkkPtz/sqRXskNs+aBXCcZeTSb0jWp0SPoFCCURUePHuzCNS2o5LGKddCGD66MsbOs7Gw7Xe3tPMCmuS3lsIa80ZmtpkQ7UIsd83KFeZibJPOw2Axxy01GbodryT1Er2sLIKrQC7RqAlrSblt/JNZ1G/R2hPfiNETPHYdMM8MDgcst9Lt3ETbPT7F9a1PCllVrGaUbi8TVUarHdVXFaXb930dvlURD5f0iEv1EybM+gdVbBrVGd0gdAt4L8HpBMDWpnFmwHAf9kAkqyavk/2/JfD/HVPefY4wFTiT8/mzPeuDnzo3G/d2nPUhIAnoKuO0rUxWghmlfjXej01tEixz8KdVbFHghznKQUe5vBVz3MIyBwOY8ut/z+BwLJMHhaYXEhpEPrgkbwNYCA9uqGuk2a+iwEL6Y3NI/LF4SCtsTAUoffYq7o34ZGXqPDoZEYJkmH+vSWiEPxxmolxFmkojZ/RR42WBO8knb7e8C3b/OVPD54//eBEhTVQX2djKQgvyrfE5QPFv3YbpXAB8MYMs1YBCfR2SqsI2dmbjqhxh6izFJnCgxLY9+6BWyG8iiO20cMcDiINwre1hY0dEfhlsFrJbpDGnqM= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: a4dc2369-47e9-440d-cfd5-08dc350c6de9 X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2158.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Feb 2024 07:44:28.1387 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: xOe2oO4yeiGffRkPTACuyfhP4NjB6QgvysxF0yRUsKt8+tvRwNRT6IChzRAmMhMOp+Gaj2VHSe9r4Sof+TCC8g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR10MB7345 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-02-24_04,2024-02-23_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 malwarescore=0 adultscore=0 mlxscore=0 mlxlogscore=999 phishscore=0 suspectscore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000 definitions=main-2402240062 X-Proofpoint-ORIG-GUID: BLYERC1zIc1bWwoxkL7SNSICgiLS3wTx X-Proofpoint-GUID: BLYERC1zIc1bWwoxkL7SNSICgiLS3wTx X-Spam-Status: No, score=-12.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,KAM_NUMSUBJECT,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2/23/24 09:07, Jens Remus wrote: > Use the term "frame pointer" (FP) instead of "base pointer". This aligns > with the terminology used in the SFrame specification. Additionally it > helps not to confuse "base-pointer register" with the term "BASE_REG" > used in the specification to denote either the SP or FP register. > Thanks for noticing and fixing these. > While at it align the frame-pointer and return address register comments > to the x86 AMD64 ones. > > gas/ > * config/tc-aarch64.h: Align SFrame terminology in comments to > specs and x86 AMD64. > Subsequent lines in the ChangeLog need re-indentation as pointed out in review of [Patch 1/9]. I will skip mentioning this for the rest of the patches in this series from here. > Reviewed-by: Andreas Krebbel > Signed-off-by: Jens Remus > --- > > Notes (jremus): > This patch can be dropped, if subsequent patch "sframe: Enhance comments > for SFRAME_CFA_*_REG macros" gets accepted. > Yes, makes sense. Lets drop this patch and keep the next one. Thanks > gas/config/tc-aarch64.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/gas/config/tc-aarch64.h b/gas/config/tc-aarch64.h > index 1b8badad9fdc..599d78db7908 100644 > --- a/gas/config/tc-aarch64.h > +++ b/gas/config/tc-aarch64.h > @@ -271,11 +271,11 @@ extern bool aarch64_support_sframe_p (void); > extern unsigned int aarch64_sframe_cfa_sp_reg; > #define SFRAME_CFA_SP_REG aarch64_sframe_cfa_sp_reg > > -/* The base-pointer register number for CFA stack trace info. */ > +/* The frame-pointer register number for SFrame stack trace info. */ > extern unsigned int aarch64_sframe_cfa_fp_reg; > #define SFRAME_CFA_FP_REG aarch64_sframe_cfa_fp_reg > > -/* The return address register number for CFA stack trace info. */ > +/* The return address register number for SFrame stack trace info. */ > extern unsigned int aarch64_sframe_cfa_ra_reg; > #define SFRAME_CFA_RA_REG aarch64_sframe_cfa_ra_reg >