From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.111.102]) by sourceware.org (Postfix) with ESMTPS id 1E8953858410 for ; Mon, 21 Feb 2022 14:25:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 1E8953858410 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05lp2107.outbound.protection.outlook.com [104.47.17.107]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-16-3xbtIjgDMgKyarG07FdIlw-1; Mon, 21 Feb 2022 15:25:41 +0100 X-MC-Unique: 3xbtIjgDMgKyarG07FdIlw-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=U6ceywSsihHYp+h/4vnMMYgD47ugJK6YvRV2IdlY+JOUWWlpzjEYNoH+qOjvCGHNPbV/XjT5Y5LM2nYt6CBsxm0VgiJDNpZwISAF314h8HzPfJrxIDPT1dzY6G8mhxiDPtWBAyj5c4TBn6gLn9oyBSC41xh1a1n+oSa1IKu3leZp0XuBFxPp/d7kf6NhhK/gnEB7H00uSh6ZOf7l8ilB1mxj5DtMX9+VhpBC8NpXU7+ZPLtNDJPahajFSgtFtUN70LgPmzKEROf70IsZxEa/dxjgOhmcuavwfITUSiY9alZx1TrRKmZLcM34u/SYePwhhfltv7KrkmbTkOQnTsIlLA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=eA+Q6zOPrR8PQ3x4gGlkCPDookG9AoThoIE0AfDab/E=; b=EVOS4HIyu5D/OxU+H5vXgcj5/Dv+pDJgmNcQ7nTfHaPS30+aGLQEa18zNp+YQMZpoTDiVG4wSwQx+vJsSqQeXIzy2IJy9fVhtE/EImEEE2K+ksw9IGRvj4HtLdYszSeQhsDXx6LPYZS+fIsrpRnfK+sM2NHJX+l/o28wfC/Y3orN+ahhaPndLofz62Q2h7rGVh+vzZjZ0zZRPbIuZpxtHqUbSbriMixH/zZBjILHZbhfm4bljqJ1zaYY18TwtXxsUpaI7PupTObuqho7qrQff7lyjVMwrnd6JtvPkk8ZAwya4XojlBKzlyfq2Dx+meDKvedQjuPh7JkzwnmKbTCFkQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by AM6PR0402MB3640.eurprd04.prod.outlook.com (2603:10a6:209:1f::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.26; Mon, 21 Feb 2022 14:25:39 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::d479:b728:345c:bd65]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::d479:b728:345c:bd65%6]) with mapi id 15.20.4995.027; Mon, 21 Feb 2022 14:25:39 +0000 Message-ID: Date: Mon, 21 Feb 2022 15:25:39 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [PATCH v4 1/3] RISC-V: Minimal support of scalar crypto extension Content-Language: en-US To: Philipp Tomsich , jiawei@iscas.ac.cn CC: kito.cheng@sifive.com, nelson.chu@sifive.com, jimw@sifive.com, mjos@pqshield.com, ben.marshall@pqshield.com, cmuellner@ventanamicro.com, palmer@dabbelt.com, andrew@sifive.com, lazyparser@gmail.com, siyu@isrc.iscas.ac.cn, schwab@linux-m68k.org, binutils@sourceware.org References: <20211115030343.276103-1-jiawei@iscas.ac.cn> <20211115030343.276103-2-jiawei@iscas.ac.cn> <1490a2a8.1571c.17f1ca1de44.Coremail.jiawei@iscas.ac.cn> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AS9PR06CA0100.eurprd06.prod.outlook.com (2603:10a6:20b:465::11) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 2bcd28d0-f3d7-42d3-093d-08d9f54608cc X-MS-TrafficTypeDiagnostic: AM6PR0402MB3640:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: nSJd2wnXpRO4fZr0hpJe5tjyWWN+YnkC7n621nljhxii5azlna3p/eyrlwTMgjUdgVoyTqgXAchqspnWFgzDI8xGR4bpznwmyPBD23EYxKM3CODwgJfjoTXAwN4oYa5R6PD4KJgRjindbKzY2dd6yBxjyO+fdXLJxVQCSgfw/9xOA+9xUoaN0eB3VEW8zNYleUsPJVyTaL86n2hl4L0fdsG0uN/k/uIkVZ9TlrH77uFDE1Mj9RDAxw6Pbri91zkl+A/ip6oclI9ml7sk9Mk8HujUg6l+3u33a/bBSR6TTUEn0i0uDM/FiT5qU8k6kH4OpUe2vKOMtvdeTxr4BPWeHE2Ml/196LIIxSbUGVUyMp+oA21Z17WsL7vXHS9PJm24346C1OR3OhKHUjbintfS7tnQyVRojnbWpSw2yzNkPyLwEPmmlvYkCcGfiscXRV6iBU7+ZIB34We6ZjrngnxQ5OlgV9L+1yk7ugPnQbxS56PJ5BcumZB3eoYAbZpqdklzDIrbZJgqqH4UzQKzSmhWgdCLV+6OcAYnFTkt4HKAzK6QVWInTf4IMhc5VF/vsKGpp0BddxDQb88YH0PKbT+rz48nJfJGTosoPeQKCJzL/2z7uXI05uoff4M4CMHSlqfHjLIeNYdki6L6E6+aqbth6FZZD2haOguaQx4X8FQHV1R2UEnt82xwYFPacJTIW1hAGFJ5U/TR2Vh1GLITa+yHN4fu19osPPhEgfx8pUE4l1A= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR04MB5600.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(5660300002)(8936002)(6506007)(6486002)(53546011)(2616005)(186003)(83380400001)(31686004)(6512007)(26005)(36756003)(508600001)(66556008)(2906002)(38100700002)(86362001)(8676002)(4326008)(31696002)(7416002)(316002)(66476007)(66946007)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?UPiXSSBm8kFAbmmJJytIZsUMIT0FYHY7PFte8tDzGIAaerkvInAZmksfy3AA?= =?us-ascii?Q?OASPQoSW0wyG+wBl8CjwCEiFl9XzvvJoXZ7jPEawwT5czuhAR8bloQAGkXbn?= =?us-ascii?Q?/r3Cf5tlkdn3EbeXI6Sd4JLIbv+y3CzIWu37xuX709NPmxuxGTvBKja0mktN?= =?us-ascii?Q?yoFZhLsE4VRnx0lhL4lAMRMmw+vnXxNVo9nBNkPAHqDo21GTQMu0V0kNzCS6?= =?us-ascii?Q?ES/rCSpv20whGAXajIGdrBxv0Q4kCfs5U2yqghVhCJXkjlAhKayLtk3WfzUp?= =?us-ascii?Q?lF7Unee+Asl8UF3xkJMpcWkYAMLr9XS72zIKMFAHUNA5LyR/aqRQxfq9KgIq?= =?us-ascii?Q?rPvekjJpWdNBsgnLC0XMdddlexQ6+OsmG91SlK373VC9bhO8HmTknCTcxmkP?= =?us-ascii?Q?3WJLpM4HmyyWhLoqB1ZogCzZXP/gFWJTYHA5318e0eYrQxLC4wC9QZq69Cx7?= =?us-ascii?Q?3tnx83a620WqotNth598kKNmt8Dc8j6GvPTN/UViNvwCOlESljp8N5B+84Ga?= =?us-ascii?Q?5wUR07aQU3GerFJ0t/Q5pVUwYvjDbD646bWZiBmO0NZm9p0fSgW3pQOL1OUK?= =?us-ascii?Q?dBpEPGhj7IbRMja02NJGeSrbj6Maupu9qemq7NqJ523G39qKxTocOsZC2t/Q?= =?us-ascii?Q?ZnPY0qS97JyPgP6c6y40t7ai++Clkma9L/RzP+o7ohtZ5LXsoZaeLIj8FjcP?= =?us-ascii?Q?ovScRb9Xv2y7ydTly4RQKUhZmR4s6BzZOn0snknolb1mPyIGwu05EJgcjgoK?= =?us-ascii?Q?LKakKuJV5dsw51aioICMCwPCkN/gE/AZzlZl4sy2taLkGIIsBy0RxWGjAl+B?= =?us-ascii?Q?iW39rZJKhhhvXP0j+clT5nEs2fJOPrvkt+Svt0tVJGbk8z9lP2qx4Kim2bdj?= =?us-ascii?Q?37VUJafPW7XE663nkn7Y1ea9dwi51W1w++frqyyh39QnIMC6muWQEZtxbW10?= =?us-ascii?Q?zjzM/asIYAO+cENSp/7OU8cWrja0rS1b1w28KSyqXZ/QvTF9/Dxfk/oJSK2o?= =?us-ascii?Q?FdbI8dPs1Z+kuJsoKTSQXUoAYQItVim88vcCB4M/KooiRRC66pHJfBKE6lk0?= =?us-ascii?Q?mu3MtI9t1YAkNH7zQd2zkRWIgwqwEy+H27FVvciXan07vqt9heYT/+TOvDjm?= =?us-ascii?Q?bsyPA0GjyvmBbburKh32OGgXvRRDlPmW4vhTjkuKdkXApFfk4cBtCJhs9TXh?= =?us-ascii?Q?BmepDJjSjUhNzx7DcRgn9DDPnegBxxqO4GYVTHIK5096P2MKRTXDzD5UQA1A?= =?us-ascii?Q?wGSXVznQdFNhHx+MN3cgOdCyEIQPpJOl3XMed+OZt72IUQDoIfzdAhL+Ut0P?= =?us-ascii?Q?6Ba4mt+gOBNpVx9pZXEDJy4S6/XtykObpUs/ryVQ6cnZItb8zc+NbaXB/wYL?= =?us-ascii?Q?mxAvdxOcCsri9C1u3Fbhx3TcH5QUk9Oc55YSmlOrcmopPauZMDpJfvp0T9/b?= =?us-ascii?Q?8h9vYFZWUM5eCPVmh7Mq2k7JrtIDcZsrwh9ZbdH/lgAAAyt+d5lTjrAG5o11?= =?us-ascii?Q?n573hHdjQY2iaf/d+FtpOvTV0cSGeV7dBTNiSTF4mmmbagHOIrUZzCQ+zQZl?= =?us-ascii?Q?RQtM1BH37A0yrzHocun0YrO4RKihmkzZdFgJMQRGeel+qh4IrJjj6DqBg62A?= =?us-ascii?Q?WfUPkSgOo3cjQ5+8nC2GExc=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2bcd28d0-f3d7-42d3-093d-08d9f54608cc X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Feb 2022 14:25:39.5459 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: O98bkgnUXltLUOAt1mNLAx8nNYRJdXuvbRNt9Nb2gqONhiqLFWIWDc3hAP/wRtW+FchCh+3NP7IWX40m8GE1Vg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR0402MB3640 X-Spam-Status: No, score=-3037.3 required=5.0 tests=BAYES_00, BODY_8BITS, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Feb 2022 14:25:46 -0000 On 21.02.2022 15:16, Philipp Tomsich wrote: > On Mon, 21 Feb 2022 at 15:14, wrote: >> >> >> >> >> > -----=E5=8E=9F=E5=A7=8B=E9=82=AE=E4=BB=B6----- >> > =E5=8F=91=E4=BB=B6=E4=BA=BA: "Jan Beulich" >> > =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2022-02-21 21:24:11 (=E6=98= =9F=E6=9C=9F=E4=B8=80) >> > =E6=94=B6=E4=BB=B6=E4=BA=BA: jiawei >> > =E6=8A=84=E9=80=81: kito.cheng@sifive.com, nelson.chu@sifive.com, j= imw@sifive.com, philipp.tomsich@vrull.eu, mjos@pqshield.com, ben.marshall@p= qshield.com, cmuellner@ventanamicro.com, palmer@dabbelt.com, andrew@sifive.= com, lazyparser@gmail.com, siyu@isrc.iscas.ac.cn, schwab@linux-m68k.org, bi= nutils@sourceware.org >> > =E4=B8=BB=E9=A2=98: Re: [PATCH v4 1/3] RISC-V: Minimal support of s= calar crypto extension >> > >> > On 15.11.2021 04:03, jiawei wrote: >> > > Minimal support of scalar crypto extension, add "k" in riscv_s= upported_std_ext[] to make the order check right with "zk" behind "zb". "= zbk*" is sub-extension for k-ext, so it added behind "zbs" in riscv_support= ed_std_z_ext[]. >> > > --- >> > > bfd/elfxx-riscv.c | 28 ++++++++++++++++++++++++++++ >> > > 1 file changed, 28 insertions(+) >> > > >> > > diff --git a/bfd/elfxx-riscv.c b/bfd/elfxx-riscv.c >> > > index 3ffbaad66dd..152fbe3d160 100644 >> > > --- a/bfd/elfxx-riscv.c >> > > +++ b/bfd/elfxx-riscv.c >> > > @@ -1075,6 +1075,20 @@ static struct riscv_implicit_subset ris= cv_implicit_subsets[] =3D >> > > {"q", "d", check_implicit_always}, >> > > {"d", "f", check_implicit_always}, >> > > {"f", "zicsr", check_implicit_always}, >> > > + {"zk", "zkn", check_implicit_always}, >> > > + {"zk", "zkr", check_implicit_always}, >> > > + {"zk", "zkt", check_implicit_always}, >> > > + {"zkn", "zbkb", check_implicit_always}, >> > > + {"zkn", "zbkc", check_implicit_always}, >> > > + {"zkn", "zbkx", check_implicit_always}, >> > > + {"zkn", "zkne", check_implicit_always}, >> > > + {"zkn", "zknd", check_implicit_always}, >> > > + {"zkn", "zknh", check_implicit_always}, >> > > + {"zks", "zbkb", check_implicit_always}, >> > > + {"zks", "zbkc", check_implicit_always}, >> > > + {"zks", "zbkx", check_implicit_always}, >> > > + {"zks", "zksed", check_implicit_always}, >> > > + {"zks", "zksh", check_implicit_always}, >> > > {NULL, NULL, NULL} >> > > }; >> > > >> > > @@ -1127,6 +1141,7 @@ static struct riscv_supported_ext riscv_= supported_std_ext[] =3D >> > > {"c", ISA_SPEC_CLASS_20190608, 2, 0, 0 = }, >> > > {"c", ISA_SPEC_CLASS_2P2, 2, 0, 0 = }, >> > > {"b", ISA_SPEC_CLASS_NONE, RISCV_UNKNOWN_VERSI= ON, RISCV_UNKNOWN_VERSION, 0 }, >> > > + {"k", ISA_SPEC_CLASS_NONE, RISCV_UNKNOWN_VERSI= ON, RISCV_UNKNOWN_VERSION, 0 }, >> > >> > May I ask what purpose this addition serves? Without its use enabli= ng >> > smaller scope extensions implicitly, I find it at best unhelpful th= at >> > ".option arch, +k" is accepted without having any effect. >> > >> > Jan >> >> It's same like bitmanip extension, add this will make k extension as a s= ubextension >> and set it's canonical order as ISA spec defined. >=20 > Let me point out that this is not the same as with the > bit-manipulation family of extensions. > Zb[abcs] are all standalone extensions, and there is no Zb. Then there the same question arises: Why does gas accept ".option arch, +b"= ? Jan